On Thu, 9 Nov 2023 05:01:35 GMT, David Holmes <dhol...@openjdk.org> wrote:
> I remain concerned that this means that a whole swag of tests will never be > run with virtual threads, which reduces our virtual thread test coverage. > Hard to quantify. Do you have any stats on how many tests this will affect > and which ones? I thought the purpose of the createLimitedTestJavaProcessBuilder is for use where vm option are NOT being propagated to the ProcessBuilder, as such the thread factory property wont come into consideration ? the Java doc notes that test using createLimitedTestJavaProcessBuilder would be marked as vm.flagless which would suugest thread factory is not being used. createTestJavaProcessBuilder is for use when vm args are being propagated and as such thread factory can be "injected" via this method. So this change is streamlining these use cases. Is this a correct interpretation? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16442#issuecomment-1803595745
