On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year > 9999
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use minus sign from cached DecimalFormatSymbols and improved testcase
Looks like your fix causes a regression test failure in
test/jdk/java/time/test/java/util/TestFormatter.java
----------System.out:(1097/72894)----------
test test.java.util.TestFormatter.test("en_US"): success
test test.java.util.TestFormatter.test("th_TH"): success
ChronoZonedDateTimeImpl(Japanese) actual: D:[04/19/05] F:[2023-04-19]
FAILED; expected: D:[04/19/05] F:[0005-04-19]
java.lang.RuntimeException
at test.java.util.TestFormatter.test(TestFormatter.java:198)
at test.java.util.TestFormatter.testDate(TestFormatter.java:216)
at test.java.util.TestFormatter.test(TestFormatter.java:114)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599)
at
org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
at
org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
at
org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
at
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
at org.testng.TestRunner.privateRun(TestRunner.java:764)
at org.testng.TestRunner.run(TestRunner.java:585)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
at org.testng.SuiteRunner.run(SuiteRunner.java:286)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
at org.testng.TestNG.runSuites(TestNG.java:1069)
at org.testng.TestNG.run(TestNG.java:1037)
at
com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:102)
at
com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:58)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:1570)
Please make sure all the related regression tests pass.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16033#issuecomment-1804237006
