On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote:
> 1. Primitive array VHs are now singletons and no longer need to record their
> array base and offset in their object themselves.
> 2. Moved Unsafe offset calculation to a utility method, like `index` in
> VarHandleByteArrayView.
Sharing cod
On Thu, 9 Nov 2023 06:43:12 GMT, Jaikiran Pai wrote:
>> Tests that directly use ProcessBuilder to spawn processes and do not pass
>> the standard test command line arguments should be marked as `vm.flagless`
>> to indicate to the testing infrastructure that they do not accept them and
>> shoul
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
Problem:
There is syslookup file which expects the required symbols to be exported using
the co
On Wed, 8 Nov 2023 21:14:41 GMT, Magnus Ihse Bursie wrote:
> Also, please don't ever force push once you have published a PR. Now it makes
> Martin's comment just dangling in the air.
@magicus I think the force-push happened whilst the PR was still in draft
(skara bot did not complain), which
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
I agree with Magnus that we need to understand the problem first, and then
review the solution.
On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should not
Oh, I will also add a specialized version of this method to
java.util.function.UnaryOperator. That is because UnaryOperator is a
subinterface of Function. Function goes T -> R, but UnaryOperator just goes
T -> T. We do not want UnaryOperator to have the T -> R static function
included due to inheri
It has been a month since I sent this proposal. Since no one has told me
that this is a terrible idea, I will submit this as an enhancement to JBS,
and once the ticket is made, start work on creating a pull request.
On Tue, Oct 3, 2023 at 3:13 AM David Alayachew
wrote:
> Whoops, bad import.
>
>
On Wed, 8 Nov 2023 19:13:25 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread f
On Wed, 8 Nov 2023 19:13:25 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread f
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct behavio
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the Islamic Calendar to Hijr
On Sat, 21 Oct 2023 12:04:10 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
Marked as reviewed
On Tue, 24 Oct 2023 15:09:57 GMT, Jorn Vernee wrote:
>> Add the ability to pass heap segments to native code. This requires using
>> `Linker.Option.critical(true)` as a linker option. It has the same
>> limitations as normal critical calls, namely: upcalls into Java are not
>> allowed, and the
On Wed, 8 Nov 2023 15:45:56 GMT, Konrad Windszus wrote:
> I know, but for memory consumption reasons everyone should prefer just
> passing an InputStream. Is the memory consumption with
> `ClassFile.of().parse(Path)` any better (i.e. are you using a
> `java.io.RandomAccessFile` or `java.nio.ch
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote:
> 1. Primitive array VHs are now singletons and no longer need to record their
> array base and offset in their object themselves.
> 2. Moved Unsafe offset calculation to a utility method, like `index` in
> VarHandleByteArrayView.
@liach You
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote:
> 1. Primitive array VHs are now singletons and no longer need to record their
> array base and offset in their object themselves.
> 2. Moved Unsafe offset calculation to a utility method, like `index` in
> VarHandleByteArrayView.
Note that t
1. Primitive array VHs are now singletons and no longer need to record their
array base and offset in their object themselves.
2. Moved Unsafe offset calculation to a utility method, like `index` in
VarHandleByteArrayView.
-
Commit messages:
- Use the base offset and index scale co
On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should not
This change simply replaces "period" with "duration", or in one case replaces
"period unit" with just "unit".
-
Commit messages:
- 8319753: Duration javadoc has "period" instead of "duration" in several
places
Changes: https://git.openjdk.org/jdk/pull/16573/files
Webrev: https://
On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should not
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
Also, please don't ever force push once you have published a PR. Now it makes
Martin's comment j
Tests that directly use ProcessBuilder to spawn processes and do not pass the
standard test command line arguments should be marked as `vm.flagless` to
indicate to the testing infrastructure that they do not accept them and should
not be run with extra test command line options `test.vm.opts` an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
First and foremost, the `make/data/hotspot-symbols` directory is, as the name
says, for hotspot
On Wed, 8 Nov 2023 17:19:56 GMT, Tagir F. Valeev wrote:
>> In that case the integrator should be a BiConsumer too, no ?
>
> @forax I thought so initially, but this is not so easy, as there's a `Greedy`
> subinterface. If you adapt the `Integrator`, you will lose the ability to
> specify the gre
On Wed, 8 Nov 2023 21:04:47 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
No, no... This is bad on several accounts.
-
PR Comment: https://git.openjdk.org/jd
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
Viktor Klang has updated the pull request incrementally with two additional
commits since the last revision:
- Addressing review feedback
- Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
On Sun, 5 Nov 2023 16:38:38 GMT, Tagir F. Valeev wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
Changes requested by mdoerr (Reviewer).
LGTM. You may want to replace the Copyright header of th
1. Adding required compiler flags.
2. Adding required symbols.
JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
-
Commit messages:
- Update symbols-aix-foreign
- Symbol Resolution fix for Panama changes.
Changes: https://git.openjdk.org/jdk/pull/16414/files
On Fri, 3 Nov 2023 20:01:44 GMT, Eirik Bjorsnos wrote:
> > I can kick of a test run internally next week or perhaps Sunday
>
> Thanks for your reviews, Lance and Iris!
>
> FWIW, the test ran fine on Github Actions, including on `linux-x86` (which is
> 32-bit, right?):
>
> ```
> TEST: java/uti
On Wed, 8 Nov 2023 13:54:23 GMT, Eirik Bjorsnos wrote:
> > > > I think the changes look good overall. Thank you for this. I am not
> > > > sure that the `@requires` is needed at this point.
> > >
> > >
> > > Was the `@requires (sun.arch.data.model == "64")` added to satisfy the
> > > 8GB memo
On Wed, 8 Nov 2023 16:47:17 GMT, Raffaello Giulietti
wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction t
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.
On Wed, 8 Nov 2023 19:46:42 GMT, Alan Bateman wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 38:
>
>> 36: /**
>> 37: * An intermediate operation that transforms a stream of input elements
>> int
On Wed, 8 Nov 2023 19:52:53 GMT, Alan Bateman wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 194:
>
>> 192: * this gathering operation.
>> 193: *
>> 194: * By default, this method r
Please review this PR which enhances the existing CEN header validation
checking to ensure that the
size of the CEN Header + name length + comment length + extra length do not
exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12. Also
check that current CEN header will not exce
Hello,
I sent an email half a month ago explaining that CompletionInfo#source() can be
null even if nothing is explained in the doc about this. But nobody responded
Now, I also noticed that with this specific code, source and remaining are
nearly equal
```
import jdk.jshell.*;
var shell = JShell
On Mon, 6 Nov 2023 19:26:26 GMT, Mandy Chung wrote:
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
> mechanically convert a classfile for a Class into an in-memory class
> representation of an equivalent Interface. `testPrivateMethodCall` tests to
> invoke a p
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/Gatherer.java line 38:
> 36: /**
> 37: * An intermediate operation that transforms a stream of input elements
> into a
> 38
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16566/files
- new
On Wed, 8 Nov 2023 19:40:11 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switch to parseFloat from valueOf, add links.
>
> src/java.base/share/classes/java/lang/Double.java line 752:
>
>> 750
On Wed, 8 Nov 2023 19:24:24 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Switch to parseFloat from valueOf
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote:
> Updated jdk_core_manual test groups.
This pull request has now been integrated.
Changeset: 4c0f6c61
Author:Bill Huang
URL:
https://git.openjdk.org/jdk/commit/4c0f6c6105a8c7046cc4556d23272750bd9f7682
Stats: 4 lines in 1 file ch
On Wed, 8 Nov 2023 18:04:07 GMT, Rémi Forax wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherers.java line 64:
>
>> 62: *needlessly
>> 63: * 3. allows for more efficient composition and evaluation
On Wed, 8 Nov 2023 17:56:09 GMT, Rémi Forax wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/GathererOp.java line 448:
>
>> 446: private final long targetSize;
>> 447: private final Hybrid left
On Sun, 5 Nov 2023 16:43:33 GMT, Tagir F. Valeev wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/GathererOp.java line 162:
>
>> 160: * consideration at this point doesn't yield any
>> performance gains.
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Switch to parseFloat from valueOf, add links.
-
Changes:
- all: https://git.open
On Wed, 8 Nov 2023 17:03:38 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/util/stream/AbstractPipeline.java line 242:
>>
>>> 240: }
>>> 241:
>>> 242: // Terminal evaluation methods
>>
>> This is needed in order to let subclasses override terminal operations such
>> as, bu
On Wed, 8 Nov 2023 19:24:24 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Switch to parseFloat from valueOf
On Wed, 8 Nov 2023 19:02:36 GMT, Mark Sheppard wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> converted list to array.
>
> test/lib/jdk/test/lib/process/ProcessTools.java line 387:
>
>> 385: */
>> 386:
>>
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factory requires the injection of arguments in the
> middle o
On Wed, 8 Nov 2023 18:41:15 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address issues found by reviewers
On Wed, 1 Nov 2023 17:40:04 GMT, Raffaello Giulietti
wrote:
> Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
> throwing `OutOfMemoryError` instead to indicate that the resulting `String`
> would be too large.
This pull request has now been integrated.
Changeset: a678
On Wed, 8 Nov 2023 02:33:29 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread f
On Wed, 8 Nov 2023 18:41:15 GMT, Joe Darcy wrote:
>> Add discussion of some of the common pitfalls related to decimal <-> binary
>> conversion.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address issues found by reviewers
On Wed, 8 Nov 2023 18:45:47 GMT, Steven Loomis wrote:
>> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
>> Besides the data upgrade, regression tests are modified to accommodate the
>> following CLDR fixes:
>>
>> CLDR-16534: Suggestion to rename the Islamic Calendar
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the Islamic Calendar to Hijr
Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
This change completes the Unicode 15.1 upgrade. The change is merely replacing
binary data files used for the Nomalization and BiDi support
-
Commit messages:
- update the license file
- Merge branch 'ma
On Wed, 8 Nov 2023 18:17:00 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 287:
>
>> 285: * le
On Wed, 8 Nov 2023 18:09:52 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 257:
>
>> 255: * //
On Wed, 8 Nov 2023 17:54:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address issues found by reviewers.
>
> src/java.base/share/classes/java/lang/Double.java line 212:
>
>> 210: * fracti
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might in
Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
Besides the data upgrade, regression tests are modified to accommodate the
following CLDR fixes:
CLDR-16534: Suggestion to rename the Islamic Calendar to Hijri Calendar
(https://unicode-org.atlassian.net/browse/CLDR-16534
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Address issues found by reviewers.
-
Changes:
- all: https://git.openjdk.org/jdk
Hi openjdk,
I want to support
JEP 198: Light-Weight JSON API
with an idea:
clazz deepclone = new DeepClone().do(object_to_be_copied);
class DeepClone
clazz do (clazz object_to_be_copied)
{
return new JSONDecoder().do(new JsonEncoder().do(object_to_be_copied));
}
With kind regards,
B
On Wed, 8 Nov 2023 17:29:28 GMT, Joe Darcy wrote:
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
src/java.base/share/classes/java/lang/Double.java line 257:
> 255: * // Numeric values listed are exact values
> 256: * oneTenthApproxAsFloat = 0.1000
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/Gatherers.java line 64:
> 62: *needlessly
> 63: * 3. allows for more efficient composition and evaluation
> 64:
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/GathererOp.java line 232:
> 230: */
> 231: @SuppressWarnings("unchecked")
> 232: private GathererOp(Gatherer gat
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/GathererOp.java line 448:
> 446: private final long targetSize;
> 447: private final Hybrid leftPrede
On Wed, 8 Nov 2023 17:29:28 GMT, Joe Darcy wrote:
> Add discussion of some of the common pitfalls related to decimal <-> binary
> conversion.
src/java.base/share/classes/java/lang/Double.java line 212:
> 210: * fraction (0.3); but in base 3, 1/3 is exactly
> 211: * 0.1(3), that is 1
On Wed, 8 Nov 2023 17:24:45 GMT, Rémi Forax wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 530:
>
>> 528: * @param the type of results this integrator can produce
>> 529: */
>>
On Wed, 8 Nov 2023 17:26:35 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 490:
>>
>>> 488: * more elements sent to it, {@code false} if otherwise
>>> 489: */
>>> 490: default boolean isRejecting() { return false; }
>>
On Wed, 8 Nov 2023 09:55:13 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 3510:
>>
>>> 3508: : intVal.toString();
>>> 3509: int len = str.length() + trailingZeros;
>>> 3510: if (len < 0) {
>>
>> One could u
On Wed, 8 Nov 2023 16:39:33 GMT, Tagir F. Valeev wrote:
>> That's a good question, and here's my thinking—`scanRight` doesn't make any
>> sense for a construct which supports unboundedness, so if we were discussing
>> *Collections* I'd be more inclined to agree (but it is more likely that
>> r
On Wed, 8 Nov 2023 17:20:56 GMT, Rémi Forax wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 444:
>
>> 442: */
>> 443: static Gatherer of(
>> 444: Supplier initializer,
>
> wi
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/GathererOp.java line 180:
> 178: finisher.accept(state, this);
> 179: sink.end();
> 180:
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/GathererOp.java line 95:
> 93: public void accept(X x) {
> 94: final var b = rightMost;
> 95:
Add discussion of some of the common pitfalls related to decimal <-> binary
conversion.
-
Commit messages:
- Appease jcheck.
- JDK-8295391: Add discussion of binary <-> decimal conversion issues
Changes: https://git.openjdk.org/jdk/pull/16566/files
Webrev: https://webrevs.openjdk
On Wed, 8 Nov 2023 16:27:56 GMT, Eirik Bjorsnos wrote:
> @LanceAndersen
>
> I noticed that this PR did not update `ZipInputStream.readLOC` to perform
> consistency validation between expected and actual extra field size and
> values. Any particular reason why processing of LOC headers was not
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/GathererOp.java line 50:
> 48: */
> 49: final class GathererOp extends ReferencePipeline {
> 50: @SuppressWarnings("unch
On Wed, 8 Nov 2023 17:22:05 GMT, Rémi Forax wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 490:
>
>> 488: * more elements sent to it, {@code false} if otherwise
>> 489: *
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/Gatherer.java line 444:
> 442: */
> 443: static Gatherer of(
> 444: Supplier initializer,
wildcards ar
On Wed, 8 Nov 2023 15:17:57 GMT, Viktor Klang wrote:
>> It's still possible to have a situation where PECS signature could be
>> useful, and I don't see any downsides. A user may want to reuse the same
>> static integrator instead of creating several identical lambdas just because
>> the targe
On Wed, 8 Nov 2023 17:17:21 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 330:
>>
>>> 328: static Gatherer ofSequential(
>>> 329: Integrator integrator,
>>> 330: BiConsumer> finisher) {
>>
>> Probably, accepting `Consumer>
On Sun, 5 Nov 2023 16:18:52 GMT, Tagir F. Valeev wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 330:
>
>> 328: static Gatherer ofSequential(
>> 329: Integrator integrator,
>> 330:
On Wed, 8 Nov 2023 17:10:11 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to invoke
On Wed, 8 Nov 2023 17:10:05 GMT, Tagir F. Valeev wrote:
>> Has this proven to be a problem for things like
>> [Collectors.mapping(…)](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/stream/Collectors.html#mapping(java.util.function.Function,java.util.stream.Collector))
>>
On Wed, 8 Nov 2023 15:23:39 GMT, Viktor Klang wrote:
>> This is especially important given that often you don't know the AA type at
>> all. E.g., imagine that you are doing `.andThen(Gatherers.fold(...))`, but
>> `fold` returns `Gatherer`, so you can specify explicit `RR`, but
>> not `AA`.
>
>
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
> mechanically convert a classfile for a Class into an in-memory class
> representation of an equivalent Interface. `testPrivateMethodCall` tests to
> invoke a private method. Before nestmates, invoking a private cl
On Wed, 8 Nov 2023 16:37:45 GMT, Tagir F. Valeev wrote:
>> TBH I don't think `foldRight` makes much sense for potentially unbounded
>> structures such as Stream. In the case you need it, it might be better to
>> export it to a List and then reversing it.
>
> Well, the unboundness argument does
On Tue, 31 Oct 2023 13:19:30 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> src/java.base/share/classes/java/util/stream/AbstractPipeline.java line 242:
>
>> 240: }
>> 241:
>> 242: // Terminal evaluation methods
>
> This is needed i
On Fri, 3 Nov 2023 16:51:34 GMT, Viktor Klang wrote:
>> Since stream facilities are package-private, we can just use no access
>> modifier and remove all new `protected` access modifier (on methods, fields,
>> constructors) in this PR.
>
> @liach We could do that, yet I'm not sure that is stric
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/AbstractPipeline.java line 223:
> 221: * consumed
> 222: */
> 223: protected AbstractPipeline(AbstractPipeline
On Wed, 8 Nov 2023 16:26:56 GMT, Tagir F. Valeev wrote:
>> @amaembo pairMap should be straight-forward to implement. And regarding
>> parallelization I don't think that will necessarily work since it would not
>> be able to run incrementally (depth-first).
>
> Sorry, I'm not sure what do you me
1 - 100 of 159 matches
Mail list logo
