On Wed, 8 Nov 2023 02:33:29 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread factory requires the injection of arguments in the
>> middle of the list. I don't think it makes sense to modify arguments in
>> several places so I replaced it with the flag isLimited and moved all
>> modifications in createJavaProcessBuilder().
>>
>> Testing tier1-5.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> converted list to array.
test/lib/jdk/test/lib/process/ProcessTools.java line 387:
> 385: */
> 386:
> 387: private static String[] addTestThreadFactoryArgs(String
> testThreadFactoryName, String[] command) {
would it be appropriate, at this juncture, to rename the method parameter
"command" here, and throughout the associated code, to commandArgs, as the
actual command i.e. java is added in createJavaProcessBuilder, and the
parameter references the java command's args? or is that too much hassle.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16442#discussion_r1387076880
