On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs <rri...@openjdk.org> wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the > standard test command line arguments should be marked as `vm.flagless` to > indicate to the testing infrastructure that they do not accept them and > should not be run with extra test command line options `test.vm.opts` and > `test.java.opts`. > > Add @requires vm.flagless to tests The changes look OK to me. It wasn't clear to me what "flagless" meant. I checked the implementation of how this `@requires` is implemented https://github.com/openjdk/jdk/blob/master/test/jtreg-ext/requires/VMProps.java#L657. So essentially, the definition of "flagless" comes down to "was the JVM in which jtreg is running and about to launch a test, launched using certain set of JVM arguments? If it wasn't launched with those set of JVM arguments, then it is flagless." The set of such JVM arguments appears to be wide and may change over time. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16572#pullrequestreview-1721810091
