On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 <d...@openjdk.org> wrote:

> 1. Adding required compiler flags.
> 2. Adding required symbols.
> 
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)

First and foremost, the `make/data/hotspot-symbols` directory is, as the name 
says, for hotspot symbols. These are not hotspot symbols. If you really do need 
the file, then it needs to reside in a proper location.

Secondly: do you really need this file? It looks just like an enumeration of (a 
subset of?) standard library functions. This looks like a completely incorrect 
solution to the problem. How did you arrive at this list? What if in the future 
new functions are added to the standard library?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16414#issuecomment-1802687626

Reply via email to