On Thu, 12 Oct 2023 14:16:55 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Thu, 12 Oct 2023 08:00:30 GMT, Matthias Baesken wrote:
> There are a few remaining places in java.base where the return value
> NULL-check of malloc is missing. This should better be adjusted.
This pull request has now been integrated.
Changeset: ff0b397e
Author:Matthias Baesken
URL:
On Fri, 13 Oct 2023 03:23:04 GMT, xpbob wrote:
> Big data processes often experience situations where the direct memory oom
> process is alive but not serving properly. If the direct memory is oom, code
> can notify the jvm. Can bring the following benefits:
> 1. Analysis of direct memory Java.
On Fri, 13 Oct 2023 03:23:04 GMT, xpbob wrote:
> Big data processes often experience situations where the direct memory oom
> process is alive but not serving properly. If the direct memory is oom, code
> can notify the jvm. Can bring the following benefits:
> 1. Analysis of direct memory Java.
On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
>
> Aggelos B
Big data processes often experience situations where the direct memory oom
process is alive but not serving properly. If the direct memory is oom, code
can notify the jvm. Can bring the following benefits:
1. Analysis of direct memory Java. Nio. DirectByteBuffer need heapdumps
reference relation
On Sun, 24 Sep 2023 13:16:02 GMT, Chen Liang wrote:
>> VarHandle implementations have many static fields and methods that can be
>> pulled to the common superclass to avoid repeated initialization and code
>> duplication.
>>
>> In addition, the Unsafe-based Buffer field access are replaced by
On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
>
> Aggelos B
On Thu, 12 Oct 2023 20:58:21 GMT, Justin Lu wrote:
>> Please review this PR which refactors a number of tests under
>> `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve
>> readability)
>> - separate the test data generation
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't hesitate
Port of miscellaneous leftover implementation-only changes from the
panama-foreign repo:
These four related to improving the performance of the internal `strlen`
implementation:
- https://github.com/openjdk/panama-foreign/pull/862
- https://github.com/openjdk/panama-foreign/pull/860
- htt
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from the actual execution of the test
> - create distinct
On Tue, 10 Oct 2023 17:58:12 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/901
>
> Original PR body:
>
>> This PR adds more javadoc to explain how base offsets in var handles
>> obtained from layouts can be used.
>>
>> First, a number of examples in the mai
> Port of: https://github.com/openjdk/panama-foreign/pull/898
>
> Original PR body:
>
>>
>> This patch addresses some issues with `MemorySegment.Scope::equals`. More
>> specifically, when two segments are created from the same array/buffer,
>> their underlying scope should be equal, but curren
On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
>
> Aggelos B
Port of: https://github.com/openjdk/panama-foreign/pull/901
Original PR body:
> This PR adds more javadoc to explain how base offsets in var handles obtained
> from layouts can be used.
>
> First, a number of examples in the main `MemoryLayout` javadoc is rectified,
> as such examples did not
Port of: https://github.com/openjdk/panama-foreign/pull/898
Original PR body:
>
> This patch addresses some issues with `MemorySegment.Scope::equals`. More
> specifically, when two segments are created from the same array/buffer, their
> underlying scope should be equal, but currently it is no
On Tue, 10 Oct 2023 17:17:00 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/898
>
> Original PR body:
>
>>
>> This patch addresses some issues with `MemorySegment.Scope::equals`. More
>> specifically, when two segments are created from the same array/buffer,
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing for some tests:
>
> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList
> runtime/CompressedOops/CompressedClassPointers.java on two platforms
> [JDK-8318040](https://bugs.openjdk.org/brows
On Thu, 12 Oct 2023 19:54:17 GMT, Roger Riggs wrote:
>> Trivial ProblemListing for some tests:
>>
>> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList
>> runtime/CompressedOops/CompressedClassPointers.java on two platforms
>> [JDK-8318040](https://bugs.openjdk.org/browse/JD
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing for some tests:
>
> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList
> runtime/CompressedOops/CompressedClassPointers.java on two platforms
> [JDK-8318040](https://bugs.openjdk.org/brows
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing for some tests:
>
> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList
> runtime/CompressedOops/CompressedClassPointers.java on two platforms
> [JDK-8318040](https://bugs.openjdk.org/brows
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
On Wed, 11 Oct 2023 21:46:04 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i also
Trivial ProblemListing for some tests:
[JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList
runtime/CompressedOops/CompressedClassPointers.java on two platforms
[JDK-8318040](https://bugs.openjdk.org/browse/JDK-8318040) ProblemList
vmTestbase/nsk/monitoring/ThreadMXBean/findMon
On Wed, 11 Oct 2023 22:19:29 GMT, Shaojin Wen wrote:
> Keep the duplicate code of StringConcatHelper, or use JLA, or move the code
> of getCharsLatin1 & stringSize to DecimalDigits (PR #15699). Of the three
> options, using JLA is the smallest change.
Adding methods to JLA also adds a maintena
On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
>
> Aggelos B
On Thu, 12 Oct 2023 16:53:12 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3153:
>>
>>> 3151: public ForkJoinTask submit(Callable task) {
>>> 3152: ForkJoinTask t =
>>> 3153: (Thread.currentThread() instanceof ForkJoinWor
On Wed, 11 Oct 2023 19:27:46 GMT, Joe Wang wrote:
> Thanks for the update.
>
> I'm not sure it's necessary to repeat tests with Base64 input. I think
> Daniel's comment was that the data can be optionally base64-encoded into a
> string, not that the tests needed to be duplicated.
>
> The gene
On Thu, 12 Oct 2023 13:48:23 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More cleanup
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3324:
>
>> 3322:
On Thu, 12 Oct 2023 13:46:01 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More cleanup
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3153:
>
>> 3151: public Fork
On Thu, 12 Oct 2023 03:44:28 GMT, Danny Thomas wrote:
> At least on Saphire Rapids the [emulation suggested
> here](https://github.com/natmaurice/x86-simd-sort/commit/41d03b2d8f3b62a2ee6a3a97a8da7f193a407026)
> only imposes a 6% penalty for `intSort`, while also mitigating the
> performance is
On Thu, 12 Oct 2023 14:16:55 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Thu, 12 Oct 2023 14:16:55 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
On Thu, 12 Oct 2023 11:11:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> src/java.base/share/classes/java/lang/classfile/packag
On Fri, 15 Sep 2023 18:04:29 GMT, Shaojin Wen wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHe
On Wed, 11 Oct 2023 13:07:08 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addr
On Wed, 11 Oct 2023 13:25:14 GMT, Roger Riggs wrote:
> The static for the current architecture should be final to allow some
> optimizations.
This pull request has now been integrated.
Changeset: c1f698d3
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/c1f698d38bb2519415
On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
On Wed, 11 Oct 2023 22:40:20 GMT, Sandhya Viswanathan
wrote:
>> I see now that this is an unrelated change. In that case please avoid
>> changing whitespace in unrelated files for this PR.
>
> @erikj79 This space was inadvertently added as part of
> (https://github.com/openjdk/jdk/pull/14227)
On Thu, 12 Oct 2023 10:29:31 GMT, Mahendra Chhipa wrote:
>> Agnibho Hom Chowdhury has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> upadted copyright year
>
> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 1:
>
>> 1: /*
>
> Please review this PR as a fix of
> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
> bug with after @ignore annotation.
Agnibho Hom Chowdhury has updated the pull request incrementally with one
additional commit since the last revision:
upadted copyright year
On Thu, 12 Oct 2023 12:17:27 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Thu, 12 Oct 2023 12:00:19 GMT, Alan Bateman wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> doabort in check method in case no memory can be allocated
>
> src/java.base/windows/native/libjli/cmdtoargs.c line
> There are a few remaining places in java.base where the return value
> NULL-check of malloc is missing. This should better be adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
doabort in check method in case no memory c
On Wed, 11 Oct 2023 13:07:08 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addr
On Fri, 6 Oct 2023 17:06:08 GMT, Shaojin Wen wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#for
On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Thu, 12 Oct 2023 10:40:03 GMT, Adam Sotona wrote:
>> make/test/BuildMicrobenchmark.gmk line 99:
>>
>>> 97: JAVAC_FLAGS := --add-exports
>>> java.base/sun.security.util=ALL-UNNAMED \
>>> 98: --add-exports java.base/sun.invoke.util=ALL-UNNAMED \
>>> 99: --add-exports java.b
On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> make/test/BuildMicrobenchmark.gmk line 99:
>
>> 97:
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote:
> Please review this PR as a fix of
> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
> bug with after @ignore annotation.
test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 1:
> 1: /*
Cou
On Thu, 12 Oct 2023 09:33:24 GMT, Joachim Kern wrote:
>> src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line 89:
>>
>>> 87:
>>> 88: do { // Block to break out of on Exception
>>> 89: pids = (*env)->GetLongArrayElements(env, jarray, NULL);
>>
>> Nit, I'd move these invocat
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Thu, 12 Oct 2023 09:55:15 GMT, Shaojin Wen wrote:
>> CharacterDataLatin1.digit is for multi-radix, and the performance when radix
>> = 10 is not good enough.
>
> If we reuse CharacterDataLatin1#DIGITS, the performance will be slower, the
> performance numbers are as follows
>
>
> class Cha
On Thu, 12 Oct 2023 09:19:35 GMT, Shaojin Wen wrote:
>> Let's not forget that `Character.digit()` has a pretty decent fast path for
>> Latin1, including a 256 bytes lookup-table.
>
> CharacterDataLatin1.digit is for multi-radix, and the performance when radix
> = 10 is not good enough.
If we r
On Thu, 12 Oct 2023 06:30:33 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes 2
>
> src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line 89:
>
>> 87:
>> 88: do { //
On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote:
> Please review this PR as a fix of
> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
> bug with after @ignore annotation.
Looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/1
> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
> in TreeTest.test5.
> The reason is: Previously the implementation based on the /proc file system
> lead to double pids in the child list; at least intermittent. Using the API
> getprocs64() instead I was able to eli
On Thu, 12 Oct 2023 09:10:30 GMT, Raffaello Giulietti
wrote:
>> This patch should have little impact on exception-path performance. Remember
>> String concatenation is done with StringBuilder in java.base, so changing
>> formatter to that might have some performance difference. However, the ma
On Thu, 12 Oct 2023 08:58:18 GMT, Chen Liang wrote:
>> While only optimizing the fast path is a good idea, I think it is important
>> to make sure there is no regression on the slow path - as @schlosna pointed
>> out, it's a common way to check if a string can be converted to an int.
>
> This p
On Wed, 11 Oct 2023 13:07:08 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addr
On Thu, 12 Oct 2023 08:47:09 GMT, Hannes Greule wrote:
>> More explicitly I was thinking something like below.
>>
>> I do wonder if some of the benchmark tests should cover the exceptional
>> cases. I have seen many systems where attempting to try and parse
>> potentially invalid inputs can h
On Thu, 12 Oct 2023 00:39:27 GMT, David Schlosnagle wrote:
>> He means to pull the `radix< Character,MIN_RADIX` and `radix >
>> Character.MAX_RADIX` shared code in Integer and Long.parseInt (with radix
>> version) to a helper method.
>
> More explicitly I was thinking something like below.
>
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
@JoeWang-Java can I have a review, please?
-
PR Comment: https://git.openjdk.org/jdk/pull/1569
There are a few remaining places in java.base where the return value NULL-check
of malloc is missing. This should better be adjusted.
-
Commit messages:
- JDK-8317959
Changes: https://git.openjdk.org/jdk/pull/16160/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16160&range
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Declare two fields `final`
> * Use distinct classes rather than anonymous classes
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove comment
--
On Thu, 7 Sep 2023 11:48:51 GMT, Per Minborg wrote:
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Declare two fields `final`
> * Use distinct classes rather than anonymous classes
This pull request has now been integrated.
Changeset: d95b548c
Author:Per Minb
Please review this PR as a fix of
[JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
bug with after @ignore annotation.
-
Commit messages:
- added bug-id with @ignore
Changes: https://git.openjdk.org/jdk/pull/16073/files
Webrev: https://webrevs.openjdk.o
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to `IllegalFormatException`
This pull request has now been integrated.
Changeset: eca6ea43
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/eca6ea43d085a68b9b9760e732275175cb1b0de3
73 matches
Mail list logo
