On Tue, 10 Oct 2023 17:58:12 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/901 > > Original PR body: > >> This PR adds more javadoc to explain how base offsets in var handles >> obtained from layouts can be used. >> >> First, a number of examples in the main `MemoryLayout` javadoc is rectified, >> as such examples did not use the additional base offset parameter (and were >> hence incorrect). >> >> Second, the var handles part in the `MemorySegment` section on "accessing >> memory segment" has been rewritten to avoid duplication with the concepts >> exposed in `MemoryLayout`. Now we show how `MemorySegment::get` and >> `MemorySegment::getAtIndex` can be obtained using basic var handles and >> combinators. We mention that more complex var handles can be obtained using >> layout paths, but we now just reference the layout path section. >> >> Last, I've added a new section on the `MemoryLayout` javadoc, with an >> example on how to deal with variable-length structs. This example showcases >> how var handles can be used in intricate situations, and combined with the >> new `scaleOffset` method. Re-read the javadoc changes. Still looks good :-) ------------- Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16127#pullrequestreview-1675172960
