On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX >> in TreeTest.test5. >> The reason is: Previously the implementation based on the /proc file system >> lead to double pids in the child list; at least intermittent. Using the API >> getprocs64() instead I was able to eliminate those double pids (and increase >> the performance by a factor of 4). Otherwise we would have to add an >> algorithm to filter out the doubles after creating the raw list. > > Joachim Kern has updated the pull request incrementally with one additional > commit since the last revision: > > revise of the function comment and some other proposals Looks good. Thanks for the additional comments. Keeping the code structure parallel to the original will make maintaining it easier. "Goto" is still considered harmful. IMHO BTW, someday this can/should be replaced with all java code using Panama. ;) ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16051#pullrequestreview-1674245057
