On Wed, 11 Oct 2023 13:07:08 GMT, Doug Lea <d...@openjdk.org> wrote: >> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java >> failed with "InterruptedException: sleep interrupted" and related issues. >> >> This is a major ForkJoin update (and hard to review -- sorry) that finally >> addresses incompatibilities between ExecutorService and ForkJoinPool (which >> claims to implement it), with the goal of avoiding continuing bug reports >> and incompatibilities. Doing this required reworking internal control to use >> phaser/seqlock-style versioning schemes (affecting nearly every method) that >> ensure consistent data structures and actions without requiring global >> synchronization or locking on every task execution that would massively >> degrade performance. The previous lack of a solution to this was the main >> reason for these incompatibilities. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > More cleanup
I gave the PR a final review just now, there was a few questions which might not warrant any changes. I concur with the assessment that these changes should be good to go. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14301#issuecomment-1759683705
