if (i < savingsInstantTransitions.length) {
// javazic writes the last GMT offset into index 0!
if (i < savingsInstantTransitions.length) {
offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000;
nOffsets = 1;
}
...
}
The second if statement looks unnecess
On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen wrote:
>> Please review this PR which contains the translations for updates to
>> localized resources in the JDK since RDP1.
>>
>> Included in this change are improved translations for certain values, which
>> also includes global updates for tran
On Mon, 24 Jul 2023 16:00:52 GMT, Sean Coffey wrote:
> Modify the -XshowSettings launcher option to print non-verbose settings
> details of all components by default. Verbose settings details will be
> printed via the -XshowSettings:all option. Modify the -XshowSettings option
> to reject bad
On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey wrote:
>> Modify the -XshowSettings launcher option to print non-verbose settings
>> details of all components by default. Verbose settings details will be
>> printed via the -XshowSettings:all option. Modify the -XshowSettings option
>> to reject
On Wed, 26 Jul 2023 21:59:41 GMT, Stuart Marks wrote:
> Regarding the text of the change: should getFirst() and getLast() be
> mentioned? They were added by Sequenced Collections, and they run in constant
> time. Also, while add() and addLast() run in amortized constant time (because
> of the
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
> addFirst(), removeFirst() and reversed() methods to lists.
> However, the Javadoc of List mentions:
> > The size, isEmpty, get, set, iterator, and listIterator operations run in
> constant time. The add operation run
On Thu, 27 Jul 2023 06:07:42 GMT, David Holmes wrote:
>> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception
>> will be printed and it will exit with 1; if there is no pending exception
>> then it exit with the value of `ret` as the exit status, which will be 0
>> here.
>
On Tue, 25 Jul 2023 21:28:23 GMT, Jorn Vernee wrote:
> @TheRealMDoerr @feilongjiang Just a heads up: this patch touches the PPC and
> RISC-V ports as well, which I'm not able to test. I've just eye-balled the
> needed changes. I don't think there will be an issue since the code structure
> is
On Thu, 27 Jul 2023 05:45:59 GMT, Alan Bateman wrote:
>> I am not incredibly familiar with the java launcher but I believe what I
>> have is a mistake. I will change it to `CHECK_EXCEPTION_LEAVE(1)` instead.
>
> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception will
> be
On Thu, 27 Jul 2023 01:30:01 GMT, Serguei Spitsyn wrote:
> Nit: normal indent for native code is 2.
The .c files I sampled in test/hotspot/jtreg/serviceability/jvmti/** used 4,
either is okay as this is just two tiny JNI functions.
-
PR Review Comment: https://git.openjdk.org/jdk/
On Wed, 26 Jul 2023 21:52:04 GMT, Matias Saavedra Silva
wrote:
>> src/java.base/share/native/libjli/java.c line 464:
>>
>>> 462: if (dumpSharedSpaces) {
>>> 463: CHECK_EXCEPTION_LEAVE(0);
>>> 464: LEAVE();
>>
>> What is exit status ($?) when -Xshare:dump fails. It looks like an
On Tue, 25 Jul 2023 21:26:06 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162:
>
>> 160:
>> 161: assert(
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThr
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThr
On Wed, 26 Jul 2023 17:38:24 GMT, Alan Bateman wrote:
>> I can't see why it would be needed.
>
>> It would be nice to add a short comment why this is needed.
>
> It's not needed here, it was needed in another version of the tests. While
> benign, I can remove it to avoid any confusion. Thanks.
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote:
> Please review this PR which contains the translations for updates to
> localized resources in the JDK since RDP1.
>
> Included in this change are improved translations for certain values, which
> also includes global updates for translations
On Wed, 26 Jul 2023 14:44:01 GMT, Per Minborg wrote:
>> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
>> methods as well as clarifying the docs a bit more. Also, a local variable is
>> renamed.
>
> Per Minborg has updated the pull request incrementally with one ad
On Wed, 26 Jul 2023 14:44:01 GMT, Per Minborg wrote:
>> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
>> methods as well as clarifying the docs a bit more. Also, a local variable is
>> renamed.
>
> Per Minborg has updated the pull request incrementally with one ad
On Wed, 26 Jul 2023 19:28:04 GMT, Jorn Vernee wrote:
>> This PR suggests updating some of the ill-formed copyright headers in the
>> FFM API and the implementation and test thereof.
>>
>> Some of the test files will have now the "classpath" exception. Is this
>> correct?
>
>> Some of the test
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote:
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
> addFirst(), removeFirst() and reversed() methods to lists.
> However, the Javadoc of List mentions:
> > The size, isEmpty, get, set, iterator, and listIterator operati
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote:
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
> addFirst(), removeFirst() and reversed() methods to lists.
> However, the Javadoc of List mentions:
> > The size, isEmpty, get, set, iterator, and listIterator operati
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote:
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
> addFirst(), removeFirst() and reversed() methods to lists.
> However, the Javadoc of List mentions:
> > The size, isEmpty, get, set, iterator, and listIterator operati
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote:
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
> addFirst(), removeFirst() and reversed() methods to lists.
> However, the Javadoc of List mentions:
> > The size, isEmpty, get, set, iterator, and listIterator operati
On Wed, 26 Jul 2023 18:52:41 GMT, Alan Bateman wrote:
>> Matias Saavedra Silva has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge fix
>> - Restores java loaders
>> - Ioi and David comments
>> - Windows
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote:
> 8311104: dangling-gsl warning in libwixhelper.cpp
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15044#pullrequestreview-1548666131
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
> select platforms.
JSR166TestCase.java runs >4000 tests so excluding this discussion is not good.
Maybe JDK-8312980 needs to be bumped to a P1/P2 or a w
On Wed, 26 Jul 2023 20:05:11 GMT, Alexander Matveev
wrote:
>> 8311104: dangling-gsl warning in libwixhelper.cpp
>
> src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp line 75:
>
>> 73: void findInstalledProducts(const Guid& upgradeCode,
>> 74:
Please review this PR which contains the IPS translations for updates to
localized resources in the JDK since RDP1.
Included in this change are improved translations for certain values, which
also includes global updates for translations of the words 'annotation' and
'file' for zh_CN.
The foll
On Tue, 18 Jul 2023 01:49:17 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.Integers.toStri
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote:
> 8311104: dangling-gsl warning in libwixhelper.cpp
src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp line 75:
> 73: void findInstalledProducts(const Guid& upgradeCode,
> 74: std::ve
On Wed, 26 Jul 2023 07:39:09 GMT, Justin Lu wrote:
> Please review this change which makes
> `MessageFormat.formatToCharacterIterator` fail fast(er). The return statement
> is also modified to call toArray() as `toArray(new T[0])` over `toArray(new
> T[size])`.
Marked as reviewed by naoto (R
On Wed, 26 Jul 2023 07:11:16 GMT, Justin Lu wrote:
> Please review this change which renames tests for Locale from
> `bugNNN.java` to something more descriptive.
>
> In addition to the name changes, accompanying copyright year, name usage
> within the test, and other minor changes were inc
On Wed, 26 Jul 2023 19:24:33 GMT, Joe Darcy wrote:
>> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
>> select platforms.
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the lightning fast review!
-
PR Comment: https://git.openjdk.or
A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
select platforms.
-
Commit messages:
- 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select
platforms
Changes: https://git.openjdk.org/jdk21/pull/145/files
Webrev: https://webrevs.
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/util/concurrent/SynchronousQueue/Fairness.java on X64.
They are (so far), but the fix that Doug Lea integrated did not seem to be
specific to ZGC or -Xcomp so I went wider... I'm hoping that Doug
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
> select platforms.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/145#pullrequestreview-1548445218
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
> select platforms.
This pull request has now been integrated.
Changeset: a10dbcec
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jd
On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote:
> Some of the test files will have now the "classpath" exception. Is this
> correct?
No. The test files should not have the classpath exception.
-
PR Comment: https://git.openjdk.org/jdk/pull/15042#issuecomment-1652367609
On Wed, 26 Jul 2023 07:11:16 GMT, Justin Lu wrote:
> Please review this change which renames tests for Locale from
> `bugNNN.java` to something more descriptive.
>
> In addition to the name changes, accompanying copyright year, name usage
> within the test, and other minor changes were inc
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/util/concurrent/SynchronousQueue/Fairness.java on X64.
Are all the sightings -XX:+UseZGC -Xcomp? Only asking in case you meant to add
it to ProblemList-zgc.txt.
-
PR Comment: https
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote:
> 8311104: dangling-gsl warning in libwixhelper.cpp
@sashamatveev please review
-
PR Comment: https://git.openjdk.org/jdk/pull/15044#issuecomment-1652324135
8311104: dangling-gsl warning in libwixhelper.cpp
-
Commit messages:
- 8311104: dangling-gsl warning in libwixhelper.cpp
Changes: https://git.openjdk.org/jdk/pull/15044/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15044&range=00
Issue: https://bugs.openjdk.org/browse/JD
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/util/concurrent/SynchronousQueue/Fairness.java on X64.
This pull request has now been integrated.
Changeset: f666e606
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk21/co
On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter wrote:
>> Limit native memory allocation and move write loop from the native layer
>> into Java. This change should make the OOME reported in the issue much less
>> likely.
>
> Brian Burkhalter has updated the pull request incrementally with th
On Wed, 26 Jul 2023 12:20:49 GMT, David Holmes wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadState/GetThreadStateTest.java
>> line 133:
>>
>>> 131: } finally {
>>> 132: thread.join();
>>> 133: Reference.reachabilityFence(lock);
>>
>> It woul
On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter wrote:
>> Limit native memory allocation and move write loop from the native layer
>> into Java. This change should make the OOME reported in the issue much less
>> likely.
>
> Brian Burkhalter has updated the pull request incrementally with th
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Wed, 26 Jul 2023 16:44:56 GMT, Roger Riggs wrote:
>> A trivial fix to ProblemList
>> java/util/concurrent/SynchronousQueue/Fairness.java on X64.
>
> Marked as reviewed by rriggs (Reviewer).
@RogerRiggs - Thanks for the review!
-
PR Comment: https://git.openjdk.org/jdk21/pull/14
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/util/concurrent/SynchronousQueue/Fairness.java on X64.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/144#pullrequestreview-1548184357
On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey wrote:
>> Modify the -XshowSettings launcher option to print non-verbose settings
>> details of all components by default. Verbose settings details will be
>> printed via the -XshowSettings:all option. Modify the -XshowSettings option
>> to reject
On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey wrote:
>> Modify the -XshowSettings launcher option to print non-verbose settings
>> details of all components by default. Verbose settings details will be
>> printed via the -XshowSettings:all option. Modify the -XshowSettings option
>> to reject
On Wed, 26 Jul 2023 15:58:15 GMT, Vyom Tewari wrote:
>>> please reformat line 173
>>
>> Why?
>
> "buf = (char*)malloc(len*sizeof(char));" --> "buf = (char*)malloc(len *
> sizeof(char));"
> "buf = (char*)malloc(len_sizeof(char));" --> "buf = (char_)malloc(len *
> sizeof(char));"
Both sides of
On Wed, 26 Jul 2023 15:49:38 GMT, Brian Burkhalter wrote:
>> src/java.base/share/native/libjava/io_util.c line 173:
>>
>>> 171: if (len > MAX_MALLOC_SIZE)
>>> 172: len = MAX_MALLOC_SIZE;
>>> 173: buf = (char*)malloc(len*sizeof(char));
>>
>> please reformat line 173
>
A trivial fix to ProblemList
java/util/concurrent/SynchronousQueue/Fairness.java on X64.
-
Commit messages:
- 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on
X64
Changes: https://git.openjdk.org/jdk21/pull/144/files
Webrev: https://webrevs.openjdk.org/
On Wed, 26 Jul 2023 05:31:57 GMT, Vyom Tewari wrote:
> please reformat line 173
Why?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14981#discussion_r1275174632
This PR suggests updating some of the ill-formed copyright headers in the FFM
API and the implementation and test thereof.
Some of the test files will have now the "classpath" exception. Is this correct?
-
Commit messages:
- Update copyright formatting
Changes: https://git.openjdk
On Wed, 26 Jul 2023 09:29:18 GMT, Alan Bateman wrote:
> I think the main issue with this version is that it changes behavior of the
> read methods to work like "read fully", I don't think we should do that.
To me it looks more like `readNBytes`.
-
PR Comment: https://git.openjdk.o
On Wed, 26 Jul 2023 05:26:52 GMT, Vyom Tewari wrote:
>> Brian Burkhalter has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - 6478546: Decrease malloc limit to 1.5 MB
>> - 6478546: Minor refactoring
>> - 6478546: Prevent short read
>
>
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
> methods as well as clarifying the docs a bit more. Also, a local variable is
> renamed.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update after com
On Tue, 25 Jul 2023 19:17:38 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/848 from the
> panama-foreign repo.
>
> Copying the PR body here for convenience:
>
> Due to a bug in the downcall linker stub generation, we don't save the return
> value when captu
On Wed, 26 Jul 2023 07:25:20 GMT, Christian Stein wrote:
> Problem list some JUnit-based tests in
> `test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
> `jtreg` 7.3 with a fix for the underlying race condition is released. That
> fix is tracked via https://bugs.openjdk
On Wed, 26 Jul 2023 07:25:20 GMT, Christian Stein wrote:
> Problem list some JUnit-based tests in
> `test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
> `jtreg` 7.3 with a fix for the underlying race condition is released. That
> fix is tracked via https://bugs.openjdk
On Wed, 26 Jul 2023 09:42:10 GMT, Serguei Spitsyn wrote:
>> Thread::getState is an API for monitoring and management purposes to report
>> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
>> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>>
On Tue, 25 Jul 2023 05:50:12 GMT, Alan Bateman wrote:
>> src/hotspot/share/classfile/javaClasses.hpp line 536:
>>
>>> 534:
>>> 535: // additional state bits
>>> 536: TIMED= 1 << 8, // timed parked
>>
>> Why handle TIMED this way instead of just making TIMED_PARKED/PARKING sta
Problem list some JUnit-based tests in
`test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
`jtreg` 7.3 with a fix for the underlying race condition is released. That fix
is tracked via https://bugs.openjdk.org/browse/CODETOOLS-7903507
-
Commit messages:
- U
On Wed, 26 Jul 2023 07:25:20 GMT, Christian Stein wrote:
> Problem list some JUnit-based tests in
> `test/jdk/java/lang/invoke/MethodHandleProxies/` for the time being - until
> `jtreg` 7.3 with a fix for the underlying race condition is released. That
> fix is tracked via https://bugs.openjdk
The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add
addFirst(), removeFirst() and reversed() methods to lists.
However, the Javadoc of List mentions:
> The size, isEmpty, get, set, iterator, and listIterator operations run in
> constant time. The add operation runs in am
On Tue, 25 Jul 2023 07:09:55 GMT, airsquared wrote:
> I see. I'll create a PR there. Thanks.
Thanks, I assume this PR can be closed.
-
PR Comment: https://git.openjdk.org/jdk21/pull/140#issuecomment-1651454738
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThr
On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter wrote:
>> Limit native memory allocation and move write loop from the native layer
>> into Java. This change should make the OOME reported in the issue much less
>> likely.
>
> Brian Burkhalter has updated the pull request incrementally with th
On Wed, 26 Jul 2023 00:00:33 GMT, Brian Burkhalter wrote:
> There was no dropping of the file system cache. I would think this would have
> more of an effect on measuring the throughput of writing than reading.
In that case, I assume the benchmarks are just reading from the file system
cache s
> Modify the -XshowSettings launcher option to print non-verbose settings
> details of all components by default. Verbose settings details will be
> printed via the -XshowSettings:all option. Modify the -XshowSettings option
> to reject bad values passed to it. Print an error message in such sce
On Tue, 25 Jul 2023 21:01:03 GMT, Mandy Chung wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Incorporate review feedback
>> - modify -X output for :all
>
> src/java.base/share/classes/sun/launcher/LauncherHelper
Please review this change which makes `MessageFormat.formatToCharacterIterator`
fail fast(er). The return statement is also modified to call toArray() as
`toArray(new T[0])` over `toArray(new T[size])`.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull
Please review this change which renames tests for Locale from `bugNNN.java`
to something more descriptive.
In addition to the name changes, accompanying copyright year, name usage within
the test, and other minor changes were included. The test `bug4123285.java` was
also removed, as it was
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the JBS
77 matches
Mail list logo
