On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Please review this PR which contains the translations for updates to >> localized resources in the JDK since RDP1. >> >> Included in this change are improved translations for certain values, which >> also includes global updates for translations of the words 'annotation' and >> 'file' for zh_CN. >> >> The following files contain key/value resources that were added, updated, or >> removed in the original file. (This means that the localized versions of >> these files contain changes to translations that are a reflection of the >> original key/value changing, and are not just improved translations). >> >> - src/java.base/share/classes/sun/launcher/resources/launcher.properties >> - >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >> - >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties >> - src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps.properties >> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties >> - src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties >> >> It is recommended to view the changes in UTF-8 native at >> https://cr.openjdk.org/~jlu/RDP2_Diffs/. > > src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties > line 185: > >> 183: jshell.console.no.javadoc = <no documentation found> >> 184: jshell.console.do.nothing = Do nothing >> 185: jshell.console.choice = Choice:\u0020 > > I see this backslash is also being removed. It does seem misplaced since none > of the other lines use it. But just double checking with you that this is the > desired change because for the other locales, the change was to just > translate the space to unicode. Thanks for reviewing Damon, the `` is used to signify the white space after the `:` is intentional. However, using a trailing `\u0020` is more intentional and clear, and allows for consistency between the original and localized versions, so I manually made this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15047#discussion_r1275806234
