On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can i
> `VarForm::getMemberName` currently throws UOE with no information if the
> requested access mode is unsupported. To provide the var handle
> information, move the access mode check to `VarHandle` so that the exception
> message can include the var handle information. Changes include:
>
> 1
On Wed, 19 Jul 2023 00:52:49 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback
>
> src/java.base/share/classes/java/lang/invoke/IndirectVarHandle.java line 93:
>
>> 91: @ForceInlin
On Wed, 19 Jul 2023 00:12:53 GMT, Mandy Chung wrote:
> `VarForm::getMemberName` currently throws UOE with no information if the
> requested access mode is unsupported. To provide the var handle
> information, move the access mode check to `VarHandle` so that the exception
> message can inclu
`VarForm::getMemberName` currently throws UOE with no information if the
requested access mode is unsupported. To provide the var handle information,
move the access mode check to `VarHandle` so that the exception message can
include the var handle information. Changes include:
1. change `Va
On Tue, 18 Jul 2023 04:42:31 GMT, Joe Darcy wrote:
> Change one overload of java.lang.reflect.Array.newInstance to have an
> `@implSpec` of calling the other method.
>
> I choose not to use a snippet tag here is this code is semantically only one
> line and doesn't need to be cut-and-pasted.
>
On Tue, 18 Jul 2023 20:48:13 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
>> which updates the javadoc for the constructor of MessageFormat regarding a
>> `null` locale,
>>
>> `MessageFormat` when created with a `null` locale may throw a
On Mon, 17 Jul 2023 21:54:37 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Slight wording adjustment
>> - Review: Explicitly declare when NPE thrown instead of 'may'
>
> src/java.base/share/classe
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197)
> which updates the javadoc for the constructor of MessageFormat regarding a
> `null` locale,
>
> `MessageFormat` when created with a `null` locale may throw a
> `NullPointerException` either during the object creati
On Thu, 13 Jul 2023 07:27:22 GMT, yaqsun wrote:
>> The prerequisite is to install the rpmbuild command, when multiple users
>> switch to write /var/tmp/*.files will have the permission forbidden.
>
> yaqsun has updated the pull request incrementally with one additional commit
> since the last r
On Tue, 18 Jul 2023 04:42:31 GMT, Joe Darcy wrote:
> Change one overload of java.lang.reflect.Array.newInstance to have an
> `@implSpec` of calling the other method.
>
> I choose not to use a snippet tag here is this code is semantically only one
> line and doesn't need to be cut-and-pasted.
>
On Tue, 18 Jul 2023 04:42:31 GMT, Joe Darcy wrote:
> Change one overload of java.lang.reflect.Array.newInstance to have an
> `@implSpec` of calling the other method.
>
> I choose not to use a snippet tag here is this code is semantically only one
> line and doesn't need to be cut-and-pasted.
>
On Tue, 18 Jul 2023 17:08:34 GMT, Naoto Sato wrote:
>> This is to bring the JLine-based Console implementation as the default,
>> which was the initial intention in
>> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
>> CSR has also been drafted.
>
> Naoto Sato has u
On Tue, 18 Jul 2023 01:57:56 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Tue, 18 Jul 2023 05:05:24 GMT, Chen Liang wrote:
>> Change one overload of java.lang.reflect.Array.newInstance to have an
>> `@implSpec` of calling the other method.
>>
>> I choose not to use a snippet tag here is this code is semantically only one
>> line and doesn't need to be cut-and-pas
> This is to bring the JLine-based Console implementation as the default, which
> was the initial intention in
> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
> CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with two additional
co
On Tue, 18 Jul 2023 15:21:50 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> `true`
>
> src/java.base/share/classes/java/io/Console.java line 354:
>
>> 352: * character devices are available t
On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the JBS
On Tue, 18 Jul 2023 16:25:17 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b4dce0d6](https://github.com/openjdk/jdk/commit/b4dce0d62479c2494c02570a60319cb1a5932940)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Tue, 18 Jul 2023 15:11:04 GMT, Chen Liang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> commits since
On Tue, 18 Jul 2023 16:25:17 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b4dce0d6](https://github.com/openjdk/jdk/commit/b4dce0d62479c2494c02570a60319cb1a5932940)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
Hi all,
This pull request contains a backport of commit
[b4dce0d6](https://github.com/openjdk/jdk/commit/b4dce0d62479c2494c02570a60319cb1a5932940)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mandy Chung on 18 Jul 2023 and was
revi
On Tue, 18 Jul 2023 15:01:11 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 132:
>>
>>> 130: */
>>> 131: public static ReferencedKeyMap
>>> 132: create(boolean isSoft, boolean useNativeQueue,
>>> Supplier, V>> supplier) {
>>
>>
On Mon, 26 Jun 2023 21:34:40 GMT, Mandy Chung wrote:
> This PR updates the spec of `Lookup::findClass` to reflect the current
> behavior that requires a binary name or a string representing an array class
> in the form as returned by `Class::getName`.
>
> `test/jdk/java/lang/invoke/accessC
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
Marked as reviewed by asemenyuk (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14840#pullreques
On Mon, 17 Jul 2023 20:46:32 GMT, Naoto Sato wrote:
>> This is to bring the JLine-based Console implementation as the default,
>> which was the initial intention in
>> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding
>> CSR has also been drafted.
>
> Naoto Sato has u
On Thu, 13 Jul 2023 07:27:22 GMT, yaqsun wrote:
>> The prerequisite is to install the rpmbuild command, when multiple users
>> switch to write /var/tmp/*.files will have the permission forbidden.
>
> yaqsun has updated the pull request incrementally with one additional commit
> since the last r
On Thu, 29 Jun 2023 19:28:05 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer ne
On Mon, 3 Jul 2023 11:12:32 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as tr
On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in the java.text area.
>>
>> * Some changes to `equals` and `hashCode` are refactoring rather than
>> modernization. Such changes can be
On Thu, 6 Jul 2023 19:58:09 GMT, Mandy Chung wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add flag for reference queue type
>
> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 132:
>
>> 1
On Thu, 13 Jul 2023 15:07:35 GMT, Jim Laskey wrote:
>> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent
>> caching scheme for Carrier objects. The technique used is generally useful
>> for a variety of caching schemes and is being moved to be shared in other
>> parts o
On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in the java.text area.
>>
>> * Some changes to `equals` and `hashCode` are refactoring rather than
>> modernization. Such changes can be
Reduces excessive allocation of Matcher.groups array when the original Pattern
has no groups or less than 9 groups.
Original clamping to 10 possibly due to documented behavior from javadoc:
"In this class, \1 through \9 are always interpreted as back references, "
Only with Matcher changes RegE
On Tue, 18 Jul 2023 11:01:33 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> include -debug (alias) option in the deprecated log message
>
> src/java.base/share/classes/sun/launcher/resources/laun
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option and `-debug` option of the `java` command? This
> addresses https://bugs.openjdk.org/browse/JDK-8227229.
>
> As noted in the JBS issue this option is currently a no-op and has been there
>
On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the JBS
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range [`origin`, `bound`). It does so by applying the affine transform
> `o
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range [`origin`, `bound`). It does so by applying the affine transform
> `o
On Tue, 18 Jul 2023 02:54:55 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Correction in comment.
>
> src/java.base/share/classes/java/util/random/RandomGenerator.java line 398:
>
>> 396:
On Tue, 18 Jul 2023 07:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the JBS
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option and `-debug` option of the `java` command? This
> addresses https://bugs.openjdk.org/browse/JDK-8227229.
>
> As noted in the JBS issue this option is currently a no-op and has been there
>
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option of the `java` command? This addresses
> https://bugs.openjdk.org/browse/JDK-8312151?
>
> As noted in the JBS issue this option is currently a no-op and has been there
> only for backward c
On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option of the `java` command? This addresses
> https://bugs.openjdk.org/browse/JDK-8312151?
>
> As noted in the JBS issue this option is cur
Can I please get a review of this change which proposes to deprecate for
removal the `-Xdebug` option of the `java` command? This addresses
https://bugs.openjdk.org/browse/JDK-8312151?
As noted in the JBS issue this option is currently a no-op and has been there
only for backward compatible si
On Tue, 18 Jul 2023 06:59:52 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to deprecate for
> removal the `-Xdebug` option of the `java` command? This addresses
> https://bugs.openjdk.org/browse/JDK-8312151?
>
> As noted in the JBS issue this option is cur
47 matches
Mail list logo
