On Tue, 18 Jul 2023 11:01:33 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   include -debug (alias) option in the deprecated log message
>
> src/java.base/share/classes/sun/launcher/resources/launcher.properties line 
> 137:
> 
>> 135: \    -Xcheck:jni       perform additional checks for JNI functions\n\
>> 136: \    -Xcomp            forces compilation of methods on first 
>> invocation\n\
>> 137: \    -Xdebug           deprecated and may be removed in a future 
>> release.\n\
> 
> This drops "does nothing" so no longer clear that the option doesn't do 
> anything. It could be changed to "does nothing; deprecated for removal in a 
> future release". Alternatively maybe it would be better to just remove it 
> from the -X output.

Hello Alan, I updated the PR to use your suggested wording. I thought it's of 
no harm to let it be present in the -X output until we actually remove it 
(soon).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14918#discussion_r1266705837

Reply via email to