On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

>> Please review this PR to use modern APIs and language features to simplify 
>> `equals` and `hashCode` in the java.text area.
>> 
>> * Some changes to `equals` and `hashCode` are refactoring rather than 
>> modernization. Such changes can be as trivial as rearranging, adding, or 
>> commenting checks.
>> 
>> * java.text area contains more classes whose `equals` and `hashCode` could 
>> be simplified; for example: sun.text.CompactByteArray or 
>> java.text.DigitList. However, I found no evidence of `equals` and `hashCode` 
>> in those classes being used in source or tests. Since writing new tests in 
>> this case seems unreasonable, I **excluded** those classes from this PR.
>
> Pavel Rappo has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Feedback

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14752#pullrequestreview-1535273279

Reply via email to