On Tue, 18 Jul 2023 15:01:11 GMT, Chen Liang <li...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 132:
>>
>>> 130: */
>>> 131: public static <K, V> ReferencedKeyMap<K, V>
>>> 132: create(boolean isSoft, boolean useNativeQueue,
>>> Supplier<Map<ReferenceKey<K>, V>> supplier) {
>>
>> I suggest to keep the previous `create(boolean isSoft, Supplier supplier)`
>> factory method that defaults to non-native reference queue, which is
>> commonly used. Only `MethodType` needs to use native reference queue.
>
> Mandy: The no-`NativeQueue` version is already implemented above.
Yes Jim made the change per this review feedback - see
[8eff918](https://github.com/openjdk/jdk/pull/14684/commits/8eff91836f98cb33164046f2304185f11df12609)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14684#discussion_r1267020337
