Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread Alan Bateman
On Wed, 5 Apr 2023 04:35:27 GMT, David Holmes wrote: >> src/java.base/share/classes/java/lang/Thread.java line 1846: >> >>> 1844: /** >>> 1845: * Returns true if this thread is alive. >>> 1846: * This method is non-final so it can be overridden. >> >> Suggestion: >> >> * Thi

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Eirik Bjorsnos
On Wed, 5 Apr 2023 06:12:24 GMT, Alan Bateman wrote: > I used the inline code formatting (3 backquotes) to make the output clear, > but maybe it looks differently for you or maybe your comment was while I was > editing? It looks good now, so my comment was probably made during your edits. >

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Alan Bateman
On Tue, 4 Apr 2023 18:41:31 GMT, Eirik Bjorsnos wrote: > Thanks a lot Alan, as this CSR has deeper waters than what I've experienced > before. Did you intend to remove the line break in the example warning > output, collapsing it into one line? I used the inline code formatting (3 backquotes)

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Jaikiran Pai
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8305107: Emoji related binary properties in RegEx [v3]

2023-04-04 Thread Jaikiran Pai
On Tue, 4 Apr 2023 20:15:52 GMT, Naoto Sato wrote: >> Introducing new regex constructs that match those 6 new Unicode Emoji >> properties implemented in the `Character` class >> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been >> drafted. > > Naoto Sato has updated t

Re: RFR: 8284871: Use covariant overrides for the resolveConstantDesc(Lookup) method in sub‑interfaces of java.lang.constant.ConstantDesc [v4]

2023-04-04 Thread Chen Liang
> Also remove redundant casts to avoid javac warnings. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: Redundant casts in benchmark - Changes: - all: https://git.openjdk.org/jdk/pull/12986/files - new: https://git.open

Re: RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread ExE Boss
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote: > With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets

RFR: 6241286: (cal) API: Calendar.DAY_OF_WEEK definition is wrong

2023-04-04 Thread Justin Lu
This PR updates the Calendar.DAY_OF_WEEK documentation to make it clear that the field accepts _any_ value if the calendar is lenient and then normalizes it. Only if the calendar is non-lenient, will the field accept only one of SUNDAY ... SATURDAY. - Commit messages: - Redudant w

Re: RFR: 6983726: remove Proxy from MethodHandleProxies.asInterfaceInstance SAM conversion [v4]

2023-04-04 Thread Chen Liang
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based > implementation of MethodHandleProxies.asInterface has a few issues: > 1. Exposes too much information via Proxy supertype (and WrapperInstance > interface) > 2. Does not allow future expansion to support SAM[^1] abstrac

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
On Wed, 5 Apr 2023 04:04:11 GMT, ExE Boss wrote: >> David Holmes has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Switch from using synchronized to using a volatile eetop field >> - Added Shipilev's test (with a small addition) > > src

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8284871: Use covariant overrides for the resolveConstantDesc(Lookup) method in sub‑interfaces of java.lang.constant.ConstantDesc [v3]

2023-04-04 Thread ExE Boss
On Tue, 4 Apr 2023 17:22:11 GMT, Chen Liang wrote: >> Also remove redundant casts to avoid javac warnings. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread ExE Boss
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread ExE Boss
On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

About MethodTypeDesc having more than 255 slots

2023-04-04 Thread -
Hi Vincente, In https://bugs.openjdk.org/browse/JDK-8223803 you argued that it can be used to represent descriptor with more than 255 slots and that it can be used to indify a varargs with more than 255 parameters. However, this has brought some trouble to the classfile-oriented usages of MethodTy

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Integrated: 8305113: (tz) Update Timezone Data to 2023c

2023-04-04 Thread Yoshiki Sato
On Fri, 31 Mar 2023 00:02:02 GMT, Yoshiki Sato wrote: > Pleases review this PR. > The PR includes the following changes. > - tzdata 2023c > - Hack code to deal with Cairo's DST end, which is same as done in > 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work > around

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v5]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-04 Thread Paul Sandoz
On Tue, 4 Apr 2023 13:46:12 GMT, Quan Anh Mai wrote: >> `Vector::slice` is a method at the top-level class of the Vector API that >> concatenates the 2 inputs into an intermediate composite and extracts a >> window equal to the size of the inputs into the result. It is used in vector >> conver

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v4]

2023-04-04 Thread David Holmes
On Tue, 4 Apr 2023 22:50:00 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v4]

2023-04-04 Thread David Holmes
> We have the strange situation where calling `t.isAlive()` on a > `java.lang.Thread` `t`, will call into the VM (via `alive()` then > `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract > its `JavaThread` pointer and compare it to null. We can simply read `eetop` > dir

Re: RFR: 8303530: Add system property for custom JAXP configuration file [v7]

2023-04-04 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v3]

2023-04-04 Thread David Holmes
On Tue, 4 Apr 2023 09:22:29 GMT, Aleksey Shipilev wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure HB relationship exists; additional explanatory comments > > src/java.base/share/classes/java/lang/Thread.java

Re: RFR: 8305107: Emoji related binary properties in RegEx [v3]

2023-04-04 Thread Roger Riggs
On Tue, 4 Apr 2023 20:15:52 GMT, Naoto Sato wrote: >> Introducing new regex constructs that match those 6 new Unicode Emoji >> properties implemented in the `Character` class >> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been >> drafted. > > Naoto Sato has updated t

Integrated: 8305400: ISO 4217 Amendment 175 Update

2023-04-04 Thread Justin Lu
On Fri, 31 Mar 2023 21:38:31 GMT, Justin Lu wrote: > Please review the ISO 4217 amendment 175 update. > > There are no meaningful code changes, but the version number should be > updated accordingly to be in sync. This pull request has now been integrated. Changeset: 7cf24d1c Author:Justi

Integrated: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR

2023-04-04 Thread Justin Lu
On Tue, 14 Mar 2023 22:16:45 GMT, Justin Lu wrote: > This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)` > rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and > `DAY_OF_WEEK` combo. > > For example, Rolling _Monday, 30 December 2019_ by 1 week produced _Mond

Re: RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread Iris Clark
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote: > With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets

Re: RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread Lance Andersen
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote: > With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets

Re: RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder

2023-04-04 Thread Andrey Turbanov
On Tue, 4 Apr 2023 13:57:26 GMT, Alan Bateman wrote: > If you are changing uses(String) then it should obey `strict`, meaning put > this at the beginning of the method > > ``` > if (strict) { > requireServiceTypeName(service); > } > ``` But now `requireServiceTypeName` is called unconditio

Re: RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder [v2]

2023-04-04 Thread Andrey Turbanov
> `Map.containsKey` call is sometimes unnecessary, when it's known that `Map` > doesn't contain `null` values. > Instead of pair containsKey+put we can use putIfAbsent and compare result > with null. > Result code is shorter and a bit faster. Andrey Turbanov has updated the pull request incremen

Re: RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread Naoto Sato
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote: > With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets

Re: RFR: 8305107: Emoji related binary properties in RegEx [v2]

2023-04-04 Thread Naoto Sato
On Tue, 4 Apr 2023 19:31:24 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> indentation > > test/jdk/java/util/regex/RegExTest.java line 967: > >> 965: for (int i=0; i<1000; i++) { >> 966:

Re: RFR: 8305107: Emoji related binary properties in RegEx [v3]

2023-04-04 Thread Naoto Sato
> Introducing new regex constructs that match those 6 new Unicode Emoji > properties implemented in the `Character` class > (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been > drafted. Naoto Sato has updated the pull request incrementally with one additional commit si

Re: RFR: 8305107: Emoji related binary properties in RegEx [v2]

2023-04-04 Thread Roger Riggs
On Tue, 4 Apr 2023 17:10:09 GMT, Naoto Sato wrote: >> Introducing new regex constructs that match those 6 new Unicode Emoji >> properties implemented in the `Character` class >> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been >> drafted. > > Naoto Sato has updated t

RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread Roger Riggs
With the addition of `jdk.internal.util.OperatingSystem` references to the system property `os.name` can be replaced. This PR exports jdk.internal.util to: - java.prefs, - java.security.jgss, - java.smartcardio, - jdk.charsets, - jdk.net, - jdk.zipfs - Commit messages: - In jd

Integrated: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

2023-04-04 Thread Mandy Chung
On Tue, 4 Apr 2023 18:58:12 GMT, Mandy Chung wrote: > This gives time to investigate JDK-8305600 and understand why the test didn't > fail on my testing before the push. This pull request has now been integrated. Changeset: 3399fbf9 Author:Mandy Chung URL: https://git.openjdk.org/j

Re: Integrated: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

2023-04-04 Thread Daniel D . Daugherty
On Tue, 4 Apr 2023 18:58:12 GMT, Mandy Chung wrote: > This gives time to investigate JDK-8305600 and understand why the test didn't > fail on my testing before the push. Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR Review: https://git.openjdk.or

Integrated: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

2023-04-04 Thread Mandy Chung
This gives time to investigate JDK-8305600 and understand why the test didn't fail on my testing before the push. - Commit messages: - ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java Changes: https://git.openjdk.org/jdk/pull/13334/files Webrev: https://webrevs.ope

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Eirik Bjorsnos
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Mandy Chung
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Lance Andersen
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Eirik Bjorsnos
On Tue, 4 Apr 2023 18:39:54 GMT, Lance Andersen wrote: > I've edited it to add a Specification section with a summary of the changes > to the JAR file spec. I also update the Solution section so that it provides > a clearer summary of the changes. Thanks a lot Alan, as this CSR has deeper wate

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Lance Andersen
On Tue, 4 Apr 2023 18:37:34 GMT, Alan Bateman wrote: > > I have drafted CSR https://bugs.openjdk.org/browse/JDK-8305597, but I'm not > > sure what to put in the _Specification_ section. > > What is the specification change in this PR? The removal of the system > > property? The adding of the wa

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Alan Bateman
On Tue, 4 Apr 2023 18:23:23 GMT, Eirik Bjorsnos wrote: > I have drafted CSR https://bugs.openjdk.org/browse/JDK-8305597, but I'm not > sure what to put in the _Specification_ section. > > What is the specification change in this PR? The removal of the system > property? The adding of the warni

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Good riddance. - PR

Re: RFR: 8305113: (tz) Update Timezone Data to 2023c [v3]

2023-04-04 Thread Sergey Bylokhov
On Mon, 3 Apr 2023 23:40:05 GMT, Yoshiki Sato wrote: >> Pleases review this PR. >> The PR includes the following changes. >> - tzdata 2023c >> - Hack code to deal with Cairo's DST end, which is same as done in >> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work >> ar

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Marked as reviewed by alanb (Revie

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Eirik Bjorsnos
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8302819: Remove JAR Index [v5]

2023-04-04 Thread Alan Bateman
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote: >> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementa

Re: RFR: 8304982: Emit warning for removal of `COMPAT` provider [v2]

2023-04-04 Thread Alan Bateman
On Tue, 4 Apr 2023 17:32:35 GMT, Naoto Sato wrote: > Good point. Removed the @implNote tag for now and filed a separate issue to > clarify the system property: https://bugs.openjdk.org/browse/JDK-8305595 Okay, that works for me. - PR Review Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8304982: Emit warning for removal of `COMPAT` provider [v3]

2023-04-04 Thread Alan Bateman
On Tue, 4 Apr 2023 17:30:00 GMT, Naoto Sato wrote: >> This is a precursor to the future removal of the `COMPAT` locale data >> provider. Before the actual removal of the provider, warn the users who >> explicitly specify `COMPAT` at the command line in order for their smooth >> migration to CL

Integrated: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

2023-04-04 Thread Raffaello Giulietti
On Tue, 4 Apr 2023 13:25:44 GMT, Raffaello Giulietti wrote: > A fix for the issue and additional specific tests. This pull request has now been integrated. Changeset: 7c650489 Author:Raffaello Giulietti URL: https://git.openjdk.org/jdk/commit/7c650489d2ffd9ec7c8513427ff7c83ed30dcec

Integrated: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-04-04 Thread Mandy Chung
On Fri, 24 Mar 2023 20:41:41 GMT, Mandy Chung wrote: > This implements a shared utility to dump generated classes defined as > normal/hidden classes via `Lookup` API. This replaces the implementation in > `LambdaMetaFactory` and method handle implementation that dumps the hidden > class byte

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The CSR for this PR has been appro

Re: RFR: 8304982: Emit warning for removal of `COMPAT` provider [v2]

2023-04-04 Thread Naoto Sato
On Tue, 4 Apr 2023 06:54:38 GMT, Alan Bateman wrote: >> Locale providers provided by users can all be loaded in the name of `SPI`, >> as they are the real implementation of `LocaleServiceProvider` class, so the >> order of the preference can be specified against JDK's `CLDR` provider. Does >>

Re: RFR: 8304982: Emit warning for removal of `COMPAT` provider [v3]

2023-04-04 Thread Naoto Sato
> This is a precursor to the future removal of the `COMPAT` locale data > provider. Before the actual removal of the provider, warn the users who > explicitly specify `COMPAT` at the command line in order for their smooth > migration to CLDR. A CSR has also been drafted. Naoto Sato has updated

Re: RFR: 8284871: Use covariant overrides for the resolveConstantDesc(Lookup) method in sub‑interfaces of java.lang.constant.ConstantDesc [v3]

2023-04-04 Thread Chen Liang
> Also remove redundant casts to avoid javac warnings. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the la

Re: RFR: 8305107: Emoji related binary properties in RegEx

2023-04-04 Thread Naoto Sato
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato wrote: > Introducing new regex constructs that match those 6 new Unicode Emoji > properties implemented in the `Character` class > (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been > drafted. Thanks, Iris, Andrey. Alignment

Re: RFR: 8305107: Emoji related binary properties in RegEx [v2]

2023-04-04 Thread Naoto Sato
> Introducing new regex constructs that match those 6 new Unicode Emoji > properties implemented in the `Character` class > (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been > drafted. Naoto Sato has updated the pull request incrementally with one additional commit si

Re: RFR: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

2023-04-04 Thread Joe Darcy
On Tue, 4 Apr 2023 13:25:44 GMT, Raffaello Giulietti wrote: > A fix for the issue and additional specific tests. Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13326#pullrequestreview-1371418773

Re: RFR: 8304745: Lazily initialize byte[] in java.io.BufferedInputStream [v9]

2023-04-04 Thread Brian Burkhalter
On Mon, 27 Mar 2023 16:18:22 GMT, Sergey Tsypanov wrote: >> By default `BufferedInputStream` is constructed with internal buffer with >> capacity 8192. In some cases this buffer is never used, e.g. when we call >> `IS.readNBytes()` or `IS.readAllBytes()` (relying on `BIS.read1()`) or when >> `

Re: RFR: 8304745: Lazily initialize byte[] in java.io.BufferedInputStream [v9]

2023-04-04 Thread Brian Burkhalter
On Mon, 27 Mar 2023 16:18:22 GMT, Sergey Tsypanov wrote: >> By default `BufferedInputStream` is constructed with internal buffer with >> capacity 8192. In some cases this buffer is never used, e.g. when we call >> `IS.readNBytes()` or `IS.readAllBytes()` (relying on `BIS.read1()`) or when >> `

Re: RFR: 8305113: (tz) Update Timezone Data to 2023c [v3]

2023-04-04 Thread Naoto Sato
On Mon, 3 Apr 2023 23:40:05 GMT, Yoshiki Sato wrote: >> Pleases review this PR. >> The PR includes the following changes. >> - tzdata 2023c >> - Hack code to deal with Cairo's DST end, which is same as done in >> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work >> ar

Re: RFR: 8305113: (tz) Update Timezone Data to 2023c [v3]

2023-04-04 Thread Andrew John Hughes
On Mon, 3 Apr 2023 23:40:05 GMT, Yoshiki Sato wrote: >> Pleases review this PR. >> The PR includes the following changes. >> - tzdata 2023c >> - Hack code to deal with Cairo's DST end, which is same as done in >> 2014g([JDK-8049343](https://bugs.openjdk.org/browse/JDK-8049343)). To work >> ar

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v54]

2023-04-04 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation a

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
On Tue, 4 Apr 2023 15:31:12 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RuntimeException is the only exception type that can is deduced from a >> lambda. > > src/java.base/share/classes/java/lang

Integrated: 8298619: java/io/File/GetXSpace.java is failing

2023-04-04 Thread Brian Burkhalter
On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter wrote: > Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. This pull request has now been integrated. Changeset: 3ef834fc Au

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
On Tue, 4 Apr 2023 15:18:43 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RuntimeException is the only exception type that can is deduced from a >> lambda. > > src/java.base/share/classes/java/lang

Re: RFR: 8305461: [vectorapi] Add VectorMask::xor

2023-04-04 Thread Paul Sandoz
On Sat, 1 Apr 2023 15:40:14 GMT, Quan Anh Mai wrote: > Hi, > > This patch adds `VectorMask.xor` to the public interface of `VectorMask`. > This method has already been existed in each concrete mask classes. > > Please kindly review. > Thanks a lot. Thank you for doing this. I am guessing it w

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Rémi Forax
On Tue, 4 Apr 2023 15:16:19 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of evalua

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Rémi Forax
On Tue, 4 Apr 2023 15:16:19 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of evalua

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v53]

2023-04-04 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation a

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v4]

2023-04-04 Thread Quan Anh Mai
On Mon, 3 Apr 2023 16:36:08 GMT, Paul Sandoz wrote: >> Quan Anh Mai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - instruction asserts >> - Merge branch 'master' into sliceIntrinsics >> - add comments expl

Re: RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder

2023-04-04 Thread Alan Bateman
On Tue, 4 Apr 2023 12:37:15 GMT, Andrey Turbanov wrote: > Seems we can update `java.lang.module.ModuleDescriptor.Builder#uses` too to > directly call `add` instead of `contains`+`add` If you are changing uses(String) then it should obey `strict`, meaning put this at the beginning of the method

Re: RFR: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)

2023-04-04 Thread Adam Sotona
On Sun, 26 Mar 2023 20:35:20 GMT, Chen Liang wrote: > Please review this simple patch to Classfile API that fixes a missing > override that otherwise affects usage of chained class transforms. A test is > included, that it fails on the missing method without this patch. > > Please review a few

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v6]

2023-04-04 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8305107: Emoji related binary properties in RegEx

2023-04-04 Thread Andrey Turbanov
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato wrote: > Introducing new regex constructs that match those 6 new Unicode Emoji > properties implemented in the `Character` class > (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been > drafted. test/jdk/java/util/regex/RegExT

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v16]

2023-04-04 Thread Roger Riggs
On Tue, 4 Apr 2023 11:09:24 GMT, Alan Bateman wrote: >> Early on during this PR, we decided and implemented to read the >> `ModuleTarget` only if the java.base module's file path doesn't match that >> of the current platform's file path. If we remove that check and instead >> always read the M

RFR: 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value

2023-04-04 Thread Raffaello Giulietti
A fix for the issue and additional specific tests. - Commit messages: - 8305343: BigDecimal.fractionOnly() erroneously returns true for large scale value Changes: https://git.openjdk.org/jdk/pull/13326/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13326&range=00 Issue:

Re: RFR: 8303762: [vectorapi] Intrinsification of Vector.slice [v5]

2023-04-04 Thread Quan Anh Mai
> `Vector::slice` is a method at the top-level class of the Vector API that > concatenates the 2 inputs into an intermediate composite and extracts a > window equal to the size of the inputs into the result. It is used in vector > conversion methods where the part number is not 0 to slice the pa

Re: RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder

2023-04-04 Thread Andrey Turbanov
On Mon, 3 Apr 2023 08:08:45 GMT, Andrey Turbanov wrote: > `Map.containsKey` call is sometimes unnecessary, when it's known that `Map` > doesn't contain `null` values. > Instead of pair containsKey+put we can use putIfAbsent and compare result > with null. > Result code is shorter and a bit fast

RFR: 8305538: Avoid redundant HashMap.containsKey call in ModuleDescriptor.Builder

2023-04-04 Thread Andrey Turbanov
`Map.containsKey` call is sometimes unnecessary, when it's known that `Map` doesn't contain `null` values. Instead of pair containsKey+put we can use putIfAbsent and compare result with null. Result code is shorter and a bit faster. - Commit messages: - [PATCH] Avoid redundant Hash

Re: RFR: 8304745: Lazily initialize byte[] in java.io.BufferedInputStream [v3]

2023-04-04 Thread Alan Bateman
On Mon, 27 Mar 2023 15:24:05 GMT, Brian Burkhalter wrote: >> I skimmed through the latest version but there are still several issues. >> Can you try the patch below instead? This will ensure that read, skip, >> reset, etc. check buf as before. It also ensures that read1 does the same >> thres

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v16]

2023-04-04 Thread Alan Bateman
On Wed, 29 Mar 2023 01:47:35 GMT, Jaikiran Pai wrote: >> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 97: >> >>> 95:// separate --module-path will force the JLink task to read >>> the ModuleTarget from >>> 96:// the java.base module-info.class to identify the tar

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v17]

2023-04-04 Thread Alan Bateman
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated imag

Re: RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v3]

2023-04-04 Thread Aleksey Shipilev
On Mon, 3 Apr 2023 22:41:44 GMT, David Holmes wrote: >> We have the strange situation where calling `t.isAlive()` on a >> `java.lang.Thread` `t`, will call into the VM (via `alive()` then >> `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract >> its `JavaThread` pointe