On Mon, 3 Apr 2023 16:36:08 GMT, Paul Sandoz <psan...@openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains ten commits:
>> 
>>  - instruction asserts
>>  - Merge branch 'master' into sliceIntrinsics
>>  - add comments explaining anonymous classes
>>  - address reviews
>>  - sse2, increase warmup
>>  - aesthetic
>>  - optimise 64B
>>  - add jmh
>>  - vector slice intrinsics
>
> With the latest PR I am observing failures with debug builds for test 
> compiler/vectorapi/TestVectorSlice.java on both AVX512 machines and aarch64 
> machines.
> 
> On AVX512 machines the test fails with JVM args `-XX:UseAVX=3` and 
> `-XX:UseAVX=3 -XX:+UnlockDiagnosticVMOptions -XX:+UseKNLSetting` and results 
> in a test assertion failure e.g.,
> 
> Caused by: java.lang.RuntimeException: assertEquals: expected 70 to equal 0
>       at jdk.test.lib.Asserts.fail(Asserts.java:594)
>       at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>       at jdk.test.lib.Asserts.assertEquals(Asserts.java:189)
>       at 
> compiler.vectorapi.TestVectorSlice.lambda$testInts$2(TestVectorSlice.java:163)
>       at compiler.vectorapi.TestVectorSlice.testInts(TestVectorSlice.java:181)
>       at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>       ... 7 more
> 
> 
> CPU flags are:
> 
> fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 
> clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant tsc 
> arch perfmon rep good nopl xtopology cpuid tsc known freq pni pclmulqdq vmx 
> ssse3 fma cx16 pdcm pcid sse4 1 sse4 2 x2apic movbe popcnt tsc deadline timer 
> aes xsave avx f16c rdrand hypervisor lahf lm abm 3dnowprefetch cpuid fault 
> invpcid single ssbd ibrs ibpb stibp ibrs enhanced tpr shadow vnmi 
> flexpriority ept vpid ept ad fsgsbase tsc adjust bmi1 avx2 smep bmi2 erms 
> invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd 
> sha ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves nt good wbnoinvd arat 
> avx512vbmi umip pku ospke avx512 vbmi2 gfni vaes vpclmulqdq avx512 vnni 
> avx512 bitalg avx512 vpopcntdq la57 rdpid md clear arch capabilities
> 
> 
> On aarch64 there is an IR rule failure.

@PaulSandoz I have fixed the error in AVX512 and added feature predicates to 
not do IR check on AArch64
@XiaohongGong Thanks for your reviews, I have addressed them

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12909#issuecomment-1496115432

Reply via email to