On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Introducing new regex constructs that match those 6 new Unicode Emoji > properties implemented in the `Character` class > (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been > drafted. test/jdk/java/util/regex/RegExTest.java line 3774: > 3772: Matcher emojiPP = > Pattern.compile("\\p{IsEmoji_Presentation}").matcher(""); > 3773: Matcher emojiMP = > Pattern.compile("\\p{IsEmoji_Modifier}").matcher(""); > 3774: Matcher emojiMBP = > Pattern.compile("\\p{IsEmoji_Modifier_Base}").matcher(""); Let's align to this assignment. Or remove alignments completely. test/jdk/java/util/regex/RegExTest.java line 3851: > 3849: POSIX_Unicode.isJoinControl(cp) != > joinCrtl.reset(str).matches() || > 3850: // Emoji properties > 3851: isEmoji(cp) != emojiP.reset(str).matches() || Suggestion: isEmoji(cp) != emojiP.reset(str).matches() || ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1157280360 PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1157280914
