On Tue, 4 Apr 2023 17:10:09 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Introducing new regex constructs that match those 6 new Unicode Emoji >> properties implemented in the `Character` class >> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > indentation Changes requested by rriggs (Reviewer). test/jdk/java/util/regex/RegExTest.java line 64: > 62: import java.util.stream.Stream; > 63: > 64: import static java.lang.Character.*; These static imports make the uses of the methods harder to recognize as from the Character class. test/jdk/java/util/regex/RegExTest.java line 967: > 965: for (int i=0; i<1000; i++) { > 966: char c = (char)generator.nextInt(); > 967: check("{javaLowerCase}", c, isLowerCase(c)); There are more readable with the explicit Character class reference; with them one has to hunt around for the named method. It also makes it explicit what is being tested. ------------- PR Review: https://git.openjdk.org/jdk/pull/13314#pullrequestreview-1371648289 PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1157676720 PR Review Comment: https://git.openjdk.org/jdk/pull/13314#discussion_r1157677335
