On Thu, 2 Mar 2023 17:43:54 GMT, Afshin Zafari wrote:
>> ### Description
>> The use of `ThreadDeath` is replaced with checking the exception be of type
>> `Error` and the thread is `TERMINATED`.
>>
>>
>> ### Test
>> local and mach5 tier1
>
> Afshin Zafari has updated the pull request increment
On Fri, 3 Mar 2023 06:35:41 GMT, Joe Darcy wrote:
>> Last and certainly not least in the port of FDLIBM to Java, the
>> transcendental methods for sin, cos, and tan.
>>
>> Some more tests are to be written in the StrictMath directory to verify that
>> the StrictMath algorihtm for sin/cos/tan i
> Last and certainly not least in the port of FDLIBM to Java, the
> transcendental methods for sin, cos, and tan.
>
> Some more tests are to be written in the StrictMath directory to verify that
> the StrictMath algorihtm for sin/cos/tan is being used rather than a
> different one. However, I w
On Wed, 1 Mar 2023 15:42:08 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add note explaining goto translation.
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 867:
>
>> 865:
>
> Last and certainly not least in the port of FDLIBM to Java, the
> transcendental methods for sin, cos, and tan.
>
> Some more tests are to be written in the StrictMath directory to verify that
> the StrictMath algorihtm for sin/cos/tan is being used rather than a
> different one. However, I w
On Wed, 1 Mar 2023 15:28:24 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with 10 additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>>Co-authored-by: Andrey Turbanov
>> - Updat
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs wrote:
>> Consolidate logging and handle exceptions by printing to standard error and
>> ignoring the exception.
>> Exceptions while logging will not interfere with Runtime.exit.
>
> Roger Riggs has updated the pull request incrementally with one addi
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Fri, 3 Mar 2023 02:49:01 GMT, Chris Plummer wrote:
> Are you going to remove VMOutOfMemoryException001.java from the problem list?
I'll do that a separate PR to avoid mixing the issues and solutions.
This change is not only to address JDK-8303057.
-
PR: https://git.openjdk.org/j
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs wrote:
>> Consolidate logging and handle exceptions by printing to standard error and
>> ignoring the exception.
>> Exceptions while logging will not interfere with Runtime.exit.
>
> Roger Riggs has updated the pull request incrementally with one addi
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs wrote:
>> Consolidate logging and handle exceptions by printing to standard error and
>> ignoring the exception.
>> Exceptions while logging will not interfere with Runtime.exit.
>
> Roger Riggs has updated the pull request incrementally with one addi
Port of: https://github.com/openjdk/panama-foreign/pull/780 Which adds tests
for nested structs/unions/arrays, and fixes an issue with nested HFAs on
AArch64.
This PR also includes https://github.com/openjdk/panama-foreign/pull/765 which
is required for the fix to apply cleanly.
Moving these c
On Thu, 2 Mar 2023 13:48:26 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/780 Which adds tests
> for nested structs/unions/arrays, and fixes an issue with nested HFAs on
> AArch64.
>
> This PR also includes https://github.com/openjdk/panama-foreign/pull/765
On Fri, 3 Mar 2023 01:02:40 GMT, Vladimir Kozlov wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
I'm not 100% positive if the current __kernel_rem_pio2 code would be in use.
IIRC, back when we used the fsin/fcos instructions to intri
On Fri, 3 Mar 2023 00:38:18 GMT, David Holmes wrote:
> Actually this is really my lack of understanding about the current code: why
> do we intrinsify `Math` but not `StrictMath`?
In brief, the Math methods are allowed implementation flexibility in terms of
their algorithm but the StrictMath m
On Mon, 27 Feb 2023 18:45:44 GMT, Vladimir Kozlov wrote:
>>> Testing results seem good. Except one strange failure I put in
>>> [JDK-8143900](https://bugs.openjdk.org/browse/JDK-8143900) comment. You
>>> need second review.
>>
>> This seems related to https://bugs.openjdk.org/browse/JDK-829691
On Tue, 21 Feb 2023 02:29:44 GMT, Yi Yang wrote:
> Hi, can I have a review for this patch? I noticed a strange field
> Integer.sizeTable which is used by PhaseStringOpts, after digging into the
> history, I think it could be replaced by an in-place array allocation and
> initialization. Before
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Fri, 3 Mar 2023 00:31:12 GMT, David Holmes wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
`SharedRuntime::*` runtime math functions are used on platforms where there are
no HW instructions or intrinsics (Zero VM). JIT compiled co
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 20:00:56 GMT, Martin Buchholz wrote:
> Inviting @DougLea and @viktorklang-ora to review.
>
> As usual, I couldn't resist more fiddling.
> - Added missing tests for take, remove(), remove(Object).
> - Improved DelayQueueTest's testing infrastructure
> - added more test assert
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
This PR includes cleanup changes to the sun.util.calendar package only.
The changes include removing unused methods, imports, adjusting incorrect
links, and using newer syntax patterns. Since there are no plans to promote any
of these classes to java.calendar, these unused methods can be removed
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 23 Feb 2023 16:42:17 GMT, Sean Mullan wrote:
> The LDAPCertStore implementation passes Distinguished Names in CRL and
> Certificate URLs as Strings to JNDI APIs such as
> LdapContext.getAttributes(String), which then treats them as CompositeNames.
> This causes issues with URLs that ha
Hello,
I suggest a general discussion about whether or not such a class is
appropriate for inclusion in the platform [1] ahead of review of a
particular PR.
Cheers,
-Joe
[1] https://openjdk.org/guide/#socialize-your-change
On 2/21/2023 10:21 AM, Fabio Romano wrote:
The Rational class provi
On Thu, 2 Mar 2023 22:18:53 GMT, Joe Darcy wrote:
> There are fairly standard idioms to get a random number generator from the
> test library and use it in the test.
>
> I'd prefer to see that approach taken here, with an update to use the jtreg
> "@randomness" tag in the appropriate place.
S
> Break up `BigIntegerTest` and `SymmetricRangeTests` into subsets which are
> run quasi-randomly as a function of second within the minute at the time the
> test is running. `LargeValueExceptions` does not appear amenable to this
> treatment.
Brian Burkhalter has updated the pull request incre
On Thu, 23 Feb 2023 16:42:17 GMT, Sean Mullan wrote:
> The LDAPCertStore implementation passes Distinguished Names in CRL and
> Certificate URLs as Strings to JNDI APIs such as
> LdapContext.getAttributes(String), which then treats them as CompositeNames.
> This causes issues with URLs that ha
On Wed, 1 Mar 2023 23:36:04 GMT, Brian Burkhalter wrote:
> Break up `BigIntegerTest` and `SymmetricRangeTests` into subsets which are
> run quasi-randomly as a function of second within the minute at the time the
> test is running. `LargeValueExceptions` does not appear amenable to this
> trea
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Thu, 2 Mar 2023 17:35:35 GMT, Alan Bateman wrote:
>> I assumed the `ThreadDeath` was there to catch `Thread.stop()` calls and
>> just ignore them. So, I wanted to keep this functionality.
>> Can we remove using `ThreadDeath` relying on that `Thread.stop()` is also
>> deprecated?
>
> I think
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 17:43:54 GMT, Afshin Zafari wrote:
>> ### Description
>> The use of `ThreadDeath` is replaced with checking the exception be of type
>> `Error` and the thread is `TERMINATED`.
>>
>>
>> ### Test
>> local and mach5 tier1
>
> Afshin Zafari has updated the pull request increment
The purpose of this task is to add the difference between -manual jdk_core and
jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order to
streamline the manual test execution process, a new test group called
jdk_core_manual_human has been created for manual tests that demand extr
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Thu, 2 Mar 2023 10:24:03 GMT, Raffaello Giulietti
wrote:
>> Add an `indexOf()` variant allowing to specify both a lower and an upper
>> bound on the search.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 830259
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:38:29 GMT, Justin Lu wrote:
>> This PR modifies the javadoc of methods in Locale, LocaleServiceProvider,
>> and LocaleServiceProviderPool to use {@return and @linkplain.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last re
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote:
> The following typo: `@returnss` was reported on line _482 of Reflection
> Factory.java_.
>
> In addition to fixing that, I have replaced multiple instances of `@returns`
> with `@return` in the same file.
This pull request has now been integ
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 15 Feb 2023 14:12:21 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java
>> line 63:
>>
>>> 61: * aload_0}).
>>> 62: */
>>> 63: sealed interface IntrinsicConstantInstruction extends
>>> ConstantInstruction
>>
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Add snippet
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12728/fil
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
Inviting @DougLea and @viktorklang-ora to review.
As usual, I couldn't resist more fiddling.
- Added missing tests for take, remove(), remove(Object).
- Improved DelayQueueTest's testing infrastructure
- added more test assertions
- linkified new javadoc definitions
-
Commit messag
On Thu, 2 Mar 2023 18:39:36 GMT, Andrey Turbanov wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Move @since in subclasses
>> - Move @since
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line
> Add the ability to repeatedly append char and CharSequence data to
> StringBuilder/StringBuffer.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Support code points
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Thu, 2 Mar 2023 14:18:13 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/reflect/Proxy.java line 889:
>>
>>> 887: :
>>> Objects.toIdentityString(ld);
>>> 888: throw new IllegalArgumentException(c.getName()
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 16:43:47 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove prefix Locale for in-class linkplains
>
> src/java.base/share/classes/java/util/Locale.java line 2075:
>
>> 2073:
> This PR modifies the javadoc of methods in Locale, LocaleServiceProvider, and
> LocaleServiceProviderPool to use {@return and @linkplain.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Remove prefix Locale for in-class linkplains
--
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:19:20 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
> src/java.base/share/classes/java/lang/St
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 15:25:07 GMT, Matthew Donovan wrote:
>> Removed SSLSocketParametersTest.sh script (which just called a Java file)
>> and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. T
On Wed, 1 Mar 2023 12:54:44 GMT, Jim Laskey wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Move @since in subclas
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote:
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
> locales with `common` locales
> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
> to have the same coverage level of locales, CLDRConve
On Thu, 2 Mar 2023 07:12:01 GMT, Alan Bateman wrote:
> This is a great milestone to get to! Does the comment at the top of
> sharedRuntimeTrig.cpp need updating?
Updated several of the comments in the HotSpot sources and added a description
of the transliteration process to StrictMath.
--
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 14:05:55 GMT, Erik Joelsson wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
> make/autoconf/buildjdk-spec.gmk.in line 85:
> ### Description
> The use of `ThreadDeath` is replaced with checking the exception be of type
> `Error` and the thread is `TERMINATED`.
>
>
> ### Test
> local and mach5 tier1
Afshin Zafari has updated the pull request incrementally with one additional
commit since the last revision:
83016
On Thu, 2 Mar 2023 17:39:10 GMT, Afshin Zafari wrote:
>> ### Description
>> The use of `ThreadDeath` is replaced with checking the exception be of type
>> `Error` and the thread is `TERMINATED`.
>>
>>
>> ### Test
>> local and mach5 tier1
>
> Afshin Zafari has updated the pull request increment
On Thu, 2 Mar 2023 17:26:53 GMT, Brian Burkhalter wrote:
>> Deprecate `SensitivityWatchEventModifier` for now instead of directly
>> removing it as proposed in #12626.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 83
On Thu, 2 Mar 2023 17:27:59 GMT, Afshin Zafari wrote:
>> test/lib/jdk/test/lib/process/ProcessTools.java line 827:
>>
>>> 825:
>>> 826: public void uncaughtException(Thread t, Throwable e) {
>>> 827: if (e instanceof Error && t.getState() ==
>>> State.TERMINATED) {
>>
>> D
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
On Thu, 2 Mar 2023 14:13:10 GMT, Alan Bateman wrote:
>> ### Description
>> The use of `ThreadDeath` is replaced with checking the exception be of type
>> `Error` and the thread is `TERMINATED`.
>>
>>
>> ### Test
>> local and mach5 tier1
>
> test/lib/jdk/test/lib/process/ProcessTools.java line
Updates to the documentation to describe behavior in Matcher.group().
-
Commit messages:
- Updating verbiage
- Merge branch 'master' into matcher-group-doc-update
- 8217496 Matcher.group() can return null after usePattern
Changes: https://git.openjdk.org/jdk/pull/12835/files
Webr
On Thu, 2 Mar 2023 07:44:06 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8303175: Change @deprecated verbiage in SensitivityWatchEventModifier
>
> src/jdk.unsupported/share/classes/com/sun/
> Deprecate `SensitivityWatchEventModifier` for now instead of directly
> removing it as proposed in #12626.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8303175: Improve @deprecated verbiage in SensitivityWatchEventModifier
Correct and thank you.
📱
> On Mar 2, 2023, at 1:04 PM, Alex Buckley wrote:
>
> On 3/2/2023 3:14 AM, Jim Laskey wrote:
>> Can I get some signing reviewers of the CSR
>> https://bugs.openjdk.org/browse/JDK-8286021 ?
>
> I added remarks to the CSR about the static field STR that is automatical
On Thu, 2 Mar 2023 14:29:13 GMT, Adam Sotona wrote:
>> I had the same observation as Maurizio.
>
> I've extracted `StackMapFrameInfo` to the top level and moved
> `VerificationTypeInfo`, however it is still nested.
> Let me know if you think we should really avoid all nested or if info inside
>
On 3/2/2023 3:14 AM, Jim Laskey wrote:
Can I get some signing reviewers of the CSR
https://bugs.openjdk.org/browse/JDK-8286021 ?
I added remarks to the CSR about the static field STR that is
automatically imported into every Java program. (Only when preview
features are enabled, right?)
Al
On Thu, 2 Mar 2023 10:24:03 GMT, Raffaello Giulietti
wrote:
>> Add an `indexOf()` variant allowing to specify both a lower and an upper
>> bound on the search.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 830259
The LDAPCertStore implementation passes Distinguished Names in CRL and
Certificate URLs as Strings to JNDI APIs such as
LdapContext.getAttributes(String), which then treats them as CompositeNames.
This causes issues with URLs that have DNs with forward slashes. These are rare
but compliant wit
On Tue, 28 Feb 2023 00:09:45 GMT, Justin Lu wrote:
> This PR modifies the javadoc of methods in Locale, LocaleServiceProvider, and
> LocaleServiceProviderPool to use {@return and @linkplain.
src/java.base/share/classes/java/util/Locale.java line 2075:
> 2073: * user. This will be the valu
On Wed, 1 Mar 2023 23:45:47 GMT, Justin Lu wrote:
>> This PR changes the English name for the region `TR`, from `Turkey` to
>> `Türkiye`. Although this change is included in the upcoming CLDR v43, it
>> should be applied as a spot change so that it can be back-ported properly
>> (As it is a co
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
On Tue, 28 Feb 2023 10:53:14 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/ForEachOps.java line 513:
>>
>>> 511: // of right subtree (if any, which can be this task's
>>> right sibling)
>>> 512: //
>>> 513: var leftDescendant = (For
On Wed, 1 Mar 2023 23:45:47 GMT, Justin Lu wrote:
>> This PR changes the English name for the region `TR`, from `Turkey` to
>> `Türkiye`. Although this change is included in the upcoming CLDR v43, it
>> should be applied as a spot change so that it can be back-ported properly
>> (As it is a co
On Thu, 2 Mar 2023 02:03:51 GMT, Martin Buchholz wrote:
>>> @Martin-Buchholz Martin, how would you like to proceed with your proposed
>>> wording, would you prefer a suggested edit to this PR, do a separate PR, or
>>> otherwise? /cc @AlanBateman (any recommendation, Alan? thinking )
>>
>> Talk
On Sat, 28 Jan 2023 19:54:32 GMT, Glavo wrote:
>> This is the javadoc of `JavaLangAccess::newStringNoRepl`:
>>
>>
>> /**
>> * Constructs a new {@code String} by decoding the specified subarray of
>> * bytes using the specified {@linkplain java.nio.charset.Charset
>> charset}.
>>
On Thu, 2 Mar 2023 10:24:03 GMT, Raffaello Giulietti
wrote:
>> Add an `indexOf()` variant allowing to specify both a lower and an upper
>> bound on the search.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 830259
On Thu, 2 Mar 2023 02:03:51 GMT, Martin Buchholz wrote:
>>> @Martin-Buchholz Martin, how would you like to proceed with your proposed
>>> wording, would you prefer a suggested edit to this PR, do a separate PR, or
>>> otherwise? /cc @AlanBateman (any recommendation, Alan? thinking )
>>
>> Talk
On Wed, 1 Mar 2023 23:57:52 GMT, Paul Sandoz wrote:
>> Every case has been considered individually, evaluated on use cases and pros
>> and cons have been weighted. Unified approach across the whole API would be
>> nice, however not so simple and not the highest priority.
>
> I had the same obse
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Thu, 2 Mar 2023 10:32:48 GMT, Ravali Yatham wrote:
>> Added specific class loader object to proxy IllegalArgumentException from
>> which the class was not visible
>>
>> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
>
> Ravali Yatham has updated the pull request inc
1 - 100 of 127 matches
Mail list logo
