On Thu, 2 Mar 2023 07:44:06 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8303175: Change @deprecated verbiage in SensitivityWatchEventModifier
>
> src/jdk.unsupported/share/classes/com/sun/nio/file/SensitivityWatchEventModifier.java
> line 41:
>
>> 39: * which used this {@code WatchEvent.Modifier}. Therefore this
>> 40: * {@code WatchEvent.Modifier} class is vestigial and should be removed
>> in a
>> 41: * future release.
>
> "no longer recognizes" suggests that using them will lead to an error but
> it's actually that they will be just ignored.
>
> Also "should be removed in a future release" will duplicate text generated by
> javadoc. The JDK docs build doesn't generate javadoc for the jdk.unsupported
> module so maybe it doesn't matter but here's a suggestion for something a bit
> briefer:
>
> "The sensitivity levels were historically used by polling based WatchService
> implementations to configure the polling interval. They are are no longer
> used. The WatchService implementations in the JDK ignore these WatchEvent
> modifiers if they are specified when registering a directory to be watched."
Thanks, that is much better; used in ca92fdba0897b7acfedc3bc933b874c3b421a0a3.
-------------
PR: https://git.openjdk.org/jdk/pull/12746
