On Wed, 1 Mar 2023 15:28:24 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> Joe Darcy has updated the pull request incrementally with 10 additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turban...@gmail.com>
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 839:
>
>> 837: twon24 = 5.96046447753906250000e-08; /* 0x3E700000,
>> 0x00000000 */
>> 838:
>> 839: static int __kernel_rem_pio2(double[] x, double[] y, int e0,
>> int nx, int prec, final int[] ipio2) {
>
> `final int[]` in Java has a different semantics than `const int*` in C. The
> latter denotes a pointer to constant `int`s.
> I don't think that the `final` keywords conveys any benefit here.
Hmm. I don't think having "final" on the parameter is harmful, but I see the
case for it not being that useful either.
At least in the JDK source, we typically don't make an effort to final-ize
parameters when possible.
-------------
PR: https://git.openjdk.org/jdk/pull/12800
