On Mon, 15 Aug 2022 19:42:36 GMT, Volker Simonis wrote:
>> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 164:
>>
>>> 162: // fill() to avoid an EOF error if no more input
>>> is available and the
>>> 163: // next call to inflate
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Mon, 15 Aug 2022 13:23:40 GMT, Ao Qi wrote:
>> For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1
>> failed on LoongArch64 (probably other platforms unsupported in
>> src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the
>> same issue):
>>
>>
>>
On Tue, 16 Aug 2022 02:08:43 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the hashcode depending on the
> order of iteration of the
On Mon, 15 Aug 2022 16:07:45 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate review comments and add more testing
>
> test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 1
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This
> misses the case where the native inflater has con
On Mon, 15 Aug 2022 18:36:11 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Mon, 15 Aug 2022 18:34:17 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Mon, 15 Aug 2022 18:01:15 GMT, Alan Bateman wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is tru
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9816
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Mon, 15 Aug 2022 14:32:51 GMT, Roger Riggs wrote:
>> These changes reduce the default run time from about 1 day 22 hours to about
>> 6 hours with good stability we can use in weekly testing.
>
> test/micro/org/openjdk/bench/java/util/stream/ops/value/SizedCount.java line
> 30:
>
>> 28: impo
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Mon, 15 Aug 2022 17:43:27 GMT, Volker Simonis wrote:
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true.
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
The problem is that after
[JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()`
unconditionally (and before calling `Inflater::inflate()`) in
`InflaterInputStream::read()` if `Inflater::needsInput()` is true. This misses
the case where the native inflater has consumed all
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Fri, 12 Aug 2022 14:52:23 GMT, Brian Burkhalter wrote:
> On Windows, suppress failure if the total space indicated by `df` is less
> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
> `FileStore::getUnallocatedSpace`.
In reality GetFreeDiskSpaceEx does not appear
On Mon, 15 Aug 2022 16:39:42 GMT, Alan Bateman wrote:
> This is hard to review. Would it be possible to provide a summary on the APIs
> and df behave with quotas?
We use the Windows API
[GetDiskFreeSpaceEx](https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskfreespacee
On Fri, 12 Aug 2022 18:20:04 GMT, Eric Caspole wrote:
> These changes reduce the run time to 45 minutes from about 1h40m with
> stability good enough for weekly promo build testing.
This pull request has now been integrated.
Changeset: b5707b03
Author:Eric Caspole
URL:
https://git.
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Approving (just) the client change
-
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9816
On Fri, 12 Aug 2022 14:52:23 GMT, Brian Burkhalter wrote:
> On Windows, suppress failure if the total space indicated by `df` is less
> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
> `FileStore::getUnallocatedSpace`.
This is hard to review. Would it be possible t
On Fri, 29 Jul 2022 03:55:54 GMT, Xiaohong Gong wrote:
> Vector API binary op "`FIRST_NONZERO`" represents the vector operation of "`a
> != 0 ? a : b`", which can be implemented with existing APIs like "`compare +
> blend`". The current implementation is more complex especially for the
> float
On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Mon, 15 Aug 2022 01:10:54 GMT, Xiaohong Gong wrote:
>> Vector API binary op "`FIRST_NONZERO`" represents the vector operation of
>> "`a != 0 ? a : b`", which can be implemented with existing APIs like
>> "`compare + blend`". The current implementation is more complex especially
>> for the f
On Mon, 15 Aug 2022 13:56:38 GMT, Aleksey Shipilev wrote:
>> See bug report for reproducer and error message. The warning looks quite
>> superficial, and I initially suspected that it complains about `int len =
>> (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the
>> simil
On Mon, 15 Aug 2022 13:57:02 GMT, Ao Qi wrote:
> > > Shouldn't we throw a SkippedException in this case?
> >
> >
> > It's the child VM that skips so throwing SkippedException would require
> > special handling in the parent.
>
> Like this?
>
> ```
> diff --git
> a/test/jdk/java/lang/Thread/
On Fri, 12 Aug 2022 18:20:04 GMT, Eric Caspole wrote:
> These changes reduce the run time to 45 minutes from about 1h40m with
> stability good enough for weekly promo build testing.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9861
On Wed, 3 Aug 2022 16:28:31 GMT, Eric Caspole wrote:
> These changes reduce the default run time from about 1 day 22 hours to about
> 6 hours with good stability we can use in weekly testing.
test/micro/org/openjdk/bench/java/util/stream/ops/value/SizedCount.java line 30:
> 28: import org.open
On Mon, 15 Aug 2022 13:30:15 GMT, Alan Bateman wrote:
> > Shouldn't we throw a SkippedException in this case?
>
> It's the child VM that skips so throwing SkippedException would require
> special handling in the parent.
Like this?
diff --git a/test/jdk/java/lang/Thread/jni/AttachCurrentThread
On Mon, 15 Aug 2022 13:21:49 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Init buf in newStringCp1252
>
> src/java.base/share/native/libjava/jni_util.c line 540:
>
>> 538: {
>> 539: in
> See bug report for reproducer and error message. The warning looks quite
> superficial, and I initially suspected that it complains about `int len =
> (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the
> similar code in `newStringCp1252` apparently does not produce the wa
On Mon, 15 Aug 2022 13:27:19 GMT, David Holmes wrote:
> Shouldn't we throw a SkippedException in this case?
It's the child VM that skips so throwing SkippedException would require special
handling in the parent.
-
PR: https://git.openjdk.org/jdk/pull/9877
On Fri, 12 Aug 2022 16:26:30 GMT, Christian Stein wrote:
> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
> accept version information in JAR file names.
>
> Find details in https://bugs.openjdk.org/browse/JDK-8292182
This pull request has now been integrated.
Chan
On Sat, 13 Aug 2022 06:10:42 GMT, Christian Stein wrote:
>> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
>> accept version information in JAR file names.
>>
>> Find details in https://bugs.openjdk.org/browse/JDK-8292182
>
> Christian Stein has updated the pull requ
On Mon, 15 Aug 2022 13:23:40 GMT, Ao Qi wrote:
>> For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1
>> failed on LoongArch64 (probably other platforms unsupported in
>> src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the
>> same issue):
>>
>>
>>
On Mon, 1 Aug 2022 14:50:48 GMT, Aleksey Shipilev wrote:
>> See bug report for reproducer and error message. The warning looks quite
>> superficial, and I initially suspected that it complains about `int len =
>> (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the
>> simila
On Mon, 15 Aug 2022 12:59:59 GMT, Alan Bateman wrote:
> Linker.nativeLinker is currently specified to throw UOE so you might find the
> following will avoid ports needing to change the test less often:
>
> ```
> --- a/test/jdk/java/lang/Thread/jni/AttachCurrentThread/ImplicitAttach.java
> +++ b
> For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1
> failed on LoongArch64 (probably other platforms unsupported in
> src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the
> same issue):
>
>
> Exception in thread "main" java.lang.UnsupportedOperati
On Mon, 15 Aug 2022 12:23:41 GMT, Ao Qi wrote:
> For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1
> failed on LoongArch64 (probably other platforms unsupported in
> src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the
> same issue):
>
>
> Except
For example, java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1
failed on LoongArch64 (probably other platforms unsupported in
src/java.base/share/classes/jdk/internal/foreign/CABI.java might have the same
issue):
Exception in thread "main" java.lang.UnsupportedOperationException: U
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Mon, 1 Aug 2022 14:50:48 GMT, Aleksey Shipilev wrote:
>> See bug report for reproducer and error message. The warning looks quite
>> superficial, and I initially suspected that it complains about `int len =
>> (int)strlen(str)` cast of `size_t`. But what is confusing is nearly the
>> simila
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Also, it avoids unnecessary boxing.
-
PR: https://git.openjdk.org/jdk/pull/9816
It's a bit shorter and clearer.
-
Commit messages:
- [PATCH] Use static methods for hashCode/toString primitives
Changes: https://git.openjdk.org/jdk/pull/9816/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9816&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8292350
47 matches
Mail list logo
