On Mon, 15 Aug 2022 18:36:11 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> The problem is that after >> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8292327) we call `fill()` >> unconditionally (and before calling `Inflater::inflate()`) in >> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This >> misses the case where the native inflater has consumed all its input (i.e. >> `Inflater::needsInput()` returns true) but hasn't managed to write all the >> inflated data into the output buffer (e.g. because it was to small). In rare >> cases, there might be now more input available (i.e. calling >> `InflaterInputStream::fill()` will throw an `EOFException`) but we still >> have to call `Inflater::inflate()` to consume the buffered output from the >> underlying native inflater until inflation stops. >> >> The documentation of the `inflate()` method in `zlib.h` mentions this >> explicitely: >> >>> "If `inflate()` returns `Z_OK` and with zero `avail_out`, it must be called >>> again after making room in the output buffer because there might be more >>> output pending." > > test/jdk/java/util/zip/InflaterInputStream/EOF.java line 37: > >> 35: import java.util.zip.InflaterInputStream; >> 36: >> 37: public class EOF { > > This is not a general purpose test for EOF so I think we'll need to find a > better name. BufferedBytesAtInputEOF might work. > > Also the test doesn't check the output. We'll need to do that to make it a > more complete test. Changed the name to `UnexpectedEndOfZlibStream.java` and updated the test as requested. ------------- PR: https://git.openjdk.org/jdk/pull/9881
