> Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8290041? > > As noted by the reporter, the current implementation is buggy since the > calculation can result in a different value of the hashcode depending on the > order of iteration of the `Modifier`s. The commit in this PR changes that > computation to produce consistent result irrespective of the order in which > the `Modifier`s (enum) is iterated upon. > > A new test has been added which reproduces the issue and verifies the fix.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: Review comments - variable name and imports organization in test ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9790/files - new: https://git.openjdk.org/jdk/pull/9790/files/4933e6d6..114c1aa7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9790&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9790&range=01-02 Stats: 23 lines in 1 file changed: 3 ins; 6 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/9790.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9790/head:pull/9790 PR: https://git.openjdk.org/jdk/pull/9790
