Re: [PR] netutils/nanopb: fix unpack step for MACOS [nuttx-apps]

2025-07-14 Thread via GitHub
pkarashchenko commented on PR #3132: URL: https://github.com/apache/nuttx-apps/pull/3132#issuecomment-3068084287 > please add a commit message to explain the change ex: replace hardcoded nanopb name whith beacause this is not available in MACOS Done. Please check -- This i

Re: [PR] system/zlib: expose zlib interface to other applications [nuttx-apps]

2025-07-14 Thread via GitHub
pkarashchenko commented on code in PR #3133: URL: https://github.com/apache/nuttx-apps/pull/3133#discussion_r2204022231 ## system/zlib/Make.defs: ## @@ -23,4 +23,8 @@ ifneq ($(CONFIG_LIB_ZLIB),) CONFIGURED_APPS += $(APPDIR)/system/zlib + +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3068525983 > > @michallenc I've reviewed your code and haven't found any obvious errors for now. Are you available or free at the moment? Maybe we could conduct an online debugging session t

Re: [I] [FEATURE] CAN and CAN FD bittiming/bitrate calculation consolidation and CAN drivers updates goals [nuttx]

2025-07-14 Thread via GitHub
ppisa commented on issue #15567: URL: https://github.com/apache/nuttx/issues/15567#issuecomment-3068535640 Thanks for analysis. As for the SocketCAN, we should follow its documentation/"specification" as closely as possible https://docs.kernel.org/networking/can.html The

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3071679945 > Add: > > ``` > Error: driver/fs_blockproxy.c:151:8: error: unused variable 'readonly' [-Werror=unused-variable] > 151 | bool readonly; > |^~~~

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3071680839 > Fix the documentation build warning: > > ``` > Warning, treated as error: > /home/runner/work/nuttx/nuttx/Documentation/components/drivers/special/mtd.rst:185:Title l

Re: [PR] system/zlib: expose zlib interface to other applications [nuttx-apps]

2025-07-14 Thread via GitHub
pkarashchenko commented on code in PR #3133: URL: https://github.com/apache/nuttx-apps/pull/3133#discussion_r2204035353 ## system/zlib/Make.defs: ## @@ -23,4 +23,8 @@ ifneq ($(CONFIG_LIB_ZLIB),) CONFIGURED_APPS += $(APPDIR)/system/zlib + +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)

Re: [PR] system/zlib: expose zlib interface to other applications [nuttx-apps]

2025-07-14 Thread via GitHub
pkarashchenko commented on code in PR #3133: URL: https://github.com/apache/nuttx-apps/pull/3133#discussion_r2204080142 ## system/zlib/Make.defs: ## @@ -23,4 +23,8 @@ ifneq ($(CONFIG_LIB_ZLIB),) CONFIGURED_APPS += $(APPDIR)/system/zlib + +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)

Re: [PR] system/zlib: expose zlib interface to other applications [nuttx-apps]

2025-07-14 Thread via GitHub
pkarashchenko closed pull request #3133: system/zlib: expose zlib interface to other applications URL: https://github.com/apache/nuttx-apps/pull/3133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
jingfei195887 commented on code in PR #16642: URL: https://github.com/apache/nuttx/pull/16642#discussion_r2206136668 ## boards/arm/stm32l4/stm32l476vg-disco/src/stm32_bringup.c: ## @@ -231,31 +228,19 @@ int stm32_bringup(void) } #else /* if defined(HAVE_N25QXXX_CHAR

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
jingfei195887 commented on code in PR #16642: URL: https://github.com/apache/nuttx/pull/16642#discussion_r2206144326 ## boards/arm/samv7/common/src/sam_progmem.c: ## @@ -66,40 +66,24 @@ static int sam_progmem_register_driver(int minor, struct mtd_dev_s *mtd,

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3071622426 Add: ``` Error: driver/fs_blockproxy.c:151:8: error: unused variable 'readonly' [-Werror=unused-variable] 151 | bool readonly; |^~~~ ``` --

Re: [PR] arm64/qemu: decouple qemu board from chip [nuttx]

2025-07-14 Thread via GitHub
anchao commented on code in PR #16718: URL: https://github.com/apache/nuttx/pull/16718#discussion_r2204988791 ## arch/arm64/src/qemu/qemu_boot.c: ## @@ -179,7 +179,9 @@ void arm64_chip_boot(void) * configuration of board specific resources such as GPIOs, LEDs, etc. */

[PR] tools/espressif: Add risc-v compiler info dump for Espressif devices [nuttx]

2025-07-14 Thread via GitHub
eren-terzioglu opened a new pull request, #16724: URL: https://github.com/apache/nuttx/pull/16724 ## Summary * tools/espressif: Add risc-v compiler info dump for Espressif devices Add xpack risc-v compiler info on diagnostic tool ## Impact Impact on use

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3070169091 > > > @michallenc I've reviewed your code and haven't found any obvious errors for now. Are you available or free at the moment? Maybe we could conduct an online debugging session t

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
nuttxs commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204383474 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/*

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
nuttxs commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204382739 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/*

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
nuttxs commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204383099 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/*

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204416105 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204416105 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/

Re: [PR] toolchain/armclang: Fix armclang config [nuttx]

2025-07-14 Thread via GitHub
W-M-R commented on PR #16720: URL: https://github.com/apache/nuttx/pull/16720#issuecomment-3068204386 > please add a commit message and explain the change ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204058431 ## netutils/dhcpc/dhcpc.c: ## @@ -87,6 +87,14 @@ #define DHCPNAK 6 #define DHCPRELEASE 7 +#ifndef CONFIG_NETUTILS_DHCPC_RELEA

Re: [PR] examples/mtdpart:Register MTD devices using the mtd_register method [nuttx-apps]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on PR #3130: URL: https://github.com/apache/nuttx-apps/pull/3130#issuecomment-3068210330 please fix: ``` Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mtdpart/mtdpart_main.c:551:1: error: Too many blank lines /home/runner/work/nuttx-apps/nu

Re: [PR] examples/mtdpart:Register MTD devices using the mtd_register method [nuttx-apps]

2025-07-14 Thread via GitHub
jingfei195887 commented on PR #3130: URL: https://github.com/apache/nuttx-apps/pull/3130#issuecomment-3068323986 > please fix: > > ``` > Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mtdpart/mtdpart_main.c:551:1: error: Too many blank lines > /home/runner/work/n

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-14 Thread via GitHub
eren-terzioglu commented on PR #16712: URL: https://github.com/apache/nuttx/pull/16712#issuecomment-3068384514 Thanks @acassis, updated. It fixed after rebase (refresh returned nothing again). -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] cmake: enhance the function of cmake nuttx_wildcard_sources [nuttx]

2025-07-14 Thread via GitHub
Junbo-Zheng commented on PR #16721: URL: https://github.com/apache/nuttx/pull/16721#issuecomment-3068425715 @xuxin930 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] cmake: enhance the function of cmake nuttx_wildcard_sources [nuttx]

2025-07-14 Thread via GitHub
Junbo-Zheng opened a new pull request, #16721: URL: https://github.com/apache/nuttx/pull/16721 ## Summary cmake: enhance the function of cmake nuttx_wildcard_sources align already used cmake ifdef/ifndef nuttx_xxx functions, reference: - https://github.com/apache/nuttx/pull/1

[PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
bl4kraven opened a new pull request, #16723: URL: https://github.com/apache/nuttx/pull/16723 Hi, Starting with esptool.py and espsecure.py v5.0.0, running esptool.py and espsecure.py pops up the warning: `Warning: DEPRECATED: 'esptool.py' is deprecated. Please use 'esptool' i

[PR] fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 [nuttx]

2025-07-14 Thread via GitHub
Donny9 opened a new pull request, #16722: URL: https://github.com/apache/nuttx/pull/16722 ## Summary fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 fs/dup: fix the issue about lost dup oflags in dup2 ## Impact bug fix

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
nuttxs commented on code in PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131#discussion_r2204495848 ## netutils/dhcpc/dhcpc.c: ## @@ -950,3 +968,107 @@ int dhcpc_request_async(FAR void *handle, dhcpc_callback_t callback) return OK; } + +/*

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-14 Thread via GitHub
acassis merged PR #16712: URL: https://github.com/apache/nuttx/pull/16712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

(nuttx) branch master updated (382d38b4e05 -> f9c25ecd695)

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 382d38b4e05 arm64/zynq-mpsoc: fix race condition in txint handler new 495936d16be boards/esp32-devkitc: Add match

(nuttx) 01/03: boards/esp32-devkitc: Add match4 defconfig for esp32

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 495936d16be5761c2c7dd8e91c02678dd6227293 Author: Eren Terzioglu AuthorDate: Sat Jul 5 18:02:29 2025 +0200 boards/es

(nuttx) 02/03: Docs/games: Add match4 game docs

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 447c50cbee1c771173f9d5bc01d5e9911ef3b1e0 Author: Eren Terzioglu AuthorDate: Sat Jul 5 18:07:42 2025 +0200 Docs/game

(nuttx) 03/03: Docs/xtensa: Add match4 game doc for esp32-devkitc

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f9c25ecd695b1471bfc2dc187c1757c23ecc9e5d Author: Eren Terzioglu AuthorDate: Sat Jul 5 18:10:13 2025 +0200 Docs/xten

Re: [PR] /drivers/sensors/nau7802: Added frequency control [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16717: URL: https://github.com/apache/nuttx/pull/16717#discussion_r2204732703 ## drivers/sensors/nau7802.c: ## @@ -124,20 +125,20 @@ static int nau7802_read_reg(FAR nau7802_dev_s *dev, uint8_t addr, void *buf, uint8_

Re: [PR] /drivers/sensors/nau7802: Added frequency control [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16717: URL: https://github.com/apache/nuttx/pull/16717#discussion_r2204732703 ## drivers/sensors/nau7802.c: ## @@ -124,20 +125,20 @@ static int nau7802_read_reg(FAR nau7802_dev_s *dev, uint8_t addr, void *buf, uint8_

Re: [I] [BUG] NXStyle is not catching brackets starting in the same line [nuttx]

2025-07-14 Thread via GitHub
acassis commented on issue #16367: URL: https://github.com/apache/nuttx/issues/16367#issuecomment-3069238602 also on nau7802 driver: ``` struct i2c_msg_s readcmd[2] = { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] arm64/qemu: decouple qemu board from chip [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16718: URL: https://github.com/apache/nuttx/pull/16718#discussion_r2204739577 ## arch/arm64/src/qemu/qemu_boot.c: ## @@ -179,7 +179,9 @@ void arm64_chip_boot(void) * configuration of board specific resources such as GPIOs, LEDs, etc. */

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
acassis commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069273846 @eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from ST site.

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
acassis commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069277411 > Hi, We are suggesting to use [esptool 4.8.dev4](https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile#L383C18-L383C35). We didn't tested tihs version of esptool c

Re: [PR] drivers/input: Create Single Button Multi Actions [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2204765011 ## include/nuttx/input/sbutton.h: ## @@ -0,0 +1,114 @@ +/ + * include/nuttx/input/sbutton.h

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
eren-terzioglu commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3068972840 Hi, We are suggesting to use [esptool 4.8.dev4](https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile#L383C18-L383C35). We didn't tested it completely and

Re: [PR] drivers/input: Create Single Button Multi Actions [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2204767893 ## Documentation/components/drivers/character/input/sbutton.rst: ## @@ -0,0 +1,41 @@ +== +Single Button Multi Actions Driver +==

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
eren-terzioglu commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069297046 > @eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from S

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
acassis commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069308331 > > @eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from ST sit

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
eren-terzioglu commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069308333 > > Hi, We are suggesting to use [esptool 4.8.dev4](https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile#L383C18-L383C35). We didn't tested tihs version of

Re: [PR] drivers/input: Create Single Button Multi Actions [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2204765011 ## include/nuttx/input/sbutton.h: ## @@ -0,0 +1,114 @@ +/ + * include/nuttx/input/sbutton.h

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
fdcavalcanti commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069305237 Please hold on for a second. Updating `esptool` to v5.0 requires other things to be taken into consideration: - Anyone still running older `esptool` will have build issues,

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
acassis commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069315474 @bl4kraven please consider @eren-terzioglu and @bl4kraven and if you can please help, after they confirm everything works, please help updating the Documentation. -- This is an automat

Re: [I] [BUG] NXStyle is not catching brackets starting in the same line [nuttx]

2025-07-14 Thread via GitHub
TimJTi commented on issue #16367: URL: https://github.com/apache/nuttx/issues/16367#issuecomment-3069316051 It's FUBAR!!! It even accepts this which has MANY style errors: ``` static int nau7802_read_reg(FAR nau7802_dev_s *dev, uint8_t addr, void *buf,

Re: [I] [BUG] NXStyle is not catching brackets starting in the same line [nuttx]

2025-07-14 Thread via GitHub
acassis commented on issue #16367: URL: https://github.com/apache/nuttx/issues/16367#issuecomment-3069324071 @TimJTi good question! I think it used to work in the past, because Greg implemented nxstyle to be consistent with the Coding Style guy, but we need to confirm it, for example downlo

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
TimJTi commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3070178018 @jingfei195887 - just trying to sort out a testing repo and get my board into a state to test this properly: might be tomorrow before I'm ready but I'm on it! -- This is an automated me

Re: [PR] examples/keyboard: Fix compilation warning [nuttx-apps]

2025-07-14 Thread via GitHub
lupyuen merged PR #3129: URL: https://github.com/apache/nuttx-apps/pull/3129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] arm64/qemu: decouple qemu board from chip [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16718: URL: https://github.com/apache/nuttx/pull/16718#discussion_r2205016041 ## arch/arm64/src/qemu/qemu_boot.c: ## @@ -179,7 +179,9 @@ void arm64_chip_boot(void) * configuration of board specific resources such as GPIOs, LEDs, etc. */

Re: [PR] netutils/nanopb: fix unpack step for MACOS [nuttx-apps]

2025-07-14 Thread via GitHub
acassis merged PR #3132: URL: https://github.com/apache/nuttx-apps/pull/3132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

(nuttx-apps) branch master updated: netutils/nanopb: fix unpack step for MACOS

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 227d3ec35 netutils/nanopb: fix unpack step

Re: [PR] netutils/dhcpc/dhcpc.c: Implement the interface to send DHCPRELEASE [nuttx-apps]

2025-07-14 Thread via GitHub
acassis merged PR #3131: URL: https://github.com/apache/nuttx-apps/pull/3131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

(nuttx-apps) branch master updated: netutils/dhcpc/dhcpc.c:Implement a dedicated interface to send DHCPRELEASE, According to RFC 2131 section 3.1, DHCPRELEASE is used by a client to relinquish a netwo

2025-07-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new dfeeef41e netutils/dhcpc/dhcpc.c:Implement

Re: [PR] examples/keyboard: Fix compilation warning [nuttx-apps]

2025-07-14 Thread via GitHub
acassis commented on PR #3129: URL: https://github.com/apache/nuttx-apps/pull/3129#issuecomment-3070950635 > @jerpelea why does rcims and simbit18 reviewing is not considered as "binding"? They are committers! Any idea? Don“t worry, I think they just need to add themselves to Apache F

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #16642: URL: https://github.com/apache/nuttx/pull/16642#discussion_r2205472677 ## boards/arm/stm32l4/stm32l476vg-disco/src/stm32_bringup.c: ## @@ -231,31 +228,19 @@ int stm32_bringup(void) } #else /* if defined(HAVE_N25QXXX_CH

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3070438466 Fix the documentation build warning: ``` Warning, treated as error: /home/runner/work/nuttx/nuttx/Documentation/components/drivers/special/mtd.rst:185:Title level inconsi

Re: [PR] examples/keyboard: Fix compilation warning [nuttx-apps]

2025-07-14 Thread via GitHub
acassis commented on PR #3129: URL: https://github.com/apache/nuttx-apps/pull/3129#issuecomment-3070446910 @jerpelea why does rcims and simbit18 reviewing is not considered as "binding"? They are committers! Any idea? -- This is an automated message from the Apache Git Service. To respond

(nuttx) branch master updated: tools/espressif: Add risc-v compiler info dump for Espressif devices

2025-07-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 30a567453cf tools/espressif: Add risc-v compil

Re: [PR] /drivers/sensors/nau7802: Added frequency control [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #16717: URL: https://github.com/apache/nuttx/pull/16717#discussion_r2205485451 ## drivers/sensors/nau7802.c: ## @@ -89,7 +89,7 @@ /* ODR to Interval */ static const uint32_t ODR_TO_INTERVAL[] = -{ + { Review Comment: why change

Re: [PR] tools/espressif: Add risc-v compiler info dump for Espressif devices [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 merged PR #16724: URL: https://github.com/apache/nuttx/pull/16724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] cmake: enhance the function of cmake nuttx_wildcard_sources [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 merged PR #16721: URL: https://github.com/apache/nuttx/pull/16721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: cmake: enhance the function of cmake nuttx_wildcard_sources

2025-07-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a88eb1fc6b2 cmake: enhance the function of cma

Re: [I] [BUG] NXStyle is not catching brackets starting in the same line [nuttx]

2025-07-14 Thread via GitHub
acassis commented on issue #16367: URL: https://github.com/apache/nuttx/issues/16367#issuecomment-3069380469 @TimJTi I downloaded NuttX 9.1 and noticed it also wasn't able to detect the issue, you are right, it is "FUBAR" ``` alan@dev:/tmp/patacongo-nuttx-e4e4cce69624/tools$ ./nxst

Re: [PR] tools: Fix esptool.py and espsecure.py warnning [nuttx]

2025-07-14 Thread via GitHub
bl4kraven commented on PR #16723: URL: https://github.com/apache/nuttx/pull/16723#issuecomment-3069609719 OK, if everything test ok, i will update the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 [nuttx]

2025-07-14 Thread via GitHub
TimJTi commented on PR #16722: URL: https://github.com/apache/nuttx/pull/16722#issuecomment-3070657228 What issue? When does it happen? How did you find it? Is there a related issue that can be linked to? A fix is great but I don't see context to see if it something that might explai

Re: [PR] drivers/analog/ads1115.h: Add ioctl for conversion trigger [nuttx]

2025-07-14 Thread via GitHub
linguini1 merged PR #16715: URL: https://github.com/apache/nuttx/pull/16715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

(nuttx) 02/02: docs/ads1115: Add trigger commands to documentation

2025-07-14 Thread linguini
This is an automated email from the ASF dual-hosted git repository. linguini pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 953ab4e2879d97d53a4aa1b36ad7932046d48373 Author: Matteo Golin AuthorDate: Fri Jul 11 15:53:18 2025 -0400 docs/ads1

(nuttx) 01/02: drivers/analog/ads1115.h: Add ioctl for conversion trigger

2025-07-14 Thread linguini
This is an automated email from the ASF dual-hosted git repository. linguini pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4030eb892eda9ac7b40bd02538d2983061965994 Author: Daniel Byshkin AuthorDate: Fri Jul 4 15:20:45 2025 -0400 drivers/

(nuttx) branch master updated (a88eb1fc6b2 -> 953ab4e2879)

2025-07-14 Thread linguini
This is an automated email from the ASF dual-hosted git repository. linguini pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a88eb1fc6b2 cmake: enhance the function of cmake nuttx_wildcard_sources new 4030eb892ed drivers/analog/ads1115.h

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
TimJTi commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3070260915 > just trying to sort out a testing repo and get my board into a state to test this properly: might be tomorrow before I'm ready but I'm on it! @jingfei195887 - Have it running on m

Re: [PR] fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 [nuttx]

2025-07-14 Thread via GitHub
acassis commented on code in PR #16722: URL: https://github.com/apache/nuttx/pull/16722#discussion_r2205505405 ## fs/driver/fs_blockproxy.c: ## @@ -148,6 +148,7 @@ static FAR char *unique_chardev(void) int block_proxy(FAR struct file *filep, FAR const char *blkdev, int oflags)

Re: [PR] examples/keyboard: Fix compilation warning [nuttx-apps]

2025-07-14 Thread via GitHub
lupyuen commented on PR #3129: URL: https://github.com/apache/nuttx-apps/pull/3129#issuecomment-3071243582 @rcsim and @simbit18: After ASF has created your Committer ID, could you click this to link your GitBox and GitHub Accounts? Thanks https://gitbox.apache.org/boxer/ https:

(nuttx) branch master updated: /drivers/sensors/nau7802: Added frequency control

2025-07-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c51f749f9ab /drivers/sensors/nau7802: Added fr

Re: [PR] /drivers/sensors/nau7802: Added frequency control [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 merged PR #16717: URL: https://github.com/apache/nuttx/pull/16717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-14 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3071836573 @michallenc @acassis @cederom @TimJTi this pr is ready for merging now, please review again. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 [nuttx]

2025-07-14 Thread via GitHub
Donny9 commented on PR #16722: URL: https://github.com/apache/nuttx/pull/16722#issuecomment-3071900921 > What issue? When does it happen? How did you find it? Is there a related issue that can be linked to? > > A fix is great but I don't see context to see if it something that might

Re: [PR] fs/block_proxy: fix the issue of the refs count for filep being zeroed out by utilizing dup2 [nuttx]

2025-07-14 Thread via GitHub
Donny9 commented on code in PR #16722: URL: https://github.com/apache/nuttx/pull/16722#discussion_r2206451587 ## fs/driver/fs_blockproxy.c: ## @@ -148,6 +148,7 @@ static FAR char *unique_chardev(void) int block_proxy(FAR struct file *filep, FAR const char *blkdev, int oflags)