acassis commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2204765011
########## include/nuttx/input/sbutton.h: ########## @@ -0,0 +1,114 @@ +/**************************************************************************** + * include/nuttx/input/sbutton.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/* The single button driver exports a standard character driver interface. By + * convention, the driver is exposed as /dev/sbtn[n] and works like a common + * keyboard device, but generates only INPUT_TAB and INPUT_ENTER events. + */ + +#ifndef __INCLUDE_NUTTX_INPUT_SBUTTON_H +#define __INCLUDE_NUTTX_INPUT_SBUTTON_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/i2c/i2c_master.h> +#include <stdbool.h> +#include <nuttx/irq.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* A reference to a structure of this type must be passed to the + * single button keyboard driver. This structure provides information + * about the configuration and provides some board-specific hooks. + */ + +struct sbutton_config_s Review Comment: Because the timing to detect pressed key will not work. In an i2c ioexpander we need extra steps to figure out which key as pressed, etc, to get it working correctly. I suggest keeping it for GPIO for simplicity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
