acassis commented on code in PR #16718:
URL: https://github.com/apache/nuttx/pull/16718#discussion_r2205016041
##########
arch/arm64/src/qemu/qemu_boot.c:
##########
@@ -179,7 +179,9 @@ void arm64_chip_boot(void)
* configuration of board specific resources such as GPIOs, LEDs, etc.
*/
Review Comment:
Yes, I saw that comment, but it still confuse for a person reading it in the
future:
```
/* Perform board-specific device initialization. This would include
* configuration of board specific resources such as GPIOs, LEDs, etc.
*/
```
Why only if CONFIG_ARCH_BOARD_QEMU_ARMV8A is defined? I only know it because
you explained in the Testing here.
Maybe using:
```
#ifndef CONFIG_ARCH_BOARD_CUSTOM
```
Could be easier to follow, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
