Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
acassis commented on PR #16714: URL: https://github.com/apache/nuttx/pull/16714#issuecomment-3063896890 @simbit18 what is this build issue on msvc ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] boards/qemu-armv8a: Add `xedge` example program and documentation [nuttx]

2025-07-11 Thread via GitHub
acassis commented on PR #16665: URL: https://github.com/apache/nuttx/pull/16665#issuecomment-3062662565 @JorgeGzm it is failing: ``` /home/runner/work/nuttx/nuttx/Documentation/applications/examples/xedge_demo/index.rst:2:Title underline too short. ``` Please run "make html"

Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]

2025-07-11 Thread via GitHub
keever50 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3063335519 I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
Laczen commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3060898031 @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. If I am correct the ftl layer creates a block device on top of a mtd, but b

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-11 Thread via GitHub
eren-terzioglu commented on PR #16712: URL: https://github.com/apache/nuttx/pull/16712#issuecomment-3061976055 > Thank you @eren-terzioglu :-) Could you also please add the wiring diagram to the docs? :-) I did on Espressif Docs -- This is an automated message from the Apache Git S

Re: [PR] boards/arm/stm32f401rc-rs485: Add support to HX711 ADC [nuttx]

2025-07-11 Thread via GitHub
rcsim commented on code in PR #16707: URL: https://github.com/apache/nuttx/pull/16707#discussion_r2200528881 ## boards/arm/stm32/stm32f401rc-rs485/src/stm32_bringup.c: ## @@ -211,7 +211,7 @@ int stm32_bringup(void) } #endif -#ifdef CONFIG_ADC +#ifdef CONFIG_STM32_ADC1 R

Re: [I] [FEATURE] CAN and CAN FD bittiming/bitrate calculation consolidation and CAN drivers updates goals [nuttx]

2025-07-11 Thread via GitHub
michallenc commented on issue #15567: URL: https://github.com/apache/nuttx/issues/15567#issuecomment-3061671277 Hi @raiden00pl @ppisa @acassis. Looking at this after some time, the design I would propose is following. **File location** - `drivers/can/can_bittiming.c` as a C file wi

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3061127566 > I replaced `ftl_initialize` and `bchdev_register` with `register_mtddriver` call, but it seems all data are now written to a pseudofile in RAM memory, not to the physical device.

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3061700120 > @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. > > If I am correct the ftl layer creates a block device on top of

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
michallenc commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3061034230 I replaced `ftl_initialize` and `bchdev_register` with `register_mtddriver` call, but it seems all data are now written to a pseudofile in RAM memory, not to the physical device. I did

[PR] Docs/games: Add match4 game docs [nuttx]

2025-07-11 Thread via GitHub
eren-terzioglu opened a new pull request, #16712: URL: https://github.com/apache/nuttx/pull/16712 ## Summary Add match4 game docs and configs for demo purposes. Currently, game requires 8x8 led matrix (or serial output can be used when debug option enabled) and buttons/console input.

[PR] Games: Add match4 game [nuttx-apps]

2025-07-11 Thread via GitHub
eren-terzioglu opened a new pull request, #3125: URL: https://github.com/apache/nuttx-apps/pull/3125 ## Summary Related to https://github.com/apache/nuttx/pull/16712 Add match4 game for demo purposes. Currently, game requires 8x8 led matrix (or serial output can be used when de

Re: [PR] Games: Add match4 game [nuttx-apps]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #3125: URL: https://github.com/apache/nuttx-apps/pull/3125#discussion_r2200542440 ## games/match4/Kconfig: ## @@ -0,0 +1,84 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the Nu

[PR] games/snake: Fix terminal issue after returning back from snake game [nuttx-apps]

2025-07-11 Thread via GitHub
eren-terzioglu opened a new pull request, #3126: URL: https://github.com/apache/nuttx-apps/pull/3126 ## Summary When snake game with `GAMES_SNAKE_USE_CONSOLEKEY` option enabled, nsh crashes after returning from the game. This PR fixes the issue - games/snake: Fix terminal issue aft

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #16673: URL: https://github.com/apache/nuttx/pull/16673#discussion_r2200653652 ## sched/sched/sched_setpriority.c: ## @@ -223,29 +230,30 @@ static inline void nxsched_running_setpriority(FAR struct tcb_s *tcb, /* A context swit

Re: [PR] sched: Fix smp scheduling [nuttx]

2025-07-11 Thread via GitHub
jlaitine commented on PR #16673: URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3062231927 I am converting this back to draft, I don't have currently time to continue on this. Will come back to this later -- This is an automated message from the Apache Git Service. To

Re: [PR] Arm32 v8m support cmake clang compile [nuttx]

2025-07-11 Thread via GitHub
W-M-R commented on PR #16627: URL: https://github.com/apache/nuttx/pull/16627#issuecomment-3060934869 > @W-M-R please fix the build break. OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] toolchain/arm: Fix crash caused by clang compiling with -mfpu=fpv5-d16 and -march=armv8.1-m.main+mve.fp+fp.dp [nuttx]

2025-07-11 Thread via GitHub
W-M-R opened a new pull request, #16711: URL: https://github.com/apache/nuttx/pull/16711 ## Summary The above combination of compilation causes the compiler to crash: #1 0x01fbe154 llvm::sys::CleanupOnSignal(unsigned long) (clang18/bin/clang-19+0x1fbe154) #2 0x

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
michallenc commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3061900079 > > I replaced `ftl_initialize` and `bchdev_register` with `register_mtddriver` call, but it seems all data are now written to a pseudofile in RAM memory, not to the physical device. I

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-11 Thread via GitHub
eren-terzioglu commented on PR #16712: URL: https://github.com/apache/nuttx/pull/16712#issuecomment-3061955327 It fails due to didn't merge https://github.com/apache/nuttx-apps/pull/3125 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Games: Add match4 game [nuttx-apps]

2025-07-11 Thread via GitHub
acassis commented on code in PR #3125: URL: https://github.com/apache/nuttx-apps/pull/3125#discussion_r2200555908 ## games/match4/match4_input_console.h: ## @@ -0,0 +1,240 @@ +/ + * apps/games/match4/mat

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
Laczen commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062097984 > > @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. > > If I am correct the ftl layer creates a block device on top of a mtd, b

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062199926 > > > @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. > > > If I am correct the ftl layer creates a block device on top

Re: [PR] games/snake: Fix terminal issue after returning back from snake game [nuttx-apps]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #3126: URL: https://github.com/apache/nuttx-apps/pull/3126#discussion_r2200558367 ## games/snake/snake_input_console.h: ## @@ -63,6 +63,27 @@ void init_termios(int echo) fcntl(STDIN_FILENO, F_SETFL, O_NONBLOCK); /* set non-blocking mod

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-11 Thread via GitHub
acassis commented on PR #16712: URL: https://github.com/apache/nuttx/pull/16712#issuecomment-3062059572 @eren-terzioglu please normalize your board config: ``` [1/1] Normalize ttgo_t_display_esp32/lvgl_fb HEAD detached at pull/16712/merge Changes not staged for commit:

(nuttx) branch master updated (7abfbddb2f1 -> ae70e09810c)

2025-07-11 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7abfbddb2f1 Add additional support for STM32H5 ADC add ae70e09810c toolchain/arm: Fix link parameter error No ne

Re: [PR] Docs/games: Add match4 game docs [nuttx]

2025-07-11 Thread via GitHub
eren-terzioglu commented on PR #16712: URL: https://github.com/apache/nuttx/pull/16712#issuecomment-3062065088 > @eren-terzioglu please normalize your board config: > > ``` > [1/1] Normalize ttgo_t_display_esp32/lvgl_fb > HEAD detached at pull/16712/merge > Changes not stage

Re: [PR] toolchain/arm: Fix link parameter error [nuttx]

2025-07-11 Thread via GitHub
acassis merged PR #16709: URL: https://github.com/apache/nuttx/pull/16709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] toolchain/arm: Fix crash caused by clang compiling with -mfpu=fpv5-d16 and -march=armv8.1-m.main+mve.fp+fp.dp [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 merged PR #16711: URL: https://github.com/apache/nuttx/pull/16711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: arm/clang: Fix crash caused by clang compiling with -mfpu=fpv5-d16 and -march=armv8.1-m.main+mve.fp+fp.dp

2025-07-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 51a82d52890 arm/clang: Fix crash caused by cla

Re: [PR] games/snake: Fix terminal issue after returning back from snake game [nuttx-apps]

2025-07-11 Thread via GitHub
eren-terzioglu commented on PR #3126: URL: https://github.com/apache/nuttx-apps/pull/3126#issuecomment-3062177185 Thanks @xiaoxiang781216, updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Games: Add match4 game [nuttx-apps]

2025-07-11 Thread via GitHub
eren-terzioglu commented on PR #3125: URL: https://github.com/apache/nuttx-apps/pull/3125#issuecomment-3062179629 Thanks @xiaoxiang781216, @acassis updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
Laczen commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062250152 > > > > @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. > > > > If I am correct the ftl layer creates a block device on top of a

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062360609 > > > > > @jingfei195887 @xiaoxiang781216 is the moving of `ftl_initialize` out of the board files really required. > > > > > If I am correct the ftl layer creates a block device

Re: [PR] drivers/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
jingfei195887 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062379354 @michallenc I've reviewed your code and haven't found any obvious errors for now. Are you available or free at the moment? Maybe we could conduct an online debugging session togethe

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3062542397 > I replaced `ftl_initialize` and `bchdev_register` with `register_mtddriver` call, but it seems all data are now written to a pseudofile in RAM memory, not to the physical device

Re: [PR] examples/xedge: Add Xedge example with BAS integration [nuttx-apps]

2025-07-11 Thread via GitHub
JorgeGzm commented on PR #3120: URL: https://github.com/apache/nuttx-apps/pull/3120#issuecomment-3062818031 @xiaoxiang781216 @cederom I have split the project into two separate paths and updated all the documentation accordingly. However, I have encountered a new issue: when I

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201994030 ## boards/arm/stm32/common/src/stm32_sbutton.c: ## @@ -0,0 +1,182 @@ +/ + * boards/arm/stm

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201998811 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]

2025-07-11 Thread via GitHub
cederom commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3064077935 Thanks @keever50 :-) Only sources needs to be added no application code? :-) CI failed for some reason, restarted :-) -- This is an automated message from the Apache Git Servic

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
acassis commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2202017817 ## drivers/input/Kconfig: ## @@ -622,6 +622,25 @@ config INPUT_BUTTONS_NPOLLWAITERS endif # INPUT_BUTTONS +config INPUT_SBUTTON Review Comment: Good idea! Than

Re: [PR] drivers/analog/ads1115.h: Add ioctl for conversion trigger [nuttx]

2025-07-11 Thread via GitHub
linguini1 commented on PR #16715: URL: https://github.com/apache/nuttx/pull/16715#issuecomment-3064122784 I don't believe the build failure is a result of these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] libc/idr: Fix Use-After-Free during idr_destroy() [nuttx]

2025-07-11 Thread via GitHub
gpoulios opened a new pull request, #16713: URL: https://github.com/apache/nuttx/pull/16713 ## Summary libc lib_idr maintains 2 RB trees to efficiently handle node allocations. Removed nodes are not freed, but rather added to the "removed" RB tree, for potential re-use during subsequ

[PR] Add JPEG compressor support to Makefile [nuttx-apps]

2025-07-11 Thread via GitHub
keever50 opened a new pull request, #3127: URL: https://github.com/apache/nuttx-apps/pull/3127 ## Summary This PR adds the required JPEG compressor files to the Makefile. Before this PR, the Makefile contained only the required decompressor files. ## Impact Users can n

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201944736 ## boards/arm/stm32/common/src/stm32_sbutton.c: ## @@ -0,0 +1,182 @@ +/ + * boards/arm/stm

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201953038 ## boards/arm/stm32/stm32f4discovery/src/stm32_bringup.c: ## @@ -452,6 +456,16 @@ int stm32_bringup(void) } #endif +#ifdef CONFIG_INPUT_SBUTTON + /* Register

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201953562 ## boards/arm/stm32/stm32f4discovery/src/stm32_bringup.c: ## @@ -452,6 +456,16 @@ int stm32_bringup(void) } #endif +#ifdef CONFIG_INPUT_SBUTTON + /* Register

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201954298 ## drivers/input/Kconfig: ## @@ -622,6 +622,25 @@ config INPUT_BUTTONS_NPOLLWAITERS endif # INPUT_BUTTONS +config INPUT_SBUTTON Review Comment: Maybe add `KE

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201949834 ## boards/arm/stm32/stm32f4discovery/configs/sbutton/defconfig: ## @@ -0,0 +1,56 @@ +# Review Comment: Shouldn't this defconfig define an absolute minimum needed

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201961117 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201961951 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201968023 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201974466 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201972568 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201978076 ## include/nuttx/input/sbutton.h: ## @@ -0,0 +1,114 @@ +/ + * include/nuttx/input/sbutton.

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201989924 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201985547 ## drivers/input/sbutton.c: ## @@ -0,0 +1,269 @@ +/ + * drivers/input/sbutton.c + * + * SP

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201981820 ## include/nuttx/input/sbutton.h: ## @@ -0,0 +1,114 @@ +/ + * include/nuttx/input/sbutton.

[PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
acassis opened a new pull request, #16714: URL: https://github.com/apache/nuttx/pull/16714 ## Summary This commit creates a sbutton device that uses a single button to create a keyboard driver that returns TAB or ENTER depending how long the user keeps the button pressed. ## I

[PR] drivers/analog/ads1115.h: Add ioctl for conversion trigger [nuttx]

2025-07-11 Thread via GitHub
linguini1 opened a new pull request, #16715: URL: https://github.com/apache/nuttx/pull/16715 ## Summary Since the ADS1115 has a relatively slow conversion rate, this additional ioctl command makes it possible to trigger a conversion before reading the reading the conversion result, a

(nuttx) branch master updated: boards/arm/stm32f401rc-rs485: Add support to HX711 ADC

2025-07-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 95c9525c0d5 boards/arm/stm32f401rc-rs485: Add

Re: [PR] boards/arm/stm32f401rc-rs485: Add support to HX711 ADC [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 merged PR #16707: URL: https://github.com/apache/nuttx/pull/16707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] libc/idr: Fix Use-After-Free during idr_destroy() [nuttx]

2025-07-11 Thread via GitHub
Donny9 merged PR #16713: URL: https://github.com/apache/nuttx/pull/16713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

(nuttx) branch master updated: libc/idr: Remove nodes from RB trees during destroy

2025-07-11 Thread jiuzhudong
This is an automated email from the ASF dual-hosted git repository. jiuzhudong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c4541a4d4c6 libc/idr: Remove nodes from RB tr

Re: [PR] graphics/libjpeg: Add JPEG compressor support to Makefile [nuttx-apps]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on PR #3127: URL: https://github.com/apache/nuttx-apps/pull/3127#issuecomment-3064672968 > I can clean up the JPEG resize tool and share it with NuttX as well if we think this is nice to have yes, I think it's useful tool and demo. -- This is an automated

Re: [PR] drivers/mtd/ftl/bch: Add direct writing method for FTL [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on PR #16642: URL: https://github.com/apache/nuttx/pull/16642#issuecomment-3064674049 @jingfei195887 please fix this error: ``` Configuration/Tool: sama5d4-ek/at25boot,CONF

Re: [PR] drivers/analog/ads1115.h: Add ioctl for conversion trigger [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #16715: URL: https://github.com/apache/nuttx/pull/16715#discussion_r2202317940 ## drivers/analog/ads1115.c: ## @@ -47,28 +46,32 @@ * Preprocessor definitions /

Re: [PR] drivers/input: Create Single Button Dual Action [nuttx]

2025-07-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2202322726 ## include/nuttx/input/sbutton.h: ## @@ -0,0 +1,114 @@ +/ + * include/nuttx/input/sb