mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201949834
########## boards/arm/stm32/stm32f4discovery/configs/sbutton/defconfig: ########## @@ -0,0 +1,56 @@ +# Review Comment: Shouldn't this defconfig define an absolute minimum needed for sbutton to work? Also, was it indeed generated with `make savedefconfig`? I would expect entries like `CONFIG_RAM_START=0x20000000` to be defined in default value so it should not be present here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
