mlyszczek commented on code in PR #16714: URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201972568
########## drivers/input/sbutton.c: ########## @@ -0,0 +1,269 @@ +/**************************************************************************** + * drivers/input/sbutton.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdbool.h> +#include <stdio.h> +#include <assert.h> +#include <debug.h> +#include <errno.h> +#include <poll.h> +#include <fcntl.h> + +#include <nuttx/input/sbutton.h> +#include <nuttx/fs/fs.h> +#include <nuttx/clock.h> +#include <nuttx/ascii.h> +#include <nuttx/kmalloc.h> +#include <nuttx/mutex.h> +#include <nuttx/wqueue.h> +#include <nuttx/semaphore.h> +#include <nuttx/input/keyboard.h> +#include <nuttx/input/kbd_codec.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* This format is used to construct the /dev/kbd[n] device driver path. It + * defined here so that it will be used consistently in all places. + */ + +#define DEV_FORMAT "/dev/kbd%d" +#define DEV_NAMELEN 11 Review Comment: With size of array being 11, you can only fit `/dev/kbd{0..99}` while minor can go up to 127. This would be truncated if someone gets crazy enough to create 100+ of those devices and it would result in node leak. Should be 12 to be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
