[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on PR #8000: URL: https://github.com/apache/nuttx/pull/8000#issuecomment-1368770047 > Here I must disagree. You definitely need to change these, since they currently look like this: > > ``` > > NULL, /* write */ >NULL,

[GitHub] [nuttx] pussuw commented on pull request #7997: sched: group: Fix memory corruption in group_leave.c

pussuw commented on PR #7997: URL: https://github.com/apache/nuttx/pull/7997#issuecomment-1368769858 @masayuki2009 Thank you so much for fixing this crash! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059910325 ## drivers/video/fb.c: ## @@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mmap(FAR s

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059910784 ## drivers/video/video.c: ## @@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int video_mma

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059911537 ## include/nuttx/fs/fs.h: ## @@ -284,7 +292,7 @@ struct mountpt_operations * information to manage privileges. */ - int (*open)(FAR struct file *filep, FA

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059911646 ## include/nuttx/fs/fs.h: ## @@ -295,9 +303,14 @@ struct mountpt_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR c

[GitHub] [nuttx] jlaitine commented on pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on PR #8000: URL: https://github.com/apache/nuttx/pull/8000#issuecomment-1368772747 > > Here I must disagree. You definitely need to change these, since they currently look like this: > > ``` > > > > NULL, /* write */ > >NULL,

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059914130 ## drivers/video/fb.c: ## @@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mma

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059914671 ## drivers/video/video.c: ## @@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int vi

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059915845 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059915845 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059918554 ## include/nuttx/fs/fs.h: ## @@ -206,16 +207,21 @@ struct file_operations * treated like unions. */ - int (*close)(FAR struct file *filep); - ssiz

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059921233 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059922840 ## include/nuttx/fs/fs.h: ## @@ -206,16 +207,21 @@ struct file_operations * treated like unions. */ - int (*close)(FAR struct file *filep); - ssize_t (*r

[GitHub] [nuttx] pussuw commented on pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on PR #7966: URL: https://github.com/apache/nuttx/pull/7966#issuecomment-1368803076 @masayuki2009 hello and happy new year! I have been testing with qemu / sabre-6quad and can not see any more issues. The test is obviously very limited i.e. manually running getprime() which

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059939614 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + *

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059945714 ## drivers/video/fb.c: ## @@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mmap(FAR s

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059945863 ## drivers/video/video.c: ## @@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int video_mma

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059948369 ## drivers/video/video.c: ## @@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int video_mma

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059949821 ## include/nuttx/fs/fs.h: ## @@ -206,16 +207,21 @@ struct file_operations * treated like unions. */ - int (*close)(FAR struct file *filep); - ssiz

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059949821 ## include/nuttx/fs/fs.h: ## @@ -206,16 +207,21 @@ struct file_operations * treated like unions. */ - int (*close)(FAR struct file *filep); - ssiz

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059950488 ## drivers/video/fb.c: ## @@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mma

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059951606 ## drivers/video/video.c: ## @@ -3200,6 +3198,22 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int vi

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059915845 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059943209 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + *

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on PR #8000: URL: https://github.com/apache/nuttx/pull/8000#issuecomment-1368830689 @jlaitine please rebase your change to the last master, all ci broken is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059957579 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059958464 ## include/nuttx/fs/fs.h: ## @@ -298,6 +305,11 @@ struct mountpt_operations size_t buflen); off_t (*seek)(FAR struct file *filep, off_t offset, int whe

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059958464 ## include/nuttx/fs/fs.h: ## @@ -298,6 +305,11 @@ struct mountpt_operations size_t buflen); off_t (*seek)(FAR struct file *filep, off_t offset, int whe

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059959537 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + *

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059957579 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059960988 ## include/nuttx/fs/fs.h: ## @@ -298,6 +305,11 @@ struct mountpt_operations size_t buflen); off_t (*seek)(FAR struct file *filep, off_t offset,

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059962513 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR cha

[GitHub] [nuttx] masayuki2009 commented on pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

masayuki2009 commented on PR #7966: URL: https://github.com/apache/nuttx/pull/7966#issuecomment-1368845626 @pussuw Happy New Year! And, thanks for fixing the crash with sabre-6quad on QEMU. I've just confirmed the PR works with both sabre-6quad (ARMv7-A) and rv-virt (RISC-V RV64).

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

xiaoxiang781216 commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059963499 ## include/nuttx/sched.h: ## @@ -1054,6 +1058,30 @@ FAR struct task_tcb_s *nxtask_setup_vfork(start_t retaddr); pid_t nxtask_start_vfork(FAR struct task_tcb_s *

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…

Gary-Hobson commented on code in PR #8008: URL: https://github.com/apache/nuttx/pull/8008#discussion_r1059966193 ## libs/libc/stream/lib_syslogstream.c: ## @@ -218,11 +218,6 @@ void lib_syslogstream_close(FAR struct lib_syslogstream_s *stream) { DEBUGASSERT(stream != NULL);

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8016: Remove the unnecessary NULL fields in global instance definition of file_operations

xiaoxiang781216 commented on PR #8016: URL: https://github.com/apache/nuttx/pull/8016#issuecomment-1368856924 @acassis could you merge this PR? https://github.com/apache/nuttx/pull/8000 depends on this. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059979216 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR cha

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059980713 ## include/nuttx/sched.h: ## @@ -1054,6 +1058,30 @@ FAR struct task_tcb_s *nxtask_setup_vfork(start_t retaddr); pid_t nxtask_start_vfork(FAR struct task_tcb_s *child);

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059981224 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059981767 ## sched/group/group.h: ## @@ -80,6 +69,7 @@ int group_bind(FAR struct pthread_tcb_s *tcb); int group_join(FAR struct pthread_tcb_s *tcb); #endif void group_leave(FAR

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059982065 ## sched/group/group.h: ## @@ -80,6 +69,7 @@ int group_bind(FAR struct pthread_tcb_s *tcb); int group_join(FAR struct pthread_tcb_s *tcb); #endif void group_leave(FAR

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059982843 ## sched/group/group_leave.c: ## @@ -408,3 +376,66 @@ void group_leave(FAR struct tcb_s *tcb) } #endif /* HAVE_GROUP_MEMBERS */ + +/***

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059984109 ## include/nuttx/sched.h: ## @@ -525,6 +526,9 @@ struct tcb_s /* Task Group */ +#ifdef CONFIG_ARCH_ADDRE

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7984: register sysview to note drivers list

Gary-Hobson commented on code in PR #7984: URL: https://github.com/apache/nuttx/pull/7984#discussion_r1059990402 ## drivers/segger/sysview.c: ## @@ -365,63 +255,33 @@ void sched_note_irqhandler(int irq, FAR void *handler, bool enter) } } - g_sysview

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7994: drivers/note: unify the spinlock operation in noteram

Gary-Hobson commented on code in PR #7994: URL: https://github.com/apache/nuttx/pull/7994#discussion_r1059994074 ## drivers/note/noteram_driver.c: ## @@ -94,9 +94,7 @@ static const struct note_driver_ops_s g_noteram_ops = noteram_add }; -#ifdef CONFIG_SMP static volatile

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r106941 ## fs/romfs/fs_romfs.c: ## @@ -617,6 +608,35 @@ static int romfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return -ENOTTY; } +static int romfs

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060001619 ## fs/tmpfs/fs_tmpfs.c: ## @@ -1640,38 +1643,27 @@ static off_t tmpfs_seek(FAR struct file *filep, off_t offset, int whence) return position; } -/

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060002503 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060003793 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060003952 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060004134 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060004770 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep,

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060005157 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR cha

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060005589 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + *

[GitHub] [nuttx] pussuw commented on pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on PR #7966: URL: https://github.com/apache/nuttx/pull/7966#issuecomment-1368913793 I changed HPWORK -> LPWORK because releasing the address environment that is no longer in use is not that timing critical. -- This is an automated message from the Apache Git Service. To r

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060006043 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h Re

[GitHub] [nuttx] pussuw commented on a diff in pull request #7966: group/addrenv: Fix the removal of address environments when a process exits

pussuw commented on code in PR #7966: URL: https://github.com/apache/nuttx/pull/7966#discussion_r1059984109 ## include/nuttx/sched.h: ## @@ -525,6 +526,9 @@ struct tcb_s /* Task Group */ +#ifdef CONFIG_ARCH_ADDRE

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8009: arm64/a64: add driver for Allwinner A64 I2C bus

xiaoxiang781216 commented on code in PR #8009: URL: https://github.com/apache/nuttx/pull/8009#discussion_r1060013555 ## drivers/sensors/mpu60x0.c: ## @@ -404,7 +404,7 @@ static int __mpu_read_reg_i2c(FAR struct mpu_dev_s *dev, msg[0].frequency = CONFIG_MPU60X0_I2C_FREQ; ms

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8012: optimize syslog speed

Gary-Hobson commented on code in PR #8012: URL: https://github.com/apache/nuttx/pull/8012#discussion_r1060016772 ## drivers/syslog/vsyslog.c: ## @@ -67,6 +67,8 @@ static FAR const char * g_priority_str[] = int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap)

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8012: optimize syslog speed

Gary-Hobson commented on code in PR #8012: URL: https://github.com/apache/nuttx/pull/8012#discussion_r1060016883 ## libs/libc/stream/lib_syslogstream.c: ## @@ -103,6 +102,37 @@ static void syslogstream_addchar(FAR struct lib_syslogstream_s *stream, syslogstream_flush(str

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8012: optimize syslog speed

Gary-Hobson commented on code in PR #8012: URL: https://github.com/apache/nuttx/pull/8012#discussion_r1060019335 ## drivers/syslog/vsyslog.c: ## @@ -128,7 +130,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #if defined(CONFIG_SYSLOG_COLOR_OUTPUT)

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060025670 ## include/nuttx/fs/fs.h: ## @@ -209,13 +211,19 @@ struct file_operations int (*close)(FAR struct file *filep); ssize_t (*read)(FAR struct file *filep, FAR cha

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060020579 ## drivers/video/fb.c: ## @@ -39,6 +39,7 @@ #include #include #include +#include Review Comment: should we include it in nuttx/fs/fs.h? ## d

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060025859 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,83 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060026586 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h Review Co

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060022089 ## drivers/video/video.c: ## @@ -3200,6 +3198,21 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int vi

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060027159 ## drivers/video/video.c: ## @@ -3200,6 +3198,21 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int vi

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060029569 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h + *

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8008: syslog: fix extra line breaks in syslog when SYSLOG_COLOR_OUTPUT is e…

xiaoxiang781216 merged PR #8008: URL: https://github.com/apache/nuttx/pull/8008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (a4ca15aa3e -> 275b2e70a4)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a4ca15aa3e CI/Documentation: livereload hash missmatch due to new wheel package upload. add 275b2e70a4 syslog:

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060032244 ## include/nuttx/fs/fs.h: ## @@ -300,6 +302,7 @@ struct mountpt_operations off_t (*seek)(FAR struct file *filep, off_t offset, int whence); int (*ioct

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060032593 ## include/nuttx/fs/fs.h: ## @@ -169,6 +169,7 @@ struct stat; struct statfs; struct pollfd; struct mtd_dev_s; +struct mm_map_entry_s; Review Comment: remov

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060032972 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h Re

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060033812 ## fs/tmpfs/fs_tmpfs.c: ## @@ -36,6 +36,7 @@ #include #include #include +#include Review Comment: remove -- This is an automated message from the A

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060034528 ## fs/tmpfs/fs_tmpfs.c: ## @@ -1658,20 +1656,13 @@ static int tmpfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) DEBUGASSERT(tfo != NULL); -

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060035436 ## fs/romfs/fs_romfs.c: ## @@ -40,6 +41,7 @@ #include #include #include +#include Review Comment: remove -- This is an automated message from the A

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060035672 ## fs/romfs/fs_romfs.c: ## @@ -578,9 +582,7 @@ static off_t romfs_seek(FAR struct file *filep, off_t offset, int whence) static int romfs_ioctl(FAR struct fil

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060036424 ## fs/romfs/fs_romfs.c: ## @@ -578,9 +582,7 @@ static off_t romfs_seek(FAR struct file *filep, off_t offset, int whence) static int romfs_ioctl(FAR struct file *file

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060039139 ## fs/romfs/fs_romfs.c: ## @@ -618,6 +608,34 @@ static int romfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return -ENOTTY; } +static int ro

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060039403 ## fs/romfs/fs_romfs.c: ## @@ -27,6 +27,7 @@ #include #include #include +#include Review Comment: why need -- This is an automated message from the

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060043589 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h Review Co

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060043698 ## include/nuttx/mm/mm_map.h: ## @@ -0,0 +1,72 @@ +/ + * include/nuttx/mm/mm_map.h + * + * Li

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060043819 ## drivers/video/fb.c: ## @@ -682,6 +675,30 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mmap(FAR struc

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060043955 ## drivers/video/video.c: ## @@ -38,6 +38,7 @@ #include #include +#include Review Comment: done ## drivers/video/fb.c: ## @@ -682,6 +675,30

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060044458 ## drivers/video/video.c: ## @@ -3200,6 +3198,21 @@ static int video_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int video_mma

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060045491 ## include/nuttx/fs/fs.h: ## @@ -169,6 +169,7 @@ struct stat; struct statfs; struct pollfd; struct mtd_dev_s; +struct mm_map_entry_s; Review Comment: done --

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060046003 ## fs/tmpfs/fs_tmpfs.c: ## @@ -36,6 +36,7 @@ #include #include #include +#include Review Comment: done -- This is an automated message from the Apache Git

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060046300 ## fs/tmpfs/fs_tmpfs.c: ## @@ -1658,20 +1656,13 @@ static int tmpfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) DEBUGASSERT(tfo != NULL); - /* Onl

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060046464 ## fs/romfs/fs_romfs.c: ## @@ -578,9 +582,7 @@ static off_t romfs_seek(FAR struct file *filep, off_t offset, int whence) static int romfs_ioctl(FAR struct file *file

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8012: optimize syslog speed

xiaoxiang781216 commented on code in PR #8012: URL: https://github.com/apache/nuttx/pull/8012#discussion_r1060042890 ## libs/libc/stream/lib_syslogstream.c: ## @@ -162,6 +192,56 @@ static void syslogstream_putc(FAR struct lib_outstream_s *this, int ch) } } +static int s

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060050736 ## fs/romfs/fs_romfs.c: ## @@ -618,6 +608,34 @@ static int romfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return -ENOTTY; } +static int romfs_mma

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060051009 ## fs/romfs/fs_romfs.c: ## @@ -27,6 +27,7 @@ #include #include #include +#include Review Comment: no need, leftovers from some earlier version (MAP_FAILED). r

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060051716 ## include/nuttx/fs/fs.h: ## @@ -300,6 +302,7 @@ struct mountpt_operations off_t (*seek)(FAR struct file *filep, off_t offset, int whence); int (*ioctl)(FAR

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060052856 ## drivers/video/fb.c: ## @@ -682,6 +675,29 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return ret; } +static int fb_mmap(FA

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060053901 ## fs/tmpfs/fs_tmpfs.c: ## @@ -1658,20 +1655,13 @@ static int tmpfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) DEBUGASSERT(tfo != NULL); -

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060054351 ## fs/romfs/fs_romfs.c: ## @@ -617,6 +606,35 @@ static int romfs_ioctl(FAR struct file *filep, int cmd, unsigned long arg) return -ENOTTY; } +static int ro

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060054669 ## fs/mmap/fs_mmap.c: ## @@ -135,14 +135,33 @@ static int file_mmap_(FAR struct file *filep, FAR void *start, #endif } - /* Perform the ioctl to get the

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060055210 ## fs/mmap/fs_mmap.c: ## @@ -135,14 +135,33 @@ static int file_mmap_(FAR struct file *filep, FAR void *start, #endif } - /* Perform the ioctl to get the base a

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

jlaitine commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060055210 ## fs/mmap/fs_mmap.c: ## @@ -135,14 +135,33 @@ static int file_mmap_(FAR struct file *filep, FAR void *start, #endif } - /* Perform the ioctl to get the base a

  1   2   >