xiaoxiang781216 commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059960988
##########
include/nuttx/fs/fs.h:
##########
@@ -298,6 +305,11 @@ struct mountpt_operations
size_t buflen);
off_t (*seek)(FAR struct file *filep, off_t offset, int whence);
int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg);
+ int (*truncate)(FAR struct file *filep, off_t length);
+ int (*mmap)(FAR struct file *filep, FAR struct mm_map_entry_s *map);
+ int (*munmap)(FAR struct task_group_s *group,
+ FAR struct mm_map_entry_s *map, void *start,
+ size_t length);
Review Comment:
Ok, if you want to suppor the partial unmap, the argument is required.
##########
include/nuttx/fs/fs.h:
##########
@@ -298,6 +305,11 @@ struct mountpt_operations
size_t buflen);
off_t (*seek)(FAR struct file *filep, off_t offset, int whence);
int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg);
+ int (*truncate)(FAR struct file *filep, off_t length);
+ int (*mmap)(FAR struct file *filep, FAR struct mm_map_entry_s *map);
+ int (*munmap)(FAR struct task_group_s *group,
+ FAR struct mm_map_entry_s *map, void *start,
+ size_t length);
Review Comment:
Ok, if you want to support the partial unmap, the argument is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
