[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7994: drivers/note: unify the spinlock operation in noteram

[GitBox]

Gary-Hobson commented on code in PR #7994:
URL: https://github.com/apache/nuttx/pull/7994#discussion_r1059994074


##########
drivers/note/noteram_driver.c:
##########
@@ -94,9 +94,7 @@ static const struct note_driver_ops_s g_noteram_ops =
   noteram_add
 };
 
-#ifdef CONFIG_SMP
 static volatile spinlock_t g_noteram_lock;

Review Comment:
   done



##########
drivers/note/noteram_driver.c:
##########
@@ -485,6 +471,7 @@ static ssize_t noteram_read(FAR struct file *filep,
 static int noteram_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
 {
   int ret = -ENOSYS;
+  int flags = spin_lock_irqsave_wo_note(&g_noteram_lock);

Review Comment:
   done



##########
drivers/note/noteram_driver.c:
##########
@@ -427,13 +412,14 @@ static ssize_t noteram_read(FAR struct file *filep,
 {
   ssize_t notelen;
   ssize_t retlen ;
+  int flags;

Review Comment:
   done



##########
drivers/note/noteram_driver.c:
##########
@@ -400,8 +386,7 @@ static ssize_t noteram_size(void)
   notelen = note->nc_length;
   DEBUGASSERT(notelen <= circlen);
 
-errout_with_csection:
-  leave_critical_section(flags);
+errout:

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org