[GitHub] [nuttx] jlaitine commented on a diff in pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

[GitBox]

jlaitine commented on code in PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#discussion_r1060046300


##########
fs/tmpfs/fs_tmpfs.c:
##########
@@ -1658,20 +1656,13 @@ static int tmpfs_ioctl(FAR struct file *filep, int cmd, 
unsigned long arg)
 
   DEBUGASSERT(tfo != NULL);
 
-  /* Only one ioctl command is supported */
-
-  if (cmd == FIOC_MMAP && ppv != NULL)
+  if (map != NULL)

Review Comment:
   done



##########
fs/romfs/fs_romfs.c:
##########
@@ -40,6 +41,7 @@
 #include <nuttx/kmalloc.h>
 #include <nuttx/fs/fs.h>
 #include <nuttx/fs/ioctl.h>
+#include <nuttx/mm/mm_map.h>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org