pkarashchenko commented on code in PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r907041715
##
include/endian.h:
##
@@ -51,23 +51,40 @@
/* Common byte swapping macros */
-#define __SWAP_UINT16_ISMACRO 1
-#undef __SWAP_UINT32_ISMACRO
-
-#ifde
xiaoxiang781216 opened a new pull request, #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529
## Summary
instead of -ETIMEOUT, as specify here:
https://pubs.opengroup.org/onlinepubs/009604599/functions/sendmsg.html
https://man7.org/linux/man-pages/man2/sendfile.2.html
pkarashchenko commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1166978738
@xiaoxiang781216 looking into CI I see some warnings like
```
warning: (NET_TCP_NO_STACK && NET_USRSOCK_TCP) selects NET_TCP which has
unmet direct dependencies (NET &&
pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907064003
##
net/sixlowpan/sixlowpan_tcpsend.c:
##
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
ret = net_timedwait
pkarashchenko commented on code in PR #6502:
URL: https://github.com/apache/incubator-nuttx/pull/6502#discussion_r907065957
##
arch/risc-v/src/common/riscv_common_memorymap.h:
##
@@ -0,0 +1,105 @@
+/
+ *
pkarashchenko commented on PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#issuecomment-1166993995
@xiaoxiang781216 please fix
```
tcp/tcp_send_unbuffered.c: In function 'psock_tcp_send':
Error: tcp/tcp_send_unbuffered.c:683:31: error: 'ETIMEOUT' undeclared (first
pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907068209
##
net/sixlowpan/sixlowpan_tcpsend.c:
##
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
ret = net_timedwait
pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907064003
##
net/sixlowpan/sixlowpan_tcpsend.c:
##
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
ret = net_timedwait
pkarashchenko commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r907070104
##
arch/risc-v/src/bl602/bl602_os_hal.h:
##
@@ -0,0 +1,186 @@
+/
+ * arch/risc-
pkarashchenko commented on code in PR #6492:
URL: https://github.com/apache/incubator-nuttx/pull/6492#discussion_r907082047
##
arch/arm/src/stm32wl5/hardware/stm32wl5_spi.h:
##
@@ -0,0 +1,277 @@
+/
+ * a
normanr commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r907084014
##
arch/risc-v/src/bl602/bl602_netdev.c:
##
@@ -2120,10 +2122,12 @@ void bl602_net_event(int evt, int val)
case CODE_WIFI_ON_DISCONNECT:
do
xiaoxiang781216 commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907105001
##
net/sixlowpan/sixlowpan_tcpsend.c:
##
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
ret = net_timedwa
adamkaliszan commented on PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1167047984
The commit is fine. I have decided to withdrawn possibility of configuration
LCD Command/Data pin because It is necessary to modify all boards.h files.
Possibility of configu
SunJun8 commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r907128491
##
arch/risc-v/src/bl602/bl602_netdev.c:
##
@@ -2120,10 +2122,12 @@ void bl602_net_event(int evt, int val)
case CODE_WIFI_ON_DISCONNECT:
do
SunJun8 commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r907129857
##
arch/risc-v/src/bl602/bl602_netdev.c:
##
@@ -2120,10 +2122,12 @@ void bl602_net_event(int evt, int val)
case CODE_WIFI_ON_DISCONNECT:
do
SunJun8 commented on PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#issuecomment-1167062787
@pkarashchenko thanks for your review, and I will update this part of the
code in due course
--
This is an automated message from the Apache Git Service.
To respond to the messa
pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907187495
##
net/icmp/icmp_sendmsg.c:
##
@@ -424,6 +424,8 @@ ssize_t icmp_sendmsg(FAR struct socket *psock, FAR struct
msghdr *msg,
{
if (ret ==
xiaoxiang781216 commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907216655
##
net/icmpv6/icmpv6_sendmsg.c:
##
@@ -415,6 +415,8 @@ ssize_t icmpv6_sendmsg(FAR struct socket *psock, FAR struct
msghdr *msg,
{
if
pussuw opened a new pull request, #6530:
URL: https://github.com/apache/incubator-nuttx/pull/6530
Ne numeric type defaults to u32 which is not enough to represent a
native memory location
This fixes build error:
https://github.com/apache/incubator-nuttx/runs/7067877053?check_sui
pussuw commented on PR #6502:
URL: https://github.com/apache/incubator-nuttx/pull/6502#issuecomment-1167182707
The fix for the build error is here:
https://github.com/apache/incubator-nuttx/pull/6530
--
This is an automated message from the Apache Git Service.
To respond to the message,
pussuw commented on code in PR #6502:
URL: https://github.com/apache/incubator-nuttx/pull/6502#discussion_r907237841
##
arch/risc-v/src/common/riscv_common_memorymap.h:
##
@@ -0,0 +1,105 @@
+/
+ * arch/r
pkarashchenko commented on code in PR #6502:
URL: https://github.com/apache/incubator-nuttx/pull/6502#discussion_r907258126
##
arch/risc-v/src/common/riscv_common_memorymap.h:
##
@@ -0,0 +1,105 @@
+/
+ *
curuvar commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1167273028
After thinking about this, I am going to change my driver so it works the
same (from the users point of view) as ws2812 and combine the two into the same
file. That way, any exis
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907324042
##
boards/xtensa/esp32/common/Kconfig:
##
@@ -77,10 +77,6 @@ config SSD1680_GPIO_PIN_CS
int "Pin that select the chip on SPI bus"
default "5
gustavonihei commented on PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1167289377
> The commit is fine. I have decided to withdrawn possibility of
configuration LCD Command/Data pin. The reason is following: it is necessary to
modify all boards.h files in
adamkaliszan commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907327484
##
boards/xtensa/esp32/common/src/esp32_board_spi.c:
##
@@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev,
uint32_t devid)
static i
adamkaliszan commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907329170
##
boards/xtensa/esp32/common/Kconfig:
##
@@ -77,10 +77,6 @@ config SSD1680_GPIO_PIN_CS
int "Pin that select the chip on SPI bus"
default "5
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907336480
##
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##
@@ -105,9 +105,8 @@ int board_lcd_initialize(void)
/* Initialize additional I/O for e-ink display
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907336480
##
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##
@@ -105,9 +105,8 @@ int board_lcd_initialize(void)
/* Initialize additional I/O for e-ink display
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907344567
##
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##
@@ -105,9 +105,8 @@ int board_lcd_initialize(void)
/* Initialize additional I/O for e-ink display
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907344567
##
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##
@@ -105,9 +105,8 @@ int board_lcd_initialize(void)
/* Initialize additional I/O for e-ink display
xiaoxiang781216 merged PR #6530:
URL: https://github.com/apache/incubator-nuttx/pull/6530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 77a01cfe52 mpfs: Fix IHC memory loca
hartmannathan commented on code in PR #6512:
URL: https://github.com/apache/incubator-nuttx/pull/6512#discussion_r907397184
##
drivers/syslog/Kconfig:
##
@@ -373,4 +373,13 @@ config SYSLOG_CHARDEV
byte output with no time-stamping or any other SYSLOG features
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907410201
##
.gitignore:
##
@@ -31,3 +31,5 @@ Make.dep
.context
# nuttx/$(TOPDIR)/Makefile.[unix|win]::$(DIRLINKS_EXTERNAL_DIRS)
.dirlinks
+.vscode
+.DS_Stor
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907410436
##
examples/neopixel/Make.defs:
##
@@ -0,0 +1,23 @@
+
+# apps/examples/hel
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907412611
##
examples/neopixel/Kconfig:
##
@@ -0,0 +1,33 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.t
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907413606
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907415347
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907416260
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907417764
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907418201
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907418899
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907419232
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907426496
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,301 @@
+/
+ * apps/exa
edsut opened a new issue, #6531:
URL: https://github.com/apache/incubator-nuttx/issues/6531
I am working with a Teensy4.1 and had a consistent hardfault whenever I
connected QGC to Mavlink over USB. I eventually realized that I did not have
CONFIG_USBDEV_DUALSPEED enabled, but line 1975 of
acassis commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1167454046
@curuvar currently there is only a board using @btashton original WS2812
driver, so I think you can modify his driver to include your improvement. Also
because there are many RBG
acassis commented on code in PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#discussion_r907485738
##
boards/arm/rp2040/adafruit-feather/README.txt:
##
@@ -0,0 +1,180 @@
+README
+==
+
+This directory contains the port of NuttX to the Adafruit Feather RP204
acassis commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1167470025
Nice work @curuvar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
curuvar commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907629441
##
.gitignore:
##
@@ -31,3 +31,5 @@ Make.dep
.context
# nuttx/$(TOPDIR)/Makefile.[unix|win]::$(DIRLINKS_EXTERNAL_DIRS)
.dirlinks
+.vscode
+.DS_Store
Re
btashton commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1167689285
Yeah there is at least one other person that modified it a bit to support a
non in-tree board but I fully support making changes to improve this even if it
does mean changing the
nimish opened a new pull request, #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532
## Summary
`-g` is either ignored (gnu linker, lld) or throws an error (mold). Either
way, it doesn't do anything and it's unclear why it's being added.
## Impact
`mold` doesn't
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1167724409
@nimish please squash the second patch into the first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiaoxiang781216 commented on code in PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532#discussion_r907680342
##
boards/renesas/m16c/skp16c26/scripts/Make.defs:
##
@@ -50,5 +50,4 @@ CPPFLAGS = $(ARCHINCLUDES) $(ARCHDEFINES)
$(EXTRAFLAGS)
AFLAGS
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1167728092
> @xiaoxiang781216 looking into CI I see some warnings like
>
> ```
> warning: (NET_TCP_NO_STACK && NET_USRSOCK_TCP) selects NET_TCP which has
unmet direct depend
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1167728916
> @nimish please squash the second patch into the first.
and the style warning:
```
../nuttx/tools/checkpatch.sh -m -g
4c2b7f3ac9052d50aa1c8fa20e643ce4bbf639c6
nimish commented on code in PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532#discussion_r907687397
##
arch/xtensa/src/lx7/Toolchain.defs:
##
@@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y)
endif
ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
- LDFLAGS +=
gustavonihei commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907691147
##
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##
@@ -105,9 +105,8 @@ int board_lcd_initialize(void)
/* Initialize additional I/O for e-ink display
acassis merged PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4afd25b567 this flag is meaningless fo
acassis commented on PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#issuecomment-1168021659
Very nice @zouboan !!! Are you planing to add an app/ example to use
/dev/capture0 ? Is it able to read PWM pulse used to control servo motors? I'm
thinking about connecting a PWM
zouboan commented on PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#issuecomment-1168036803
Ok，i will add a capture example in apps
---Original---
From: "Alan Carvalho de ***@***.***>
Date: Tue, Jun 28, 2022 07:10 AM
To: ***@***.***>;
Cc: ***@***
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 3428560 Publishing web
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1168147311
@nimish The inclusion of endian/Make.defs need be removed too:
```
Makefile:30: endian/Make.defs: No such file or directory
```
--
This is an automated message f
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 4afd25b567 this flag is meaningless for the linker
new fd8eaf4f42 arch/stm32_capture_lowerhalf.c: add
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit fd8eaf4f42a1a230fb2af1de4502093b414ceeed
Author: zouboan
AuthorDate: Sun Jun 26 19:52:36 2022 +0800
arc
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b41929522c9d86d35cec9cf80665bfeab49750ee
Author: zouboan
AuthorDate: Sun Jun 26 20:00:38 2022 +0800
dri
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 00e8e4fa28d957a257c94784235887e282220e01
Author: zouboan
AuthorDate: Sun Jun 26 20:54:57 2022 +0800
boa
xiaoxiang781216 merged PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 merged PR #6492:
URL: https://github.com/apache/incubator-nuttx/pull/6492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4f8c8815d6 Spi driver for Stm32wl55
xiaoxiang781216 commented on PR #6510:
URL: https://github.com/apache/incubator-nuttx/pull/6510#issuecomment-1168149374
@adamkaliszan will you fix the rest comment from @pkarashchenko ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
adamkaliszan commented on code in PR #6510:
URL: https://github.com/apache/incubator-nuttx/pull/6510#discussion_r907984008
##
drivers/lcd/ssd1680.c:
##
@@ -878,19 +896,30 @@ static void ssd1680_select(FAR struct ssd1680_dev_s
*priv, bool cs)
}
}
-static void ssd1680_bus
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new abc72ad128 net: Ensure sendmsg a
pkarashchenko merged PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
anchao opened a new pull request, #6533:
URL: https://github.com/apache/incubator-nuttx/pull/6533
## Summary
1. wireless/bcm43xxx: enable tx flow control to improve performance
RX/TX shared free queue on bcmf implementation, if TX occupies the
free queue completely, RX will t
XinStellaris commented on PR #6512:
URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1168281601
After all the discussion, sched_lock or critical section in this pr will
impact real-time behavior.
So I will change how the application calls syslog, by spliting long str
XinStellaris closed pull request #6512: driver/syslog:sched lock in syslog to
prevent garbled print from multi-thread
URL: https://github.com/apache/incubator-nuttx/pull/6512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
78 matches
Mail list logo
