[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6529: net: Ensure sendmsg and sendfile return -EAGAIN in case of timeout

[GitBox]

pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907068209


##########
net/sixlowpan/sixlowpan_tcpsend.c:
##########
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
               ret = net_timedwait(&sinfo.s_waitsem, timeout);
               if (ret != -ETIMEDOUT || acked == sinfo.s_acked)
                 {
+                  if (ret == -ETIMEOUT)

Review Comment:
   ```suggestion
                     if (ret == -ETIMEDOUT)
   ```



##########
net/tcp/tcp_send_unbuffered.c:
##########
@@ -680,6 +680,11 @@ ssize_t psock_tcp_send(FAR struct socket *psock,
                                   _SO_TIMEOUT(conn->sconn.s_sndtimeo));
               if (ret != -ETIMEDOUT || acked == state.snd_acked)
                 {
+                  if (ret == -ETIMEOUT)

Review Comment:
   ```suggestion
                     if (ret == -ETIMEDOUT)
   ```



##########
net/tcp/tcp_sendfile.c:
##########
@@ -583,6 +583,11 @@ ssize_t tcp_sendfile(FAR struct socket *psock, FAR struct 
file *infile,
               &state.snd_sem, _SO_TIMEOUT(conn->sconn.s_sndtimeo));
       if (ret != -ETIMEDOUT || acked == state.snd_acked)
         {
+          if (ret == -ETIMEOUT)

Review Comment:
   ```suggestion
             if (ret == -ETIMEDOUT)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org