gustavonihei commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907412611
##########
examples/neopixel/Kconfig:
##########
@@ -0,0 +1,33 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config EXAMPLE_NEOPIXEL
+ tristate "Neopixel Demo Program"
+ default n
+ ---help---
+ Enable the Neopixel demo
+
+if EXAMPLE_NEOPIXEL
+
+config EXAMPLE_NEOPIXEL_PROGNAME
+ string "Program Name"
+ default "neopixel"
+ ---help---
+ This is the name of the program that will be used when the NSH
ELF
+ program is installed.
+
+config EXAMPLE_NEOPIXEL_PRIORITY
+ int "Task Priority"
+ default 100
+
+config EXAMPLE_NEOPIXEL_STACKSIZE
+ int "Stack Size"
+ default DEFAULT_TASK_STACKSIZE
+
+config EXAMPLE_NEOPIXEL_DEFAULT_DEV
+ string "Default Device"
+ default "/dev/neopixel"
+
+endif
Review Comment:
```suggestion
config EXAMPLES_NEOPIXEL
tristate "Neopixel Demo Program"
default n
---help---
Enable the Neopixel demo
if EXAMPLES_NEOPIXEL
config EXAMPLES_NEOPIXEL_PROGNAME
string "Program Name"
default "neopixel"
---help---
This is the name of the program that will be used when the NSH
ELF
program is installed.
config EXAMPLES_NEOPIXEL_PRIORITY
int "Task Priority"
default 100
config EXAMPLES_NEOPIXEL_STACKSIZE
int "Stack Size"
default DEFAULT_TASK_STACKSIZE
config EXAMPLES_NEOPIXEL_DEFAULT_DEV
string "Default Device"
default "/dev/neopixel"
endif
```
The prefix on Kconfig options should be consistent to the actual file path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
