gustavonihei commented on code in PR #6511: URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r907336480
########## boards/xtensa/esp32/common/src/esp32_ssd1680.c: ########## @@ -105,9 +105,8 @@ int board_lcd_initialize(void) /* Initialize additional I/O for e-ink display */ -#if defined(CONFIG_SSD1680_GPIO_PIN_DTA_CMD) && \ - (CONFIG_SSD1680_GPIO_PIN_DTA_CMD >= 0) - esp32_configgpio(CONFIG_SSD1680_GPIO_PIN_DTA_CMD, OUTPUT); +#if defined(DISPLAY_DC) && (DISPLAY_DC >= 0) Review Comment: ```suggestion #if defined(DISPLAY_DC) ``` It seems too pedantic to check if a pin will be set with a negative number. I believe this check may be omitted for the sake of simplicity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
