pkarashchenko commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146756336
@davids5 are you ok with this PR and PR to the OS side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
pkarashchenko commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146756711
In general there is no harm in keeping the binary flag in code even if it is
0. But we can remove it of course.
--
This is an automated message from the Apache Git S
xiaoxiang781216 merged PR #6366:
URL: https://github.com/apache/incubator-nuttx/pull/6366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new cbcc748985 Fix wrong path in README
davids5 commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146766720
@pkarashchenko Thank you for asking. I see it as a breaking changes, that
does not add much value. But at least the compile will fail and trigger the
hunt for "What! Why is
xiaoxiang781216 commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146767600
> @pkarashchenko Thank you for asking. I see it as a breaking changes, that
does not add much value. But at least the compile will fail and trigger the
hunt for "Wha
xiaoxiang781216 commented on PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#issuecomment-1146769091
@davids5 this isn't breaking change, both flags still exist. BTW, no code in
NuttX handle O_BINARY/O_TEXT flag at all, how it will break your code?
--
This is an automat
davids5 commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146771281
@xiaoxiang781216 Thank you for detailed explanation. It would be appreciated
if your PR would include that sort of information when submitted.
--
This is an automated mes
xiaoxiang781216 opened a new pull request, #6367:
URL: https://github.com/apache/incubator-nuttx/pull/6367
## Summary
and make the column order same as ps output
## Impact
up_assert output
## Testing
--
This is an automated message from the Apache Git Service.
T
pkarashchenko commented on code in PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#discussion_r889670978
##
netutils/ftpd/ftpd.c:
##
@@ -1809,9 +1809,6 @@ static int ftpd_stream(FAR struct ftpd_session_s
*session, int cmdtype)
#if defined(O_LARGEFILE)
xiaoxiang781216 commented on code in PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#discussion_r889675891
##
netutils/ftpd/ftpd.c:
##
@@ -1809,9 +1809,6 @@ static int ftpd_stream(FAR struct ftpd_session_s
*session, int cmdtype)
#if defined(O_LARGEFILE
xiaoxiang781216 commented on PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#issuecomment-1146779724
> @xiaoxiang781216 Thank you for detailed explanation. It would be
appreciated if your PR would include that sort of information when submitted.
Ok.
--
This
masayuki2009 commented on PR #6365:
URL: https://github.com/apache/incubator-nuttx/pull/6365#issuecomment-1146783590
```
In file included from pthread/pthread_create.c:39:
pthread/pthread_create.c: In function 'nx_pthread_create':
Error: pthread/pthread_create.c:294:29: error: in
xiaoxiang781216 opened a new pull request, #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368
## Summary
to follow the call convention for d_txavail
## Impact
tcp timer process
## Testing
--
This is an automated message from the Apache Git Service.
fjpanag commented on code in PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#discussion_r889684150
##
drivers/syslog/syslog_channel.c:
##
@@ -259,13 +259,26 @@ int syslog_channel(FAR struct syslog_channel_s *channel)
int i;
#endif
+#if defined(CONFIG_SYS
fjpanag opened a new pull request, #6369:
URL: https://github.com/apache/incubator-nuttx/pull/6369
## Summary
When `SYSLOG_TIMESTAMP_FORMATTED` is selected, `SYSLOG_TIMESTAMP_FORMAT` is
used to format the date that syslog will print.
Although the formatting is configurable by t
pkarashchenko commented on code in PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#discussion_r889697224
##
drivers/syslog/syslog_channel.c:
##
@@ -259,13 +259,26 @@ int syslog_channel(FAR struct syslog_channel_s *channel)
int i;
#endif
+#if defined(CONF
pkarashchenko commented on code in PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#discussion_r889697609
##
drivers/syslog/syslog_channel.c:
##
@@ -259,13 +259,26 @@ int syslog_channel(FAR struct syslog_channel_s *channel)
int i;
#endif
+#if defined(CONF
pkarashchenko commented on code in PR #6363:
URL: https://github.com/apache/incubator-nuttx/pull/6363#discussion_r889697609
##
drivers/syslog/syslog_channel.c:
##
@@ -259,13 +259,26 @@ int syslog_channel(FAR struct syslog_channel_s *channel)
int i;
#endif
+#if defined(CONF
xiaoxiang781216 commented on PR #6365:
URL: https://github.com/apache/incubator-nuttx/pull/6365#issuecomment-1146813679
@masayuki2009 fixed, please try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 73d5a27702 Fix in default syslog dat
xiaoxiang781216 merged PR #6369:
URL: https://github.com/apache/incubator-nuttx/pull/6369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
zouboan commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146819240
@xiaoxiang781216 This is a broken commit, my custom boards can't working
properly after i merged with master branch. I'm revert by dichotomy, and
finally positioned on this commit
pkarashchenko commented on PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#issuecomment-1146819573
@xiaoxiang781216 could you please remove all the `devif_timer` from the
comments all over the code since it sipped from the
https://github.com/apache/incubator-nuttx/pull/63
pkarashchenko commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889702419
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Revi
pkarashchenko commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146832393
@zouboan So the code building is fine and the behavior of the board is
changed? Or it is a build issue that you are reporting?
If it is a build issue then maybe you can sh
pkarashchenko commented on code in PR #1186:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1186#discussion_r889704059
##
netutils/ftpd/ftpd.c:
##
@@ -1809,9 +1809,6 @@ static int ftpd_stream(FAR struct ftpd_session_s
*session, int cmdtype)
#if defined(O_LARGEFILE)
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889704647
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
xiaoxiang781216 commented on PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#issuecomment-1146835311
> @xiaoxiang781216 could you please remove all the `devif_timer` from the
comments all over the code since it sipped from the #6355 changes? Or a
separate PR is needed for
xiaoxiang781216 commented on PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#issuecomment-1146835342
> @xiaoxiang781216 could you please remove all the `devif_timer` from the
comments all over the code since it sipped from the #6355 changes? Or a
separate PR is needed for
xiaoxiang781216 commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889705947
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Re
zouboan commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146836663
@pkarashchenko the behavior of the board is changed, It seems that the board
to run very slowly, It seems that the optimization doesn't work. my custom
boards config as follow:
xiaoxiang781216 commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889705947
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Re
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889708727
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889708727
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
xiaoxiang781216 commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146843490
@zouboan could you run "make V=1" and compare the command line difference
between the bad output and the good one?
--
This is an automated message from the Apache Git Se
zouboan commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146845106
@xiaoxiang781216
before this commit:
CC: irq/irq_attach.c
arm-none-eabi-gcc -c -fno-common -fno-builtin -ffunction-sections
-fdata-sections -funwind-tables -Wall -Ws
xiaoxiang781216 commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146849296
The setting come from:
https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/Toolchain.defs#L60-L68
Please ensure you use `ARCHOPTIMIZATION +=` i
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889718855
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889718855
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889720763
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889722872
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889722872
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723118
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723118
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723118
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723118
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723625
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723816
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723816
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889724406
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889724890
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889725130
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889725758
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
xiaoxiang781216 commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889725801
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain an
pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889726557
##
libs/libc/stdio/lib_fopen.c:
##
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
{
/* Retain any
pkarashchenko commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889727647
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Revi
masayuki2009 commented on PR #6365:
URL: https://github.com/apache/incubator-nuttx/pull/6365#issuecomment-1146902677
>@masayuki2009 fixed, please try again.
@xiaoxiang781216
Hmm, the issue still happens.
```
$ qemu-6.2/build/riscv64-softmmu/qemu-system-riscv64 -semihostin
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new c3e050b Publishing web
zouboan commented on PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#issuecomment-1146926528
@xiaoxiang781216 Thanks for your help, there's a ARCHOPTIMIZATION = -g in my
Make.defs , and the problem has been solved now.
--
This is an automated message from the Apache Git
xiaoxiang781216 commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889787181
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Re
xiaoxiang781216 commented on PR #6365:
URL: https://github.com/apache/incubator-nuttx/pull/6365#issuecomment-1147010266
> > @masayuki2009 fixed, please try again.
>
> @xiaoxiang781216 Hmm, the issue still happens.
>
> ```
> $ qemu-6.2/build/riscv64-softmmu/qemu-system-riscv64
masayuki2009 commented on PR #6365:
URL: https://github.com/apache/incubator-nuttx/pull/6365#issuecomment-1147020150
>Could you tell me how to generate hello and init elf in the kernel mode?
Please try the following commands.
```
$ cd nuttx
pkarashchenko commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889819468
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Revi
pkarashchenko commented on code in PR #6367:
URL: https://github.com/apache/incubator-nuttx/pull/6367#discussion_r889829134
##
arch/arm/src/common/arm_assert.c:
##
@@ -172,44 +175,66 @@ static void arm_dump_task(struct tcb_s *tcb, void *arg)
}
#endif
+#ifndef CONFIG_DISA
xiaoxiang781216 commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889861137
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Re
pkarashchenko commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889862388
##
net/tcp/tcp_timer.c:
##
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Revi
67 matches
Mail list logo
