pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889723118


##########
libs/libc/stdio/lib_fopen.c:
##########
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
                   {
                     /* Retain any binary and exclusive mode selections */
 
-                    oflags &= (O_BINARY | O_EXCL);
+                    oflags &= FLAG_KEEP;

Review Comment:
   For stdio API I think text is the default, isn't it?
   I mean that I do not see the way how to open a file in text mode with 
`fopen`.
   I'm fine with the rest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to