pkarashchenko commented on code in PR #6368:
URL: https://github.com/apache/incubator-nuttx/pull/6368#discussion_r889819468
##########
net/tcp/tcp_timer.c:
##########
@@ -139,8 +140,10 @@ static void tcp_timer_expiry(FAR void *arg)
{
FAR struct tcp_conn_s *conn = arg;
+ net_lock();
Review Comment:
Performance value is zero if the system is multi threading unsafe. Let's
merge current change and think about performance improvement. Maybe having a
single work queue that is running at minimum of all connections timeout and
iterating all the connections may be a solution instead of half a second
periodic execution. I mean that it is a classic tick vs tickles mode problem,
so we can apply a classic solution for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
