[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6357: libc/stdio: Support 'e'(O_CLOEXEC) in lib_mode2oflags

[GitBox]

pkarashchenko commented on code in PR #6357:
URL: https://github.com/apache/incubator-nuttx/pull/6357#discussion_r889718855


##########
libs/libc/stdio/lib_fopen.c:
##########
@@ -209,42 +206,39 @@ int lib_mode2oflags(FAR const char *mode)
                   {
                     /* Retain any binary and exclusive mode selections */
 
-                    oflags &= (O_BINARY | O_EXCL);
+                    oflags &= FLAG_KEEP;

Review Comment:
   I do not see how `FLAG_KEEP` address issue that I'm writing about. Could you 
please help me to trace the flow?
   The commit that you posted address only `+` option, or I'm missing 
something? I'm trying to find out what will be the flow in case of 
`fopen("a.txt", "r");`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org