[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5503: sched/clock: Remove CLOCK_MONOTONIC option from Kconfig

pkarashchenko commented on a change in pull request #5503: URL: https://github.com/apache/incubator-nuttx/pull/5503#discussion_r808776699 ## File path: arch/arm/src/lc823450/lc823450_rtc.c ## @@ -550,10 +548,8 @@ int up_rtc_settime(FAR const struct timespec *ts) up_rtc_set_d

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

pkarashchenko commented on a change in pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808797207 ## File path: mm/iob/iob_alloc.c ## @@ -130,7 +130,27 @@ static FAR struct iob_s *iob_allocwait(bool throttled, * list. */

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5336: xtensa: use swint to swith context

Ouss4 commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1042711844 > I have modify up_enable_irq with this patch That's the part I was referring to as going to be a bit messy. :) It's just because we are going to treat the softwa

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808809882 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1108,6 +1117,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5518: tools/mkallsyms.sh: Disable the mismatch warning of builtin declaration

pkarashchenko commented on pull request #5518: URL: https://github.com/apache/incubator-nuttx/pull/5518#issuecomment-1042734272 could you please point to some warnings? I do not understand why we suppress debug option instead of fixing the declaration -- This is an automated message from

[GitHub] [incubator-nuttx] anchao opened a new pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

anchao opened a new pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527 ## Summary libs/libnx: workaround for compile issue on cortex-M0 ``` $ arm-none-eabi-gcc -c -g -Os -mcpu=cortex-m0 -isystem "include" -I "libs/libnx" nxmu/nx_eventhandler.c -o

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

pkarashchenko commented on a change in pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527#discussion_r808839116 ## File path: libs/libnx/nxmu/nx_eventhandler.c ## @@ -143,6 +143,10 @@ int nx_eventhandler(NXHANDLE handle) }

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

anchao commented on a change in pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808841190 ## File path: mm/iob/iob_alloc.c ## @@ -130,7 +130,27 @@ static FAR struct iob_s *iob_allocwait(bool throttled, * list. */ -

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1012: examples/foc: minor improvements

pkarashchenko merged pull request #1012: URL: https://github.com/apache/incubator-nuttx-apps/pull/1012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

anchao commented on a change in pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808845917 ## File path: mm/iob/iob_alloc.c ## @@ -93,7 +93,7 @@ static FAR struct iob_s *iob_alloc_committed(enum iob_user_e consumerid) * *

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5496: Remove duplicate linker script definitions

pkarashchenko commented on pull request #5496: URL: https://github.com/apache/incubator-nuttx/pull/5496#issuecomment-1042748569 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

pkarashchenko commented on pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#issuecomment-1042750799 Do we have `-Wnonnull` enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

pkarashchenko commented on a change in pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808849414 ## File path: include/nuttx/mm/iob.h ## @@ -233,6 +233,23 @@ struct iob_userstats_s void iob_initialize(void); +/**

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5475: drivers/pipe: Don't use sched_[lock|unlock] to do protection

pkarashchenko commented on a change in pull request #5475: URL: https://github.com/apache/incubator-nuttx/pull/5475#discussion_r808851731 ## File path: drivers/pipes/pipe_common.c ## @@ -232,19 +232,18 @@ int pipecommon_open(FAR struct file *filep) dev->d_nreaders++;

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

anchao commented on a change in pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527#discussion_r808857712 ## File path: libs/libnx/nxmu/nx_eventhandler.c ## @@ -143,6 +143,10 @@ int nx_eventhandler(NXHANDLE handle) } }

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

pkarashchenko commented on a change in pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527#discussion_r808858528 ## File path: libs/libnx/nxmu/nx_eventhandler.c ## @@ -143,6 +143,10 @@ int nx_eventhandler(NXHANDLE handle) }

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

anchao commented on a change in pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808860428 ## File path: include/nuttx/mm/iob.h ## @@ -233,6 +233,23 @@ struct iob_userstats_s void iob_initialize(void); +/*

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

pkarashchenko commented on a change in pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527#discussion_r808861949 ## File path: libs/libnx/nxmu/nx_eventhandler.c ## @@ -143,6 +143,10 @@ int nx_eventhandler(NXHANDLE handle) }

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808863477 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1053,6 +1053,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf, ssize

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808864088 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1108,6 +1117,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf, non

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808866316 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1053,6 +1053,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808867410 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808869846 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808875154 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1108,6 +1117,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808877388 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808877388 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808883076 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[incubator-nuttx-apps] branch master updated (b1276ea -> 81f1593)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from b1276ea system/adb: Change the default value of ADBD_PAYLOAD_SIZE to 1024 add 95b1625 ex

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808889807 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5527: libs/libnx: workaround for compile issue on cortex-M0

pkarashchenko commented on pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527#issuecomment-1042792318 Now I think we can remove `workaround` from both commit message and title -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5528: sched/semaphore/sem_clockwait: fix typo in comment

pkarashchenko opened a new pull request #5528: URL: https://github.com/apache/incubator-nuttx/pull/5528 ## Summary Typo detected ## Impact None ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5522: Fix binfmt for BUILD_KERNEL & ADDRENV

pkarashchenko merged pull request #5522: URL: https://github.com/apache/incubator-nuttx/pull/5522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] pkarashchenko edited a comment on pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

pkarashchenko edited a comment on pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#issuecomment-1042750799 Do we have `-Werror=nonnull` enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5503: sched/clock: Remove CLOCK_MONOTONIC option from Kconfig

pkarashchenko commented on pull request #5503: URL: https://github.com/apache/incubator-nuttx/pull/5503#issuecomment-1042815193 In general I think that migration to `clock_systime_timespec` wherever possible is ok, but we should have some profiling what is the memory increase by enabling `

[incubator-nuttx-apps] branch master updated (b1276ea -> 81f1593)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from b1276ea system/adb: Change the default value of ADBD_PAYLOAD_SIZE to 1024 add 95b1625 ex

[incubator-nuttx] branch master updated (bc12260 -> 41d6203)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from bc12260 dp83848c ethernet phy interrupt support add a44a0a0 binfmt: Call umm_initialize() for

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5336: xtensa: use swint to swith context

zhuyanlinzyl commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1042868665 @Ouss4 So, Does revert this patch is a nice work? > arch/xtensa/esp32: Map NuttX's IRQs to ESP32 CPU interrupts. This map

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5336: xtensa: use swint to swith context

Ouss4 commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1042871254 I don't think we can revert that commit, it includes more than just internal CPU handling. I think we can do something as you suggested and treat internal interrupt

[GitHub] [incubator-nuttx] Ouss4 merged pull request #5528: sched/semaphore/sem_clockwait: fix typo in comment

Ouss4 merged pull request #5528: URL: https://github.com/apache/incubator-nuttx/pull/5528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[incubator-nuttx] branch master updated (41d6203 -> 7933442)

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 41d6203 mm: umm_heap: Fix umm_heap for BUILD_KERNEL & ADDRENV add 7933442 sched/semaphore/sem_cl

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5336: xtensa: use swint to swith context

zhuyanlinzyl commented on pull request #5336: URL: https://github.com/apache/incubator-nuttx/pull/5336#issuecomment-1042876268 @Ouss4 Okay. Thanks for you advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-nuttx] acassis commented on pull request #5510: vncserver: Fix dead lock on re-connect

acassis commented on pull request #5510: URL: https://github.com/apache/incubator-nuttx/pull/5510#issuecomment-1042879667 Thank you @no1wudi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808985350 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1053,6 +1053,15 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf, ssize

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808991846 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1177,24 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5527: libs/libnx: handle the bad message correctly

pkarashchenko merged pull request #5527: URL: https://github.com/apache/incubator-nuttx/pull/5527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (7933442 -> 4824ea6)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7933442 sched/semaphore/sem_clockwait: fix typo in comment add 4824ea6 libs/libnx: handle the

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809012387 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809012387 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809012387 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809012387 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809031539 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809052145 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #5449: Error: unaligned opcodes detected in executable segment

xiaoxiang781216 commented on issue #5449: URL: https://github.com/apache/incubator-nuttx/issues/5449#issuecomment-1042967270 Can we close this issue now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] pkarashchenko closed issue #5449: Error: unaligned opcodes detected in executable segment

pkarashchenko closed issue #5449: URL: https://github.com/apache/incubator-nuttx/issues/5449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #5449: Error: unaligned opcodes detected in executable segment

pkarashchenko commented on issue #5449: URL: https://github.com/apache/incubator-nuttx/issues/5449#issuecomment-1042968527 @xiaoxiang781216 yes. I was expecting that it will be closed automatically -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809069471 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

no1wudi opened a new pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529 ## Summary * Rename up_fault to riscv_fault as other arch does * risc-v/qemu-rv: Supports SMP up to 8 cores ## Impact QEMU-RV ## Testing QEMU -- This is an automated me

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809072409 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809076452 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

pkarashchenko commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809079041 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

xiaoxiang781216 commented on pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#issuecomment-1042983225 > Do we have `-Werror=nonnull` enabled? We enable -Wall in all Make.defs and enable -Werror int tools/ci/cibuild.sh. -- This is an automated message fro

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

anchao commented on a change in pull request #5526: URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r809097536 ## File path: net/tcp/tcp_send_buffered.c ## @@ -1172,7 +1204,12 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5475: drivers/pipe: Don't use sched_[lock|unlock] to do protection

xiaoxiang781216 commented on a change in pull request #5475: URL: https://github.com/apache/incubator-nuttx/pull/5475#discussion_r809100801 ## File path: drivers/pipes/pipe_common.c ## @@ -232,19 +232,18 @@ int pipecommon_open(FAR struct file *filep) dev->d_nreaders++;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

xiaoxiang781216 commented on a change in pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#discussion_r809108104 ## File path: arch/risc-v/src/qemu-rv/qemu_rv_irq_dispatch.c ## @@ -67,6 +67,11 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t *r

[GitHub] [incubator-nuttx] davids5 commented on pull request #5523: dp83848c ethernet phy interrupt support

davids5 commented on pull request #5523: URL: https://github.com/apache/incubator-nuttx/pull/5523#issuecomment-1043020643 Should this be a board level setting based on the wiring? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

acassis commented on a change in pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#discussion_r809133113 ## File path: arch/risc-v/src/qemu-rv/qemu_rv_start.c ## @@ -60,10 +60,15 @@ uintptr_t g_idle_topstack = QEMU_RV_IDLESTACK_TOP; * Name: qemu_rv_

[incubator-nuttx] branch master updated: mm/iob: add support of alloc with timeout iob_timedalloc()

This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0b18cfb mm/iob: add support of alloc

[GitHub] [incubator-nuttx] acassis merged pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

acassis merged pull request #5524: URL: https://github.com/apache/incubator-nuttx/pull/5524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

pkarashchenko commented on a change in pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#discussion_r809137279 ## File path: libs/libc/time/lib_asctimer.c ## @@ -70,10 +70,13 @@ static const char * const g_mon_name[12] = FAR char *asctime_r(FAR con

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809143638 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx] jcursiolf opened a new issue #5530: libxx "C++ Example using CMake" guide "No thread API" error

jcursiolf opened a new issue #5530: URL: https://github.com/apache/incubator-nuttx/issues/5530 I am new to NuttX and I have been trying to use the "[C++ Example using CMake](https://nuttx.apache.org/docs/latest/guides/cpp_cmake.html)" guide available in the official documentation. No chan

[GitHub] [incubator-nuttx] anchao opened a new pull request #5531: net/socket: fix shadow variable

anchao opened a new pull request #5531: URL: https://github.com/apache/incubator-nuttx/pull/5531 ## Summary net/socket: fix shadow variable socket/setsockopt.c: In function ‘psock_socketlevel_option’: socket/setsockopt.c:168:38: warning: declaration of ‘conn’ shadows

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

pkarashchenko commented on a change in pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525#discussion_r809168868 ## File path: net/tcp/tcp_wrbuffer.c ## @@ -133,7 +136,13 @@ FAR struct tcp_wrbuffer_s *tcp_wrbuffer_alloc(void) * buffer */ - ne

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5519: Fix -Werror=nonnull-compare and -Werror=format-truncation=

hartmannathan commented on a change in pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#discussion_r809164741 ## File path: libs/libc/string/lib_memchr.c ## @@ -49,17 +49,14 @@ FAR void *memchr(FAR const void *s, int c, size_t n) { FAR const unsi

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809143638 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx] minabeoki opened a new pull request #5532: mm: fix gran_alloc() array index range checking

minabeoki opened a new pull request #5532: URL: https://github.com/apache/incubator-nuttx/pull/5532 ## Summary At the last loop `if (granidx < priv->ngranules)` condition is ture, `priv->gat[gatidx + 1]` reference to out of range. So, correct condition of next entry is `if (

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809181408 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

anchao commented on a change in pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525#discussion_r809181700 ## File path: net/tcp/tcp_wrbuffer.c ## @@ -133,7 +136,13 @@ FAR struct tcp_wrbuffer_s *tcp_wrbuffer_alloc(void) * buffer */ - net_locke

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

pkarashchenko commented on a change in pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525#discussion_r809183437 ## File path: net/utils/net_lock.c ## @@ -497,4 +502,30 @@ FAR struct iob_s *net_ioballoc(bool throttled, enum iob_user_e consumerid)

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

pkarashchenko commented on pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525#issuecomment-1043084534 Other parts LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-nuttx] ptka opened a new pull request #5533: Default macro to compile one Rust file.

ptka opened a new pull request #5533: URL: https://github.com/apache/incubator-nuttx/pull/5533 ## Summary Assuming, there's some interest to use Rust within NuttX (similar to ideas Linux is looking at), this is a small first step for a simple "hello_rust" example in apps. ## Impa

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809213159 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809213159 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5498: sched: Implement task local storage

pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r809220542 ## File path: sched/task/task_tls_alloc.c ## @@ -0,0 +1,113 @@ +/***

[GitHub] [incubator-nuttx-apps] zouboan commented on pull request #1001: industry/foc: add support for angle from sensorless observer

zouboan commented on pull request #1001: URL: https://github.com/apache/incubator-nuttx-apps/pull/1001#issuecomment-1043155985 @raiden00pl I'm separate out the code about speed, and redesigned based on PR https://github.com/apache/incubator-nuttx/pull/5483 please review it once more

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

pkarashchenko commented on pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525#issuecomment-1043159384 Great work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5531: net/socket: fix shadow variable

pkarashchenko merged pull request #5531: URL: https://github.com/apache/incubator-nuttx/pull/5531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (0b18cfb -> c73df52)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0b18cfb mm/iob: add support of alloc with timeout iob_timedalloc() add c73df52 net/socket: fix

[incubator-nuttx] branch master updated: Default macro to compile one Rust file

This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8828a43 Default macro to compile one

[GitHub] [incubator-nuttx] acassis merged pull request #5533: tools: Default macro to compile one Rust file.

acassis merged pull request #5533: URL: https://github.com/apache/incubator-nuttx/pull/5533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-nuttx] 02/02: net/tcp: add interface tcp_wrbuffer_timedalloc()

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1911ae219255ab34a7b19c299b378838116e7de1 Author: chao.an AuthorDate: Thu Feb 17 12:58:00 2022 +0800

[incubator-nuttx] branch master updated (8828a43 -> 1911ae2)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8828a43 Default macro to compile one Rust file new a92d5f6 net/ioballoc: add support of alloc

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5525: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

pkarashchenko merged pull request #5525: URL: https://github.com/apache/incubator-nuttx/pull/5525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] 01/02: net/ioballoc: add support of alloc with timeout net_iobtimedalloc()

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a92d5f622e322230e71435431a23fc6f132b4b69 Author: chao.an AuthorDate: Thu Feb 17 12:42:35 2022 +0800

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5523: dp83848c ethernet phy interrupt support

pkarashchenko commented on pull request #5523: URL: https://github.com/apache/incubator-nuttx/pull/5523#issuecomment-1043437977 @lipan118 could you please answer @davids5 's question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5506: arch/armv7-a/r: unify switch context from software interrupt

pkarashchenko commented on pull request #5506: URL: https://github.com/apache/incubator-nuttx/pull/5506#issuecomment-1043440682 @anchao please resolve merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[incubator-nuttx] branch master updated (1911ae2 -> e0ae296)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1911ae2 net/tcp: add interface tcp_wrbuffer_timedalloc() new fe04eb5 drivers/pipe: Fix the for

[incubator-nuttx] 01/02: drivers/pipe: Fix the format style issue

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit fe04eb535f59d946f4bfbbeee6a336fcadbc7639 Author: Xiang Xiao AuthorDate: Wed Feb 9 02:09:59 2022 +0800

[incubator-nuttx] 02/02: drivers/pipe: Don't use sched_[lock|unlock] to do protection

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e0ae2963d218054eb934bf14572fd83ae4460bd4 Author: Xiang Xiao AuthorDate: Wed Feb 9 02:39:15 2022 +0800

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5475: drivers/pipe: Don't use sched_[lock|unlock] to do protection

pkarashchenko merged pull request #5475: URL: https://github.com/apache/incubator-nuttx/pull/5475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >