[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5524: mm/iob: add support of alloc with timeout iob_timedalloc()

[GitBox]

anchao commented on a change in pull request #5524:
URL: https://github.com/apache/incubator-nuttx/pull/5524#discussion_r808841190



##########
File path: mm/iob/iob_alloc.c
##########
@@ -130,7 +130,27 @@ static FAR struct iob_s *iob_allocwait(bool throttled,
        * list.
        */
 
-      ret = nxsem_wait_uninterruptible(sem);
+      if (timeout == UINT_MAX)
+        {
+          ret = nxsem_wait_uninterruptible(sem);
+        }
+      else
+        {
+          struct timespec abstime;
+
+          DEBUGVERIFY(clock_gettime(CLOCK_REALTIME, &abstime));

Review comment:
       need absolute time here:
   
https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/semaphore.h#L546




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org