[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5526: net/tcp: add support for send timeout on buffer mode

[GitBox]

anchao commented on a change in pull request #5526:
URL: https://github.com/apache/incubator-nuttx/pull/5526#discussion_r808869846



##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -1172,7 +1190,25 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR 
const void *buf,
               goto errout_with_lock;
             }
 
-          net_lockedwait_uninterruptible(&conn->snd_sem);
+          current = TICK2MSEC(clock_systime_ticks());
+          if (expire == UINT_MAX)
+            {
+              remain = UINT_MAX;
+            }
+          else if (expire > current)
+            {
+              remain = expire - current;
+            }
+          else
+            {
+              remain = 0;
+            }
+
+          ret = net_timedwait_uninterruptible(&conn->snd_sem, remain);

Review comment:
       which is impossible, 
   ```
   
   current = TICK2MSEC(clock_systime_ticks());
   if (expire == UINT_MAX)
     {
       remain = UINT_MAX;              = UINT_MAX
     }
   else if (expire > current)
     {
       remain = expire - current;        > 0
     }
   else
     {
       remain = 0;                       = 0
     }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org