pkarashchenko commented on a change in pull request #5525:
URL: https://github.com/apache/incubator-nuttx/pull/5525#discussion_r809183437



##########
File path: net/utils/net_lock.c
##########
@@ -497,4 +502,30 @@ FAR struct iob_s *net_ioballoc(bool throttled, enum 
iob_user_e consumerid)
 
   return iob;
 }
+
+/****************************************************************************
+ * Name: net_ioballoc
+ *
+ * Description:
+ *   Allocate an IOB.  If no IOBs are available, then atomically wait for
+ *   for the IOB while temporarily releasing the lock on the network.
+ *
+ *   Caution should be utilized.  Because the network lock is relinquished
+ *   during the wait, there could be changes in the network state that occur
+ *   before the lock is recovered.  Your design should account for this
+ *   possibility.
+ *
+ * Input Parameters:
+ *   throttled - An indication of the IOB allocation is "throttled"

Review comment:
       second parameter is not described

##########
File path: net/utils/net_lock.c
##########
@@ -465,20 +469,21 @@ int net_lockedwait_uninterruptible(sem_t *sem)
  *
  * Input Parameters:
  *   throttled - An indication of the IOB allocation is "throttled"
+ *   timeout   - The relative time to wait until a timeout is declared.

Review comment:
       third parameter is not described




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to