xiaoxiang781216 merged PR #12394:
URL: https://github.com/apache/nuttx/pull/12394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
jerpelea commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2159846738
> @jerpelea
>
> I changed it from HAS_PWR_DIRECT_SMPS_SUPPLY to
STM32H7_HAVE_PWR_DIRECT_SMPS_SUPPLY and I rebased onto the current NuttX master
and force pushed.
if you che
jfbblue0922 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2159783865
@jerpelea
I changed it from HAS_PWR_DIRECT_SMPS_SUPPLY to
STM32H7_HAVE_PWR_DIRECT_SMPS_SUPPLY
and I rebased onto the current NuttX master and force pushed.
--
This is an
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1634179013
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,34 @@ config STM32H7_HAVE_SMPS
bool
default n
+config HAS_PWR_DIRECT_SMPS_SUPPLY
Review Comme
xiaoxiang781216 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1632637883
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,34 @@ config STM32H7_HAVE_SMPS
bool
default n
+config HAS_PWR_DIRECT_SMPS_SUPPLY
Review C
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1632556615
##
arch/arm/src/stm32h7/hardware/stm32h7x3xx_pwr.h:
##
@@ -129,16 +129,18 @@
#define STM32_PWR_CR3_BYPASS(1 << 0) /* Bit 0: Power
management un
xiaoxiang781216 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1630962729
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,34 @@ config STM32H7_HAVE_SMPS
bool
default n
+config HAS_PWR_DIRECT_SMPS_SUPPLY
Review C
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1630840978
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Se
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1630840714
##
boards/Kconfig:
##
@@ -1747,6 +1747,7 @@ config ARCH_BOARD_NUCLEO_H745ZI
depends on ARCH_CHIP_STM32H745ZI
select ARCH_HAVE_LEDS
select AR
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1630840345
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Se
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1630839969
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,23 @@ config STM32H7_HAVE_SMPS
bool
default n
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
- b
xiaoxiang781216 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1628724081
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Suppl
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1628712966
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Se
xiaoxiang781216 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1628633233
##
boards/Kconfig:
##
@@ -1747,6 +1747,7 @@ config ARCH_BOARD_NUCLEO_H745ZI
depends on ARCH_CHIP_STM32H745ZI
select ARCH_HAVE_LEDS
selec
acassis commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1627705169
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Select
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1627543032
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Select
xiaoxiang781216 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1625687533
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,23 @@ config STM32H7_HAVE_SMPS
bool
default n
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
-
xiaoxiang781216 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2147064555
> @davids5 @xiaoxiang781216
>
> I rebased and pushed but nothing changed. What should we do?
Kconfig has syntax error:
```
CMake Warning at CMakeLists.txt:343 (m
jfbblue0922 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2147046133
@davids5
@xiaoxiang781216
I rebased and pushed but nothing changed.
What should we do?
--
This is an automated message from the Apache Git Service.
To respond to the
xiaoxiang781216 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2145187475
ci break is fixed one week ago, @jfbblue0922 please rebase your patch to
the latest master.
--
This is an automated message from the Apache Git Service.
To respond to the messa
davids5 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2145166834
@jfbblue0922 - hmm Look Like CI is still not happy. @xiaoxiang781216 Any
ideas what it broken?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
davids5 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2139207910
> @davids5
>
> I agree with your method. I've confirmed that this method works correctly.
Thank you for your help.
Great! You are very welcome. Now we just have to get CI to
jfbblue0922 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2139185454
@davids5
I agree with your method.
I've confirmed that this method works correctly.
Thank you for your help.
--
This is an automated message from the Apache Git Serv
davids5 commented on PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#issuecomment-2137523349
@jfbblue0922 Please see
https://github.com/nuttx-to-asf/incubator-nuttx/commit/c6cedbaa23161950b18caed94af54b549ef8a4b1
It is the approach I had suggested originally. It adds the LDO
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618789143
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618784990
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618664670
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618085133
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618084948
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,55 @@ config STM32H7_HAVE_SMPS
bool
default n
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
- b
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1617037732
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,55 @@ config STM32H7_HAVE_SMPS
bool
default n
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
- bool
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1617013669
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,27 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Se
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1613328576
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,7 +886,19 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1613246450
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,27 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Select
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1613248932
##
arch/arm/src/stm32h7/Kconfig:
##
@@ -284,11 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Se
jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1613248451
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,12 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK
davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1611468553
##
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##
@@ -886,6 +886,12 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
jfbblue0922 opened a new pull request, #12394:
URL: https://github.com/apache/nuttx/pull/12394
@acassis
@davids5
we made PR again.
・Add new CONFIG_STM32H7_PWR_LDO_SUPPLY macro to "Kconfig".
・Delete "stm32h7x5xx_rcc.c" and add ONFIG_STM32H7_PWR_LDO_SUPPLY macro to
"stm32h7
davids5 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2122508828
@jfbblue0922 - the Kconfig will need to contain a section, that the chip
will enable modes for that package. The user can select mode for that, It is
critical that the default for this ch
jfbblue0922 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2121557049
@acassis
It turns out that this problem is not specific to stm32h755II.
There are 6 power supply methods for stm32h7.
We use '1.LDO supply' instead of '2.Direct SMPS supply
acassis commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2120377321
@jfbblue0922 something like:
```
#if defined(CONFIG_ARCH_CHIP_STM32H755II)
#define STM32_PWR_CR3_VALUE (STM32_PWR_CR3_LDOEN)
#else
#define STM32_PWR_CR3_VALUE (STM32_PWR_
jfbblue0922 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2120006918
@davids5
Thank you for your suggestions.
I would like to revise it again according to your suggestions.
I would like to modify it within stm32h7x3xx_rcc.c instead o
acassis commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2117625039
@jfbblue0922 Please consider creating a macro that has different values for
that STM32_PWR_CR3 depending on which model of microcontroller is defined.
--
This is an automated message fr
davids5 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2117615391
This PR add a file with a #ifdef of an undefined value and and is total
code duplication. @acassis How do you want to clean up your oops?
--
This is an automated message from the Apac
acassis commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2117610192
oops, sorry @davids5 I just saw the approaved and thought is was fixed
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
davids5 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2117591129
@acassis Why did you merge this with a request to change it open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
acassis merged PR #12350:
URL: https://github.com/apache/nuttx/pull/12350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
davids5 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1604680979
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_STM32
jfbblue0922 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2117110960
@acassis
I did squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jfbblue0922 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1604612950
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_S
acassis commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2115293993
@jfbblue0922 please squash the commits:
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
--
This is an au
davids5 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1602775243
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_STM32
davids5 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1602775243
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_STM32
davids5 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1602775243
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_STM32
davids5 commented on code in PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#discussion_r1602775243
##
arch/arm/src/stm32h7/stm32_rcc.c:
##
@@ -59,7 +59,7 @@
#elif defined(CONFIG_STM32H7_STM32H7B3XX)
# include "stm32h7x3xx_rcc.c"
#elif defined(CONFIG_STM32H7_STM32
jfbblue0922 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2114250960
@acassis
Thank you for your advice.
I've corrected the file.
@davids5
I created a new stm32h7x5xx_rcc.c based on the file stm32h7x3xx_rcc.c.
The current s
davids5 commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2113397971
@jfbblue0922 What is the diff from the the exiting rcc look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
acassis commented on PR #12350:
URL: https://github.com/apache/nuttx/pull/12350#issuecomment-2112553331
Hi @jfbblue0922 thank you for your first contribution! I hope you attend our
NuttX International Workshop in Japan next month (more info:
https://events.nuttx.apache.org).
Please f
57 matches
Mail list logo
