acassis commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1627705169


##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -284,10 +284,24 @@ config STM32H7_HAVE_SMPS
        bool
        default n
 
+choice
+       prompt "STM32 H7 Power Supply Selection"
+       default STM32H7_PWR_DIRECT_SMPS_SUPPLY
+       depends on !ARCH_BOARD_NUCLEO_H745ZI && !NUCLEOH745ZI_SMPS

Review Comment:
   @jfbblue0922 I suggest you create a symbol at stm32h7/Kconfig (i.e. 
HAS_PWM_DIRECT_SMPS_MODE) and at boards/Kconfig his symbol is enabled, this way 
you can add `depends on HAS_PWM_DIRECT_SMPS_MODE`.
   
   This is how we do for other features.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to